From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08D6F39DBF7 for ; Mon, 23 Mar 2026 12:27:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774268872; cv=none; b=nBBlVKKVO2dwwPaMt7unKHeKUJSaQJ2j6Zo1S7n4AFnVY6SaRnqWlkeJhsV/Vv+4Rj6WQsuJLj2S/3jIwU1ovqpmXigFY9zr/tOuhk8RGPz6F1rkr31PqGBQVB49yNYoHbYHpBRQ5W/QPiYWwirUAPC96na0xkK6iXJVYLmr32s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774268872; c=relaxed/simple; bh=WugqA9yyDrviBAh0oWni+13P4SXt1aezRSrY3nIa230=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YOsA8UG8oYl0jNckYY5dmDasSl1dC9AvqX3rDJxn0i8E32wJo0irddmEhNTz0N/TCBbsRBJctBPTZLsAQHrC95dD5JRRlIl+UHAnQu6SaGeNKohGaqOLhv6TBUdv5tRpxZG4e8eKAiCXEEtyL+vTOQF+4Ew2WlaOZf26vSrcYFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oqyXUA+e; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D3zaIauB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oqyXUA+e"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D3zaIauB" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N7Wa0I562075 for ; Mon, 23 Mar 2026 12:27:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= n5X6SCCrZlhH0x7gW7E0uH0Hbsvi0PHB4OLS3xzpkYs=; b=oqyXUA+eQddQwFEZ F06Q3nB093RH9ixHXHtfqBcpobMOMhWInd0ug2SJgr2WdTffxYbLKocnlvPt+qqL mNu2Mm4Fkzk22fqpgQxZklSdL1KIJ5yk99mRutwwC0zHxilhEMM7jO+XQ6PRIO/W 4zZWydokO2GgcM2AjTGfI9hOVlYzxIk/NPWO2RQGA4jUVzaKut61KI6MQmrJ4pdi pAC2bk9rTQpCczMvoFAYXnqEUljesYw0jROycVtyX8kV4cihuSs0ts0IdJFylRTz eVJaqDMkapL6y9mDf13idd+rK127kAPZ47i9IIFnjnQEqjbQr0heyMxYVKbc62sp /yRX1w== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d1jwvnc1t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 12:27:49 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50b32feb719so27136971cf.2 for ; Mon, 23 Mar 2026 05:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774268869; x=1774873669; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n5X6SCCrZlhH0x7gW7E0uH0Hbsvi0PHB4OLS3xzpkYs=; b=D3zaIauBijrlLssGXrJwTM6S1HsAGoGkKWoyIwGMJCmmlRzSow8WXPF/60ZYwKHULx U0X3sFM8Fqcs9Jplnn8q9gv6hoKfCHHXjciUvY8Je33SbOsKs6U1FtmQ2CeP8N/SEq45 VVZg9xvEIVAHeFHbix+AWzQGhewSNFKORuF1S1JR2UTIoFHpsTt1GlMQkFPOKJGYVXLD fXUX3RkuRLdjAul2pnH2q8qvdGoF6HfyloWyRai7X8nPgxDBN2ZW6KEGyGRr9Xg4z0uC bcpFEIpaFSq1+yLDVHLaBeHIgwoXkURDLPKRoh9wBb5TWZq98RU2cqNQg7c8mrEcy5hy 92Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774268869; x=1774873669; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n5X6SCCrZlhH0x7gW7E0uH0Hbsvi0PHB4OLS3xzpkYs=; b=D3myh43d0rIDXvpJMahtxo2yZhT022bobbKG44Jox+z7FpJLfy2jREtRYt/3EXgVx5 VoW0uXM0LtV+ZzzHrpaBuVjY7LMA1jYSRTPaLQAJQXdDZyy7nesMOq3yY5hZWtULJrUR 0zZADtWqhQMSv/d76JK+MBOl0Mur3V4o0h8C1/1q1dIi24cxDb1IVXHxz3GSAI1nKCT2 oApZRLewHXLelVVoHjDvidEFS8dAw/Bfb6bTRW1UX8eluohtgzH35CYPfq/lfkzhkf0M RsfbQSrSjuGEYTpnPdSX7EyiGmMB87MoSyPqtRslKF+k5Kg2Uh8iQUGn50+7Y1tU7xew lJ8w== X-Forwarded-Encrypted: i=1; AJvYcCXVtHbc0rU5F22jQnjXFcTYWfVNO0l668jwEgqXAQbkpbRD1+x9TSq+eaRgk6dpXfgfWQ/XxYCn4E2xAZA=@vger.kernel.org X-Gm-Message-State: AOJu0YypGTGc+P180NpVk8vZOuRRY8QHunwWqkUXe0PTD1jCm/CG7U7u tfo1iSPHsNQ2bK5PjT3oWbGmHNVvs4D0/yuX7D+LgG827xYoqmTTzO5aeorYIApeISOb6g3wlOj pGfRfa9tmuvXqN+14CToI54xgY3qIUx26qLL14DQqOMbRv26zoE+1KoX5nhg5WRe8fJ0= X-Gm-Gg: ATEYQzx35onO1+NW/BKdWmosGIll7h61a+xjfQWrpfUCmn5oy8zTPjoNotEb0WGrPuo 74KBzZYMDf+2/2c+5H2bh0S+AuWxqnIm4yX+c4MjouG+gdeQuq2tcFKF03jEMxYl9lDOEgP8BkW WwJ5jnO/E5yhXbaq2KCINBBRDLfhdFmSGG8v7AfxvLg0k9ltGNBAb9UfqoA+kK7bA6HJkjsygen ihQEQKchNY8PRvGqETVrcRsRnZtzU4g+dIa6Wpp45AlsK43SqzzEOt0KiEdU6yNtA/n6lMU8n6r qQs1bHAAquvglxbpaEj+6GABfCUGyrRDSxEJ5NaByUVZHifcBy6holWchnBE+rAFB9UV21C4Bkw gL9y0RbyZHjkhC7vzAUvbSx5t4MWSr/dVltNZYqmPKCFHn+5O5nfJeJCuqhf6ewiZjzjtl+ZLZo 359Cg= X-Received: by 2002:a05:622a:1992:b0:509:d76:fe73 with SMTP id d75a77b69052e-50b373d748amr144814901cf.3.1774268867884; Mon, 23 Mar 2026 05:27:47 -0700 (PDT) X-Received: by 2002:a05:622a:1992:b0:509:d76:fe73 with SMTP id d75a77b69052e-50b373d748amr144814541cf.3.1774268867450; Mon, 23 Mar 2026 05:27:47 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b983398c16esm487370966b.61.2026.03.23.05.27.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 05:27:46 -0700 (PDT) Message-ID: <632d2e2d-82c1-4e4f-b477-96c5e75767bd@oss.qualcomm.com> Date: Mon, 23 Mar 2026 13:27:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 02/11] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Kuldeep Singh , Krzysztof Kozlowski References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> <20260323-qcom_ice_power_and_clk_vote-v4-2-e36044bbdfe9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-2-e36044bbdfe9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA5NiBTYWx0ZWRfX9FaEg7Msgxn/ i51PgP4r553JFjBOZdIycP6DMnmbTegj5w9JHmWtSCNjbqSai83ndO6rCPRsunBZ1QS3Tg+nmaM uxSSr1O5/hQ56jGJdwJBavhHhJq8rOOTCcv8FsAKc2PfXe0iuVKEckXlkYipUJ74J3qKud3sIIA hVznjxQPkaXFAP+vSilgoYO9bcaTdMWqSyEMZ2RqIdb+MhHUG9rCaVzIeYiBR5U7UsI322UpfAN Vh4L0VwmesEC3vqzctXVgYAlWAMFHMpHR5P0hFYEXSIfQ2aTFuuhUFp0XrhnxOB3VCu+82IQqbK 5X8ug2f0PkcRVH0wrPTZT/isyafiG0vsAre6YGI48AVNLEGB78tmX7wjNMBzMoEqYqnroRnKgCP Em2d1ptVv4KO1oYMy+712Qowp1kABrIO4BkLaw8iQPKY6UWvc2pqAQJ+OTmgF1bt5LX3qpCOtIe l/d4wZfBEs+pqlPPnsA== X-Authority-Analysis: v=2.4 cv=bcdmkePB c=1 sm=1 tr=0 ts=69c131c5 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=SBCaeXWvHhY2KLIX7PwA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: peis_H6pyHL1VCUgeiHituoq28nw7t56 X-Proofpoint-GUID: peis_H6pyHL1VCUgeiHituoq28nw7t56 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_03,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230096 On 3/23/26 10:17 AM, Harshal Dev wrote: > Since Qualcomm inline-crypto engine (ICE) is now a dedicated driver > de-coupled from the QCOM UFS driver, it explicitly votes for its required > clocks during probe. For scenarios where the 'clk_ignore_unused' flag is > not passed on the kernel command line, to avoid potential unclocked ICE > hardware register access during probe the ICE driver should additionally > vote on the 'iface' clock. > Also update the suspend and resume callbacks to handle un-voting and voting > on the 'iface' clock. > > Fixes: 2afbf43a4aec6 ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver") > Signed-off-by: Harshal Dev > --- [...] > + if (!engine->core_clk) > + engine->core_clk = devm_clk_get_optional_enabled(dev, "core"); This change is a little sneaky given the commit message but I don't mind Reviewed-by: Konrad Dybcio Konrad