From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38AC43B38B1 for ; Wed, 10 Jun 2026 10:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781089190; cv=none; b=YdDWz8s2RHxJyq10m+we9+yQtbNAqtPL34SRFz5X8hsPO0whd5+xYovce1uLTEupDtUlvjXu09HSm/M1t/m31jEJd7/9R32DQ4mivtHJIX/01/2PDr6S2+jJjBj4DLn8wRH95jCjojFSyvmYjU0jnfEgaw2niPR3ukafcX4XTvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781089190; c=relaxed/simple; bh=QqkdOP1zhQ8kNAHcIw4gTfAacQ4D4WVk9zHFNJp0za8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XCmFIjb3+yQTMQ+ozf51YMf5ZdAPt8qRQuKX2uq0LyqFIGr5mZBiQJEUNJ2pRgc7pgg284JcyJ+ALgJnfr43YTo/dRqz0TqaDin9+8Wt6R4ea0R+yAMuy0r1VYLpYnSd4FVduZuHgJyiVaEQrX1Fnj0eV0PsyYbZXUBP+RlHY8Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-45ef616daf6so6101508f8f.3 for ; Wed, 10 Jun 2026 03:59:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781089188; x=1781693988; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pHtohPpXGahlOenhXvNIAGjZSypHtfodeQ5qiGu/QPA=; b=PMmhDdg+yG0/EpVr7fJzcgHyiH0z+h1M7OXPBauYY316Q81PpwbpDwGEz23ZwsuPJG 5yAky9oRpOZW6XcXKrVL4pJx8YZx1oLsEXE5cDUmK7vy6c1QsD/eMiOfijQPjP9JaDvA 6xZci0R11ZWSK9LeFWHXiWaeEaGwHRwuSOsod+dNXUihXgImurTb3Dcd9OJfjnQehNuX d+OinLVnbBsIAYKSCxmpjE6WeOM4HnUCVNnoIe667TUTOHU00N+M8UlTOWEHzqhjIDSf jKhL7U4CQjMpUwoYR04JgTpNhcc90mBMZGOioS4eVyU5Kfbqc2pwYt/Ohs70q7eNFUgn G5UA== X-Forwarded-Encrypted: i=1; AFNElJ9zzT91ZxWerlZI8D/EjH9bUP6NZLeVi+H4H+HRc0HhnHO1d5CJO2+9IXzK7bUgNgwZk+zvkZDAHGGtNfw=@vger.kernel.org X-Gm-Message-State: AOJu0YwvLJdQ1NhmnjzPF5cx0N4sivqvKJRW7HIgsMBikJUy6tnoJOZF inwq7MXiE+5+eOMO1PDx33VXOeM5aieJBIiz+RK52ii6SRSXRvqotLB1 X-Gm-Gg: Acq92OHCsrXDEQ6/TdCu6TTHL00jRYEVzEQ7sgH0X9YbPZU5jo7dqpkdOqKs1D68R4g ZTfAUXf/nbH5PPg4dhotPXdtQ/CqAmXdYHpE777Ru4dhjgf2Ltiq+ah2avTUlZXk5L0Dt19oG9o D+uPGfpTdl7Mell5alQrjDarPGc2pHykAdkXT2PAOEa/bVbexNiezwGTnCjJOjzBzMp9VKtJW0C wF9+tz5/fcE6GqfeSt68vqY+GBjri57uDAa62DAk77cWUzC78F4EMSoNugF3sc+g+Z/9fF3uUe2 g0UFtlF5gNiy9wxsijFUNNPd3IiBzc8kbm25t6w9jC+IntUt7O6NeoB9Dvt/4fmLuG/xkE5MbmX wrJrp6ZHZuR00wU7vkm/gGEfrpjLPBcJZ3sIDY6pmEfg18wpj+2wlT/L43nZNSC/lAlKdE2F7Jo swjgkrXIeUdO+OE/MgN7a7QqKxe/nlX6HPm184XO2X6F7jut+sv1gHrX5d/Us+minVR12/AAiDj v1WksUekzoq X-Received: by 2002:a5d:6644:0:b0:45e:f780:6181 with SMTP id ffacd0b85a97d-46030501958mr26460720f8f.23.1781089187489; Wed, 10 Jun 2026 03:59:47 -0700 (PDT) Received: from [10.68.32.41] (bba-217-164-201-253.alshamil.net.ae. [217.164.201.253]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46028a6dce6sm63499684f8f.30.2026.06.10.03.59.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 03:59:46 -0700 (PDT) Message-ID: <6330395a-15a5-43bd-a2fa-69fb24eef76e@linux.com> Date: Wed, 10 Jun 2026 14:59:44 +0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: efremov@linux.com Subject: Re: [PATCH v1] floppy: Drop unused pnp driver data To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <99dbf851ffb99229ea1dcfd8f58e9ee6a1f05349.1781075967.git.u.kleine-koenig@baylibre.com> Content-Language: en-US, ru-RU From: "Denis Efremov (Oracle)" In-Reply-To: <99dbf851ffb99229ea1dcfd8f58e9ee6a1f05349.1781075967.git.u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/06/2026 11:27, Uwe Kleine-König (The Capable Hub) wrote: > The pnp_device_id array is only used for module data to support > auto-loading the floppy module. So the .driver_data member is unused and > this assignment can be dropped. > > While touching that array, align the coding style to what is used most > for these. > > This patch doesn't modify the compiled array, only its representation > in source form benefits. The former was confirmed with x86 and arm64 > builds. > > Signed-off-by: Uwe Kleine-König (The Capable Hub) Reviewed-by: Denis Efremov (Oracle) > --- > Hello, > > I intend to change struct pnp_device_id and for that it's required that > .driver_data is not assigned using a list initializer. Instead of > converting it to a named initializer, drop the assignment as the value > is unused. So this is both a cleanup and a preparation for a later patch > series. > > See > https://lore.kernel.org/all/cover.1779878004.git.u.kleine-koenig@baylibre.com/ > for a more verbose description on the mentioned change to struct > pnp_device_id (though this is about platform_device_id, but the idea > here is the same). > > Best regards > Uwe > > drivers/block/floppy.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c > index 0509746f8aed..dca495be0683 100644 > --- a/drivers/block/floppy.c > +++ b/drivers/block/floppy.c > @@ -5012,8 +5012,8 @@ MODULE_LICENSE("GPL"); > > /* This doesn't actually get used other than for module information */ > static const struct pnp_device_id floppy_pnpids[] = { > - {"PNP0700", 0}, > - {} > + { .id = "PNP0700" }, > + { } > }; > > MODULE_DEVICE_TABLE(pnp, floppy_pnpids); > > base-commit: 49e02880ec0a8c378e811bc9d85da188d7c6204c