From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F6E5C433FE for ; Mon, 7 Nov 2022 09:07:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230434AbiKGJHD (ORCPT ); Mon, 7 Nov 2022 04:07:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231317AbiKGJG5 (ORCPT ); Mon, 7 Nov 2022 04:06:57 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 461DD120AD for ; Mon, 7 Nov 2022 01:06:56 -0800 (PST) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9AF786602253; Mon, 7 Nov 2022 09:06:53 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667812014; bh=LII2H+Y0rK9SUnBNSYFRD9K7i5ZCtRMMy7uIrtE0TUg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PUJmhsIqx5ppfwm/FnTucgZCGPenhimrZ76lVA9gAFeOYQ5GFqNrxQVIRQaEQoRHP 9Gw3CzJErSqcLH5nD/PF+lHE0owVpX0hTsyMPrXxlvK0BZ2NASiKGuyx4IzpTJd55X arfVJ43WIQFa7QwK9gHG93kk7+CZQx2+zuR1YtEl7ae03TgE5VhUM8mOkBliJufBbJ 0hj7f8PXq27VIooNONnMEGSebVhNThWeKTfg4gRnggSPFQkexuK+5d/B3FY563nY2Q Vo/EYkePlVh5CL9Sl/dbDhTDp+xIPsnriS9UxHXDUTcYn66szeE8QcyJaEq+NgdsWh iWJ4z+JUtYQxw== Message-ID: <63325548-63c6-8405-6481-3b019e7dd656@collabora.com> Date: Mon, 7 Nov 2022 10:06:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 1/2] ASoC: mediatek: mt8183-da7219: Register to module device table To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Mark Brown Cc: kernel@collabora.com, Akihiko Odaki , Jaroslav Kysela , Jiaxin Yu , Liam Girdwood , Matthias Brugger , Miaoqian Lin , Takashi Iwai , Tzung-Bi Shih , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20221104212409.603970-1-nfraprado@collabora.com> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: <20221104212409.603970-1-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 04/11/22 22:24, Nícolas F. R. A. Prado ha scritto: > Register the compatibles for this module on the module device table so > it can be automatically loaded when a matching device is found on the > system. > > Signed-off-by: Nícolas F. R. A. Prado > Hello Nícolas, I agree but.... can you please do the same for 8192, 8195, 8186? Getting them all in one series would make absolute sense... :-) in the meanwhile, for this one: Reviewed-by: AngeloGioacchino Del Regno > --- > > sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c b/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c > index 9f22d3939818..0e572fe28c58 100644 > --- a/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c > +++ b/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c > @@ -842,6 +842,7 @@ static const struct of_device_id mt8183_da7219_max98357_dt_match[] = { > }, > {} > }; > +MODULE_DEVICE_TABLE(of, mt8183_da7219_max98357_dt_match); > #endif > > static struct platform_driver mt8183_da7219_max98357_driver = {