From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
Leo Li <leoyang.li@nxp.com>
Subject: Re: [PATCH] i2c: imx: defer probing on dma channel request
Date: Wed, 16 Jan 2019 08:48:28 +0000 [thread overview]
Message-ID: <633db479-e1be-3b8b-45c4-06d1b651fe12@nxp.com> (raw)
In-Reply-To: <20190115215549.sepj7rmpqmtlxwbw@ninjato>
Hello,
On 15.01.2019 23:55, Wolfram Sang wrote:
> Hi,
>
> On Tue, Jan 15, 2019 at 04:03:32PM +0200, Laurentiu Tudor wrote:
>> If the dma controller is not yet probed, defer i2c probe.
>> The error path in probe was slightly modified (no functional change)
>> to avoid triggering this WARN_ON():
>> "cg-pll0-div1 already disabled
>> WARNING: CPU: 1 PID: 1 at drivers/clk/clk.c:828 clk_core_disable+0xa8/0xb0"
>>
>> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>
> I just applied this series to i2c/for-next:
>
> http://patchwork.ozlabs.org/project/linux-i2c/list/?series=85099&state=*
>
> I haven't checked carefully but maybe it fixes/changes your issue?
Not really as it doesn't seem to defer probing until the dma controller
gets probed.
> If not, your patch most likely will need a rebase on top of the above.
Will rebase on latest i2c tree and re-send.
---
Best Regards, Laurentiu
prev parent reply other threads:[~2019-01-16 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 14:03 Laurentiu Tudor
2019-01-15 21:55 ` Wolfram Sang
2019-01-16 8:48 ` Laurentiu Tudor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=633db479-e1be-3b8b-45c4-06d1b651fe12@nxp.com \
--to=laurentiu.tudor@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®