From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA9FBC4167B for ; Tue, 28 Nov 2023 08:36:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344137AbjK1Ig2 (ORCPT ); Tue, 28 Nov 2023 03:36:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230390AbjK1IgZ (ORCPT ); Tue, 28 Nov 2023 03:36:25 -0500 Received: from mail.3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2498CE1 for ; Tue, 28 Nov 2023 00:36:29 -0800 (PST) Received: from 3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 61F27957; Tue, 28 Nov 2023 09:36:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1701160587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v7glijZ94HivCAw9X2/CNGh4iPBKIx0lMfpD6J7YHzw=; b=Q/V8VItWQFtZyEEvwC+SczVu+gyUqbQLZLTIH+h0OZyxZHBkhVp67d2HATpAkpt7rYr3dO UmFtaAD/hD1sNEBZZqNQL2mmy8RJPWjAlUOrWc0mH4gjJmh+9j4T3ns6b4HasL4F9Ne5l9 vKzuW0qQg9V5PvpSMaQF9h+8O5C0An1dloKkPj6dzsshpGhrveILw0hMy7BAAyy2RjNrET GQXDfMz3KiyeFx+3RiJtpDX4XlShpdTXD74EkUaQUZCaBVOliIuEwNVX3AjwqxQW9j+C1B tEePae6WjARPrhqunE0QWTfR4FcdA4ZwKvkkTEti5LvXUusYK0jWYezSgR1smA== MIME-Version: 1.0 Date: Tue, 28 Nov 2023 09:36:27 +0100 From: Michael Walle To: "Boyapally, Srikanth" Cc: Pratyush Yadav , tudor.ambarus@linaro.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, "git (AMD-Xilinx)" Subject: Re: [PATCH] mtd: spi-nor: issi: Add support for is25lp02g In-Reply-To: References: <20231123054713.361101-1-srikanth.boyapally@amd.com> Message-ID: <6342ad8a798ef811d37775b7269623a3@walle.cc> X-Sender: michael@walle.cc Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, >> > Add support for issi is25lp02g. >> > >> > Verified on AMD-Xilinx versal platform and executed mtd_debug >> > read/write test. >> > >> > Signed-off-by: Srikanth Boyapally >> >> Based on a datasheet [0] I found online, this flash seems to have >> SFDP. >> And since you do not add any flash specific fixups, it likely does not >> need an entry >> and would work fine with the generic flash driver. Did you try using >> that? See [1] >> for more info on contribution guidelines. >> >> [0] https://www.issi.com/WW/pdf/25LP-WP02GG.pdf >> [1] https://lore.kernel.org/linux-mtd/20231123160721.64561-2- >> tudor.ambarus@linaro.org/ >> > I ran mtd_debug read/write tests on this flash, without adding flash > entry, it worked fine for me. Please ignore this patch. Great! Could you please still dump and post your SFDP just for us to have more SFDP of diferent flashes? See [1]. -michael