From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6A1B31ED66 for ; Thu, 22 Jan 2026 07:17:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769066252; cv=none; b=SrTuz1UM1j29btinhXAGmhqAsLi9K4hCoN479Tge8d4n3WvO/EMgqXMMvuRS67MOXC4+900gbAfk27Q6GsFoNbrJCXksk7HqBQJgIURTjhOywCml0Qo/gizzgMc8iULMPo1xI39yNw1p5iptJfDuBc0JXOR24ed4F/3cjVP+k/Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769066252; c=relaxed/simple; bh=taHNymwz1mC66lqVkhPHXPtNqMcJvWnU6px1Q3/rwMM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VzNQKLCWEGPduQnAU2wZiSiID4IXBIxZCl2xaWz2P2O0DmTRbCwgvCHutDHsmcil6K7GvHzPNoBFr3Ch0cmezC+z7VXDFO5koINr7jBxNCy0dRZ3ItHZBJvHgz81OhrUkiEBX84wrICKTTQDVOHI2+XesA/SYZmOXLjg5c/5SDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ZfSqqmLd; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ZfSqqmLd" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-430f3ef2d37so484194f8f.3 for ; Wed, 21 Jan 2026 23:17:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769066245; x=1769671045; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=UHTJ6KXNWoh0hdGrTW1lhA6H3qMn440dQudni+jBuvg=; b=ZfSqqmLdhBjUViRaP4LGSyRQOvTs5jKyoffTGqKc8mT6y0kyVPCRnY0ZaMXM1V+EfQ ADK1RXCz/mJ9epzk2egeTpuIZK1CohnxgJMmhlVJhsRVP1IuHG4F28hGY0aJKpitZgfg iS8PgvswSO5/EIi4ay4vFKTT5ml+saweccUDqgK9JsAaB9Mhg8nAqGMakARmxJMEk+sZ CI42HwpyNTaOB5TQW44PbHmGoXag11dCfnfz/D+yTwRJl/gbVjeFKBxTO0GuFvh2mMaK e+cNxnAz1SfZeYJK4l7tEnRIsz/WiEbMOuXwe4Zp+EKEdlblP+NyvzNkffYPw78OzlCZ H5aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769066245; x=1769671045; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UHTJ6KXNWoh0hdGrTW1lhA6H3qMn440dQudni+jBuvg=; b=smuXhk1jMO9VRD/LyZh0aT5i9vPcepyNRu9nGj5o3ycMp09FLI9MpBQJi8itfjNXdW 8nTsAivqNuK3uS5c/L/jYfXeGOH1t6pq9D1bgyRDC60vaPRBRlJFsyG6xxZSvl7Hcmgp 2/IAfQLXcCEsMzgUl2+2gOZUjJELSBn5do39kcOBSv6AQwQqxINzXJttry0B0kXasi94 oZNV105oesCy+htJkhw1/bq8xJEk8ltazcbPrsrpboTYt+Neibu7ecX2mXmUNdbaodvs 3ruidezOCF1XHarCLPDcaw3C12tn561Q2ii87B1y3445B3mJn5L+ksNB20CQFQTPbDBB yJMQ== X-Forwarded-Encrypted: i=1; AJvYcCV1nuoCza10Ip3kLJiokC2k9g/fhRPKTuwJBUXz+LN/27hM05wuC4K9fEO232ftjN1rDFeTFv3EyOfZ3JY=@vger.kernel.org X-Gm-Message-State: AOJu0YwsBm9A3vu8vGSMPeCGkVOdh+GmnyYufUHk50pzoxlhV/THMibC 6s+7TJnZ4Iz69ujvmfEVv9kZA+ES7J5idtjLRAvxE77CYdaGOgwgETBf8yHoSRQIwA== X-Gm-Gg: AZuq6aLjGbVV0UM0K8oM0vCMm+O3Ux+m6jCgtvxQ7siExKj6LV/j7nU1lOUORPVnvnx 6uxf/BEU0vnTFZUglyWa/CWWbgafVv0vIdBjbosBI9p2G7hFq66XiuQA1/+aUm8ZLcu0KmY+PuD aDj0YjjRHLbEC8hkvWgU+Yyrnipd7JlidTMzeAU9sIVvDhv23DzCR9osvJXd5ztFmTEZ6/AzmSo dQdNctIhK0QmbIT9UGBUvwYXhuEKrMXy++JIKDRta6QLCc/nFI78VgoZXGOJ1Bk2zwM8KpZKf63 +PFCFOP5atox+UiUgwv/fZgeFRiBHRA7t3M29/pU44MnwC8ZF9eHTzH+6pF7PU+HchT/B5HQwCN Cc5RIQi7BdoTt1SZFEgbVXPs3Rf/k8236ul3CilzxKljLQVnQeNQCAPVjgyGW5Ax2bC3AzpWsj1 vfSr61bzZY7t+1o8fD7r4LD4S2aGKyj1sIP9CMbcGuPjbxXIHIVTu03Lkv/buWBmHnt5oy8EmUg qc= X-Received: by 2002:a05:6000:402a:b0:42f:b581:c69a with SMTP id ffacd0b85a97d-4358ff1c1f1mr13520631f8f.5.1769066244781; Wed, 21 Jan 2026 23:17:24 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43569926ffcsm41143730f8f.18.2026.01.21.23.17.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jan 2026 23:17:24 -0800 (PST) Message-ID: <634471a1-1185-4644-aeea-7891e62bc1f0@suse.com> Date: Thu, 22 Jan 2026 08:17:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Partial revert "x86/xen: fix balloon target initialization for PVH dom0" To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, James Dingwall , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jason Andryuk References: <20260120140648.25977-1-roger.pau@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 21.01.2026 18:49, Roger Pau Monné wrote: > --- a/drivers/xen/balloon.c > +++ b/drivers/xen/balloon.c > @@ -724,7 +724,8 @@ static int __init balloon_add_regions(void) > static int __init balloon_init(void) > { > struct task_struct *task; > - unsigned long current_pages; > + unsigned long current_pages = 0; With this, ... > @@ -732,8 +733,13 @@ static int __init balloon_init(void) > > pr_info("Initialising balloon driver\n"); > > - current_pages = xen_pv_domain() ? min(xen_start_info->nr_pages, max_pfn) > - : get_num_physpages(); > + if (xen_initial_domain()) > + current_pages = HYPERVISOR_memory_op(XENMEM_current_reservation, > + &domid); > + if (current_pages <= 0) ... why <= ? Gives the impression you may mean to cover HYPERVISOR_memory_op() returning an error, yet that'll require a signed long variable then. Jan > + current_pages = > + xen_pv_domain() ? min(xen_start_info->nr_pages, max_pfn) > + : get_num_physpages(); > > if (xen_released_pages >= current_pages) { > WARN(1, "Released pages underflow current target"); >