mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux ACPI <linux-acpi@vger.kernel.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Linux PCI <linux-pci@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Lv Zheng <lv.zheng@intel.com>, Bob Moore <robert.moore@intel.com>
Subject: [PATCH 3/3] ACPI / scan: Enable GPEs before scanning the namespace
Date: Thu, 10 Aug 2017 00:34:23 +0200	[thread overview]
Message-ID: <6344941.kJ2o2XerZ0@aspire.rjw.lan> (raw)
In-Reply-To: <12346760.yAFCnkEgf6@aspire.rjw.lan>

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

On some systems the platform firmware expects GPEs to be enabled
before the enumeration of devices and if that expectation is not
met, the systems in question may not boot in some situations.

For this reason, change the initialization ordering of the ACPI
subsystem to make it enable GPEs before scanning the namespace
for the first time in order to enumerate devices.

Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Suggested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/scan.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Index: linux-pm/drivers/acpi/scan.c
===================================================================
--- linux-pm.orig/drivers/acpi/scan.c
+++ linux-pm/drivers/acpi/scan.c
@@ -2139,6 +2139,10 @@ int __init acpi_scan_init(void)
 			acpi_get_spcr_uart_addr();
 	}
 
+	acpi_gpe_apply_masked_gpes();
+	acpi_update_all_gpes();
+	acpi_ec_ecdt_start();
+
 	mutex_lock(&acpi_scan_lock);
 	/*
 	 * Enumerate devices in the ACPI namespace.
@@ -2163,10 +2167,6 @@ int __init acpi_scan_init(void)
 		}
 	}
 
-	acpi_gpe_apply_masked_gpes();
-	acpi_update_all_gpes();
-	acpi_ec_ecdt_start();
-
 	acpi_scan_initialized = true;
 
  out:

  parent reply	other threads:[~2017-08-09 22:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09 22:29 [PATCH 0/3] ACPI: Initialize GPEs before the initial namespace scan Rafael J. Wysocki
2017-08-09 22:30 ` [PATCH 1/3] ACPICA: Dispatch active GPEs at init time Rafael J. Wysocki
2017-08-10  1:48   ` Zheng, Lv
2017-08-10 16:06     ` Rafael J. Wysocki
2017-08-11  5:40       ` Zheng, Lv
2017-08-11 12:23         ` Rafael J. Wysocki
2017-08-15  9:59           ` Zheng, Lv
2017-08-15 12:21             ` Rafael J. Wysocki
2017-08-17  2:24               ` Zheng, Lv
2017-08-09 22:31 ` [PATCH 2/3] ACPICA: Make it possible to enable runtime GPEs earlier Rafael J. Wysocki
2017-08-10  1:52   ` Zheng, Lv
2017-08-10 16:07     ` Rafael J. Wysocki
2017-08-11  6:13       ` Zheng, Lv
2017-08-09 22:34 ` Rafael J. Wysocki [this message]
2017-08-10  1:54   ` [PATCH 3/3] ACPI / scan: Enable GPEs before scanning the namespace Zheng, Lv
2017-08-10  5:10   ` Lukas Wunner
2017-08-10  7:45     ` Zheng, Lv
2017-08-10  8:23     ` Mika Westerberg
2017-08-15  2:12   ` Zheng, Lv
2017-08-15 12:22     ` Rafael J. Wysocki
2017-08-17  2:25       ` Zheng, Lv
2017-08-10  9:34 ` [PATCH 0/3] ACPI: Initialize GPEs before the initial namespace scan Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6344941.kJ2o2XerZ0@aspire.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lv.zheng@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=robert.moore@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®