From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751393AbdHaAgp (ORCPT ); Wed, 30 Aug 2017 20:36:45 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35544 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbdHaAgo (ORCPT ); Wed, 30 Aug 2017 20:36:44 -0400 Subject: Re: [PATCH] irqchip: irq-bcm7120-l2: Use correct I/O accessors for irq_fwd_mask To: Marc Zyngier , linux-kernel@vger.kernel.org Cc: opendmb@gmail.com, bcm-kernel-feedback-list@broadcom.com, Kevin Cernekee , Thomas Gleixner , Jason Cooper , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" References: <1504032187-53035-1-git-send-email-f.fainelli@gmail.com> <2c52e192-9cb2-0e53-ddc2-23e25d1ae5bc@arm.com> From: Florian Fainelli Message-ID: <6344fffc-4125-a3b9-ce96-741f4d8becfb@gmail.com> Date: Wed, 30 Aug 2017 17:36:29 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <2c52e192-9cb2-0e53-ddc2-23e25d1ae5bc@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/30/2017 03:48 AM, Marc Zyngier wrote: > On 29/08/17 19:43, Florian Fainelli wrote: >> Initialization of irq_fwd_mask was done using __raw_readl() which >> happens to work for all cases except when using ARM BE8 which requires >> readl() (with the proper swapping). Move the initialization of the > > s/readl/writel/, I presume? Correct, just submitted a v2 with that fixed, thanks. -- Florian