Re: 回复: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board

[Krzysztof Kozlowski <krzk@kernel.org>]

On 05/01/2026 09:49, Gary Yang wrote:
> Hi Krzysztof:
> 
> Thanks for your comments
> 
>> EXTERNAL EMAIL
>>
>> On Sun, Jan 04, 2026 at 03:53:59PM +0800, Gary Yang wrote:
>>> OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit
>>> processor + NPU processor,integrated graphics processor, equipped with
>>> 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for
>>> NVMe SSD,as well as SPI FLASH and TF slots to meet the needs of fast
>>> read/write and high-capacity storage
>>>
>>> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
>>> ---
>>>  Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
>>>  1 file changed, 9 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/cix.yaml
>>> b/Documentation/devicetree/bindings/arm/cix.yaml
>>> index 114dab4bc4d2..9e132e609b7b 100644
>>> --- a/Documentation/devicetree/bindings/arm/cix.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/cix.yaml
>>> @@ -16,9 +16,16 @@ properties:
>>>    compatible:
>>>      oneOf:
>>>
>>> -      - description: Radxa Orion O6
>>> +      - description: Radxa Orion O6 board
>>>          items:
>>> -          - const: radxa,orion-o6
>>> +          - enum:
>>> +              - radxa,orion-o6
>>> +          - const: cix,sky1
>>> +
>>> +      - description: Xunlong orangepi 6 plus board
>>> +        items:
>>> +          - enum:
>>> +              - xunlong,orangepi-6-plus
>>
>> Previous patch was correct, not this one.
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
>> of patchset, under or above your Signed-off-by tag, unless patch changed
>> significantly (e.g. new properties added to the DT bindings). Tag is "received",
>> when provided in a message replied to you on the mailing list. Tools like b4 can
>> help here. However, there's no need to repost patches *only* to add the tags.
>> The upstream maintainer will do that for tags received on the version they
>> apply.
>>
>> Please read:
>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/sub
>> mitting-patches.rst#L577
>>
>> If a tag was not added on purpose, please state why and what changed.
>> </form letter>
>>
>> Read last sentence and linked documentation. Where did you explain
>> ignoring/dropping my tag?
>>
> 
> Yes, the previous version was acked by you before.

I stressed what I expect twice. In form letter and later explicitly. You
still ignored it.

> 
> When apply it, we found that orangepi 6 plus and Radxa Orion O6 belongs the different boards.
> 
> So we need to add a new item for it. Like these from qcom.yaml
> 
>       - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform
>         items:
>           - enum:
>               - qcom,qdu1000-idp
>               - qcom,qdu1000-x100
>           - const: qcom,qdu1000
> 
>       - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform
>         items:
>           - enum:
>               - qcom,qru1000-idp
>           - const: qcom,qru1000

No, look at SoCs. Different SocS.


Best regards,
Krzysztof