From: Rik van Riel <riel@surriel.com>
To: Alejandro Colomar <alx@kernel.org>
Cc: linux-man@vger.kernel.org, kernel-team@meta.com,
LKML <linux-kernel@vger.kernel.org>,
Eric Biederman <ebiederm@xmission.com>,
Matthew House <mattlloydhouse@gmail.com>
Subject: Re: [PATCH v2] execve.2: execve also returns E2BIG if a string is too long
Date: Wed, 11 Oct 2023 12:43:38 -0400 [thread overview]
Message-ID: <6347cb90238ce61fb21a8203da53497663cee60a.camel@surriel.com> (raw)
In-Reply-To: <ZSbD59Y5y3zNGC1h@debian>
On Wed, 2023-10-11 at 17:48 +0200, Alejandro Colomar wrote:
> Hi Rik,
>
> On Wed, Oct 11, 2023 at 10:11:34AM -0400, Rik van Riel wrote:
> > The execve syscall returns -E2BIG in 3 cases:
> > - The total length of the command line arguments and environment is
> > too large.
> > - An argument or environment string is longer than MAX_ARG_STRLEN.
>
> Please mention that this includes the terminating NUL, as Matthew
> confirmed. Otherwise, to user-space programmers, this would usually
> be
> interpreted as `strlen(p) > MAX_ARG_STRLEN`.
>
> An example program that demonstrates the limit would be very
> interesting
> here.
Thank you for the detailed review.
I think all the comments are addressed in version 3.
--
All Rights Reversed.
prev parent reply other threads:[~2023-10-11 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 14:11 Rik van Riel
2023-10-11 14:46 ` Alejandro Colomar
2023-10-11 15:48 ` Alejandro Colomar
2023-10-11 16:43 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6347cb90238ce61fb21a8203da53497663cee60a.camel@surriel.com \
--to=riel@surriel.com \
--cc=alx@kernel.org \
--cc=ebiederm@xmission.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mattlloydhouse@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®