From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A109EC76196 for ; Thu, 18 Jul 2019 16:22:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78E9C21851 for ; Thu, 18 Jul 2019 16:22:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=st.com header.i=@st.com header.b="G1wdX6NO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732208AbfGRQWD (ORCPT ); Thu, 18 Jul 2019 12:22:03 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:22634 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727762AbfGRQWD (ORCPT ); Thu, 18 Jul 2019 12:22:03 -0400 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6IGLNUQ000649; Thu, 18 Jul 2019 18:21:50 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=AJq7HWOmdf4Eh8zS82EF7sEz8rhFjyGqo/y3JZirMqI=; b=G1wdX6NO76pAIFagRCQrnHZbuzJMOAUmmpauADX9rWCew3aFMlqZ2oMHn019kBT1aRQy BK6bBd0BmcT9DORQXdXCqM74mSKNunuyJyJXLXaE9tnZei3TcQhf/76oDx2BXNFht5Vv tjk2f5mkOZjz+Y1xA9adly3Nxx4G6jRdkWQzHA5fEfr9hn5+vcUcaeZ+7L6Tb5OxINCa M3+2DJSCQe/1xp54dsy3D1Fhh+J/7AfKm83XCRLLZVvaETiZVRhGX/LWytUHHfbo6p7E GpgAIGOpS+PQyJSCUz6gcvg+LQr+do8Li/dRM8blgU/fJ5NzZdP3ow1EDNNhSU+F9P41 fA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2tsdeppr0w-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 18 Jul 2019 18:21:50 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id BB8D734; Thu, 18 Jul 2019 16:21:49 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag3node2.st.com [10.75.127.8]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 98AC85344; Thu, 18 Jul 2019 16:21:49 +0000 (GMT) Received: from lmecxl0912.lme.st.com (10.75.127.49) by SFHDAG3NODE2.st.com (10.75.127.8) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 18 Jul 2019 18:21:48 +0200 Subject: Re: [PATCH] dt-bindings: pinctrl: stm32: Fix missing 'clocks' property in examples To: Rob Herring , Linus Walleij CC: , , , Maxime Coquelin , , References: <20190716215618.29757-1-robh@kernel.org> From: Alexandre Torgue Message-ID: <634fce00-182d-80b8-b435-0cbdae57913c@st.com> Date: Thu, 18 Jul 2019 18:21:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190716215618.29757-1-robh@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG4NODE1.st.com (10.75.127.10) To SFHDAG3NODE2.st.com (10.75.127.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-18_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob On 7/16/19 11:56 PM, Rob Herring wrote: > Now that examples are validated against the DT schema, an error with > required 'clocks' property missing is exposed: > > Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \ > pinctrl@40020000: gpio@0: 'clocks' is a required property > Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \ > pinctrl@50020000: gpio@1000: 'clocks' is a required property > Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \ > pinctrl@50020000: gpio@2000: 'clocks' is a required property > > Add the missing 'clocks' properties to the examples to fix the errors. > > Fixes: 2c9239c125f0 ("dt-bindings: pinctrl: Convert stm32 pinctrl bindings to json-schema") > Cc: Linus Walleij > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: linux-gpio@vger.kernel.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Signed-off-by: Rob Herring Acked-by: Alexandre TORGUE Thanks Alex > --- > .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml > index 3ac5d2088e49..91d3e78b3395 100644 > --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml > @@ -197,6 +197,7 @@ required: > examples: > - | > #include > + #include > //Example 1 > pinctrl@40020000 { > #address-cells = <1>; > @@ -210,6 +211,7 @@ examples: > #gpio-cells = <2>; > reg = <0x0 0x400>; > resets = <&reset_ahb1 0>; > + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOA)>; > st,bank-name = "GPIOA"; > }; > }; > @@ -227,6 +229,7 @@ examples: > #gpio-cells = <2>; > reg = <0x1000 0x400>; > resets = <&reset_ahb1 0>; > + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOB)>; > st,bank-name = "GPIOB"; > gpio-ranges = <&pinctrl 0 0 16>; > }; > @@ -236,6 +239,7 @@ examples: > #gpio-cells = <2>; > reg = <0x2000 0x400>; > resets = <&reset_ahb1 0>; > + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOC)>; > st,bank-name = "GPIOC"; > ngpios = <5>; > gpio-ranges = <&pinctrl 0 16 3>, >