From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DE75135A5D; Thu, 25 Jan 2024 20:12:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706213527; cv=none; b=pPd4lIBlbL4z/P+qcX0GyRzKA/kdfUNdriQteEQx0qoOwqW0fZIKrnT1JDT0D3aUedUaxkFjS0Ij+n8Pkx919hxO5hyyi3FR0z182g3hk4PxEWfC08eoi9VhAeLGWTeXf4JqEDo0vmdHiaBzruE35vCbDPbsHTOWGmCl03YHlmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706213527; c=relaxed/simple; bh=27T1NLakmj/1AjMRk4+ROq1pwjUNd9JBGAB/g87CZHA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BjTLw2B2iqkJXwoVEphlQ6bAqe4WPFzc+t+gbxbgrcm2ZWyPbB5mtc0ajwt41XUc2+nSPaTX8IjDW0xrs+7H6yfrxZ4SzQ0618GZqqYIc2b7AfQNJXKbP2/UTBxNoO1UdSItRDhbqSzpbkaHUrclSsZ4RfYrWZZdsqDmcOXjJE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=qR5345bb; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="qR5345bb" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Tz53wyPc4pe7G+zHxuZ+8kfW0OKtKOOeDrNRA5aAh9A=; b=qR5345bbvV3FW3dFU60qy6qAtU w9Fi8jlp17mR78eUdVfv7ptyiU5xkkV7QdVDaGii0+VhpfUEZgERbU59ShuajSe2EQYxRvk43QdlL X1KurnZRnC+vzAF0tagW5AdIxZirEUyc4egP/lBzY7mgIX8GAmWeRg3tbQ8fnvbXz9Cw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rT64t-0067PO-3X; Thu, 25 Jan 2024 21:11:59 +0100 Date: Thu, 25 Jan 2024 21:11:59 +0100 From: Andrew Lunn To: Kathiravan Thirumoorthy Cc: Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 4/8] clk: qcom: ipq5332: add gpll0_out_aux clock Message-ID: <635f5e41-1ca2-4b4e-86a5-fdb8f7b27ef9@lunn.ch> References: <20240122-ipq5332-nsscc-v4-0-19fa30019770@quicinc.com> <20240122-ipq5332-nsscc-v4-4-19fa30019770@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240122-ipq5332-nsscc-v4-4-19fa30019770@quicinc.com> On Mon, Jan 22, 2024 at 11:27:00AM +0530, Kathiravan Thirumoorthy wrote: > Add support for gpll0_out_aux clock which acts as the parent for > certain networking subsystem (NSS) clocks. This answers the question i asked for the previous patch. Why did you split this into two patches? Please also give a more detailed description, rather than the vague 'certain networking subsystem (NSS) clocks' If you device tree and drivers are correct, i should be able to work out what the clock tree looks like, so there is no point trying to hide the information. Andrew