From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E183D23D7CE for ; Fri, 10 Jul 2026 13:50:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783691448; cv=none; b=s/akjPnvcr8z8/cfzrHr4JAHXHduqY6BTxhznfVo6rG5n6aI30+4NtvaxvqoSiamuPWwLiwsnLDkyLqj2joMZjJfFbJF9UGXRBzj3W/qGrwlof6GqOZYYcY3PYbVtEyMMJsIgtxkHzmq3GOOjKaCPhDel6kvRQbJ5WWLbrWF++o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783691448; c=relaxed/simple; bh=xH1xh39y8K/9voN/rwyDLcQiZ84Qo7t4SMNVdhnEKJg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HenNxyBeO28bVk0gMuW2XYLwqZtmjYu+3jKieMnSN6xTKotZLQFFuzeSmvyjfqBLBiGd778iDxGY0dydrb2YwDIY8Gc0CSAr7q6TJo6dX7jnSpmrPobCj9Sus48yy5SIc1w/8s8pgj17ELQWOimzmy8gggV3WWq5VN7RO+PVOH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TMh3ys41; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Fr5xezbj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TMh3ys41"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Fr5xezbj" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66AD6ZiR700709 for ; Fri, 10 Jul 2026 13:50:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6AIQxvcRx21RioxQhZDbiYJ1VNsBCw2h40lSC03Og18=; b=TMh3ys41KU3gbhm/ vr+T7ySZQJvD7YOYzs+Bb5Sz9GUZPEo6JmxpQc09aLvo0+qi/kg6wgGHizmkStZM W6e7R2Mw7Vkd459x9ll99zW1qxDLZu3sXYRPJXV7XBz/uvMQ3nnZBRmS0D+e+I2u Mi72rS3Psl4VGTAC7/Qvpv6/J5B974DSuVlxrejFr2uvVc89wKUq+sbDkmYJTAqW iTxwITLqCQFRbmIhUgK9l1eGyQnH4Z3l9KGCpX4ZM5fzGDxQmekXg3nw6iNOSDL7 rB/risaTQu8Tsq3e0KRAwqlKCEhFWeE42QrRk+REEL8aKlUxjYnV0/RuWIkISFyK GI5PwA== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fahv8kk58-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 13:50:46 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-737ddaf8c57so26252137.0 for ; Fri, 10 Jul 2026 06:50:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783691445; x=1784296245; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6AIQxvcRx21RioxQhZDbiYJ1VNsBCw2h40lSC03Og18=; b=Fr5xezbjSQDRuyBXSRyaRfbhp/Uq22KrkWLYgxyFcg6SXCNlufhyL55YrLcEln40EE HyHXKph4n0NJpvuvoBQ26LrYu0PT4eOn6prFxDRFNyNPM+0BOtJnMpur6PD3BIkdLLTk TqOFJslpGJkNqAz/sIeEn6qoiFtF18TxzPHjk5Bg5xdd5PDRGHlC34lSu0Eu9MV7yR/I X/MX4tuiBvu+zCzVnb3JbfwuEyuE9F42sq2Z6Y7lFL8BKHE/NJVGjLhGkaT1xM7WdyO5 pc9aV8SpbbJRAwzsO6Y+KftirdYjXGCHUblvyDiz1o1x+TsuI/3AAKlge/Io/2XlhXiQ hx5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783691445; x=1784296245; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6AIQxvcRx21RioxQhZDbiYJ1VNsBCw2h40lSC03Og18=; b=lKkwJCzwI/IqpXrR5RzVThDDgaUxG9U7L3sjGR1X5ppb93zPZAJOnl2/lQDIwdmzrs 58IHCniL6kZpMH+xxfBvYImIGINylzhH1c+f0shycvWsoBiY/KKquTnbNk4QUmEomhVL LC8nFBf1enH/qq7shBFh8i2U1x4iI5bmLvoXnnPtIgZDViIiFRd7syK3/AFe//HvaNvj lUSN5NpPReyE17bj12Q8AMevszwBzxKABApj1tvZi06KAEK3FDsUvws7++AhqeYP23xp rpM/PeVZ6QaxXMlql2x3Qv0mvbv0Bg2eT694WcVA8+H95lPTa5P6LpuAHilbI2Y+Y1gw vHyQ== X-Forwarded-Encrypted: i=1; AHgh+RpUFbLYEcG0iWcOCnoLKBo+/twOjR3XpVj4xabuj99C9WPUXazy6lZzV9y9B0xWSKg/NYf3vegjcW7RBUk=@vger.kernel.org X-Gm-Message-State: AOJu0YxAmkgB7BJ/9ShF8u553bIJHFjIjpUm8pb+1vE/nUC8XR6okWUy KtxrX1b+S/bmzVX1Y2vIevKxEAa7yxmXXX3d+YGg/UjUXsJUBj7KR+OEXBKTTsQaIeo5KLwdmes b7LQx/hAF8E6ECpDpvOx44IjR9Wlz+Bqdf91LEDLkcVm5ioltQUUKVXhAt385akI3ZDc= X-Gm-Gg: AfdE7cnOx2wuemyITKMcED122Y4iYbLnLckkz/6YcQG5GYwrwkWJKSbW0WOne+LnRRK XzFDejerQ5LH62a8kZNTZL3eyzVJD3kuqiZgxjA0J+ZNClEmEfIdASe91bMABEbrHBSiURRg2gC 8Xsxf8jwSe71CovD75FNO2wkcpuWODk1ahXr9O7f54QNTZ3STdd8wPb03KUZ/cttVBuMIGe5KTG YFGmEKZqrdbRy9prLzQ5GhPhStt2FLH7S0zobCV2CqDHKNzUBkMS2g1/q34IGNBgEoFZQ4BtJGz 2C4c6+Q9IdDMPDqyJU31THYrYxJEvPHf1aF+GtJ3rAxOWV8h+7Gho847jlah0o+RCFGVgDYSNX6 w3cYfVjSqunrJwPdGDpWLnVWhHS/+5Jb7vcE= X-Received: by 2002:a05:6102:a4f:b0:73a:322d:1bb3 with SMTP id ada2fe7eead31-744f0ab5277mr2225547137.3.1783691445232; Fri, 10 Jul 2026 06:50:45 -0700 (PDT) X-Received: by 2002:a05:6102:a4f:b0:73a:322d:1bb3 with SMTP id ada2fe7eead31-744f0ab5277mr2225535137.3.1783691444637; Fri, 10 Jul 2026 06:50:44 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b01ca54e25sm615052e87.30.2026.07.10.06.50.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 06:50:43 -0700 (PDT) Message-ID: <63643fc3-3a3b-4aef-96b4-de42498cf47b@oss.qualcomm.com> Date: Fri, 10 Jul 2026 15:50:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] arm64: dts: qcom: hamoa-iot-evk: Describe the PCIe M.2 Key E connector To: Wei Deng , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, mengshi.wu@oss.qualcomm.com References: <20260709-fix-hamoa-m2-w-disable2-v1-0-5e725091266a@oss.qualcomm.com> <20260709-fix-hamoa-m2-w-disable2-v1-1-5e725091266a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260709-fix-hamoa-m2-w-disable2-v1-1-5e725091266a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: g6oIjqMYxxUeS-vDdy0D1dKT1OdSVdpp X-Proofpoint-ORIG-GUID: g6oIjqMYxxUeS-vDdy0D1dKT1OdSVdpp X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDEzNyBTYWx0ZWRfX4SLOkOXpEBmY ay2/qr9NZPovDPxJY3aqz4y7J+DwNsWgutI6hgAnspc6T6dFPnJfqPLZmTzNClo6YSUwZs0OwOJ er+Uj7+i7zp7gsPhf/Kl5I9PXuo3L+o= X-Authority-Analysis: v=2.4 cv=funsol4f c=1 sm=1 tr=0 ts=6a50f8b6 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=MVNNC7U5w37-LmZrIMoA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDEzNyBTYWx0ZWRfX9peM3t7HKkFb lGopl49hYdaj0W3Fx7TDJSCfDOEeiLbGW2FvNJJR76TC9imtWyohDOFYljUf19rVTY8YRTVp8Rv CYFrHV9ST+DZl6FOq4F9+nPaNyV8aKmOcgDAJqqTiHkwcS9ezf7dT9ywmX9sVxmVZUXIRrHIDzz WxQDKYrKjSbOetIT3Uam7QqxoX0StMMOAACR9bm2xRFkK5TCe+kKUsUBDyMUYVsK02y4xY9aYKG oJskmq55xwvLiqU+Wjoz5nKDulGZ0LD/Y1MiypCfn7VnGtp3APj8tVHDb96ol9CWwYqmBy6gLGJ ASbz2W2CLmrwv/w8vprlL5HfkJxIkwK1v/bXj816klxzDLkncwG5DbPASo6+1CysY48l3fBBT9T +hEykIG61jQT1dnDtYyFJlzC9GfE6Quzyw/7dIXiENQZIvS1TxfaFFGQ7uorj1tGGFyDLCddR7D eW7zHYsmKz6A8qQdhNw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_03,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100137 On 7/9/26 9:29 AM, Wei Deng wrote: > The hamoa IoT EVK has the PCIe M.2 Mechanical Key E connector to > connect wireless connectivity cards over PCIe and UART interfaces. > Hence, describe the connector node, link it with the PCIe 4 Root Port > node and replace the static BT serdev under UART14 and the > chip-specific wifi@0 child node with graph port/endpoints, allowing > the pwrseq-pcie-m2 driver to power the card and dynamically create > the BT serdev device. > > The M.2 Key E connector is powered by vreg_wcn_3p3. WLAN enable is > controlled via W_DISABLE1# (GPIO117) and BT enable via W_DISABLE2# > (GPIO116), both described as active-low GPIOs on the connector node. > > Remove the chip-specific wcn7850-pmu node as the M.2 connector > approach replaces the WCN7850-specific power sequencing with a > chip-agnostic one managed by the pwrseq-pcie-m2 driver. > > Also add 'compatible = "pciclass,0604"' to pcie4_port0 in hamoa.dtsi > to allow the PCI subsystem to associate the DT node with the > PCI-to-PCI bridge device. > > Signed-off-by: Wei Deng > --- [...] > @@ -1025,19 +1004,10 @@ &pcie4_port0 { > reset-gpios = <&tlmm 146 GPIO_ACTIVE_LOW>; > wake-gpios = <&tlmm 148 GPIO_ACTIVE_LOW>; > > - wifi@0 { > - compatible = "pci17cb,1107"; > - reg = <0x10000 0x0 0x0 0x0 0x0>; > - > - vddaon-supply = <&vreg_pmu_aon_0p59>; > - vddwlcx-supply = <&vreg_pmu_wlcx_0p8>; > - vddwlmx-supply = <&vreg_pmu_wlmx_0p85>; > - vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; > - vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>; > - vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>; > - vddrfa1p8-supply = <&vreg_pmu_rfa_1p8>; > - vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>; > - vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>; > + port { > + pcie4port0_ep: endpoint { "pcie4_port0_ep", please Reviewed-by: Konrad Dybcio Konrad