From: Arnd Bergmann <arnd@arndb.de>
To: Geliang Tang <geliangtang@163.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH 2/2] efirtc: add efi_enabled check in efi_rtc_init
Date: Mon, 02 Nov 2015 16:37:51 +0100 [thread overview]
Message-ID: <6366386.xsGhxxeFtE@wuerfel> (raw)
In-Reply-To: <280fb52bda85af452e129fa5633598954801871c.1446475492.git.geliangtang@163.com>
On Monday 02 November 2015 22:49:01 Geliang Tang wrote:
> diff --git a/drivers/char/efirtc.c b/drivers/char/efirtc.c
> index 5323d8c..80058bd 100644
> --- a/drivers/char/efirtc.c
> +++ b/drivers/char/efirtc.c
> @@ -378,6 +378,9 @@ efi_rtc_init(void)
> int ret;
> struct proc_dir_entry *dir;
>
> + if (!efi_enabled(EFI_RUNTIME_SERVICES))
> + return 0;
>
Are there any Itanium machines that don't enable runtime services?
This seems a little redundant otherwise.
Are you trying to run the ancient driver on non-Itanium systems?
Arnd
next prev parent reply other threads:[~2015-11-02 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 14:49 [PATCH 1/2] efirtc: replace 1998 with EFI_RTC_EPOCH Geliang Tang
2015-11-02 14:49 ` [PATCH 2/2] efirtc: add efi_enabled check in efi_rtc_init Geliang Tang
2015-11-02 15:37 ` Arnd Bergmann [this message]
2015-11-04 14:45 ` Geliang Tang
2015-11-04 14:51 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6366386.xsGhxxeFtE@wuerfel \
--to=arnd@arndb.de \
--cc=fenghua.yu@intel.com \
--cc=geliangtang@163.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®