From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752905AbcFCWmM (ORCPT ); Fri, 3 Jun 2016 18:42:12 -0400 Received: from linuxhacker.ru ([217.76.32.60]:39218 "EHLO fiona.linuxhacker.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbcFCWmL convert rfc822-to-8bit (ORCPT ); Fri, 3 Jun 2016 18:42:11 -0400 Subject: Re: Dcache oops Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Oleg Drokin In-Reply-To: Date: Fri, 3 Jun 2016 18:42:04 -0400 Cc: Al Viro , " Mailing List" , "" Content-Transfer-Encoding: 8BIT Message-Id: <636C03D2-68A4-41A3-9B58-6457D984EE64@linuxhacker.ru> References: <20160603033750.GL14480@ZenIV.linux.org.uk> <0C971585-6BFC-4665-832B-9B262F733BFC@linuxhacker.ru> <20160603042648.GN14480@ZenIV.linux.org.uk> <74306F63-DBDF-4DED-85D2-5C3FB21B8A1E@linuxhacker.ru> <20160603182203.GR14480@ZenIV.linux.org.uk> <4285E00F-7228-485C-AD32-97552ED746F2@linuxhacker.ru> <20160603200759.GS14480@ZenIV.linux.org.uk> <20160603212652.GT14480@ZenIV.linux.org.uk> <20160603222355.GW14480@ZenIV.linux.org.uk> To: Linus Torvalds X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jun 3, 2016, at 6:36 PM, Linus Torvalds wrote: > On Fri, Jun 3, 2016 at 3:23 PM, Al Viro wrote: >> On Fri, Jun 03, 2016 at 03:00:02PM -0700, Linus Torvalds wrote: >>>> >>> Normally it's done at terminate_walk() time. But I note that in >>> walk_component(), we do put_link(nd) which does a do_delayed_call(), >>> but does *not* do a clear_delayed_call(), so now I think a subsequent >>> terminate_walk() might drop it *again*. >> >> Nope - put_link() also decrements nd->depth. No double calls there... > > Yeah, I figured that out, and then continued to try to look at other cases.. > > Happy to hear that you seem to have figured it out. > > But why did it apparently only start happening now? Apparently nobody runs NFS in a serious manner these days anymore. EOPENSTALE is only used by NFS.