From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934073AbdJXNSL (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Oct 2017 09:18:11 -0400
Received: from mout.web.de ([212.227.17.11]:52190 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933565AbdJXNSH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Oct 2017 09:18:07 -0400
Subject: Re: drm/i915/gvt: Use common error handling code in
 shadow_workload_ring_buffer()
To: Jani Nikula <jani.nikula@linux.intel.com>,
        dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
        intel-gvt-dev@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>, Zhi Wang <zhi.a.wang@intel.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <f563de94-afaa-ecde-2907-d6baaad65939@users.sourceforge.net>
 <87efpsiu7r.fsf@intel.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <636f6272-9074-53dc-2c90-cbb4a7cd0901@users.sourceforge.net>
Date: Tue, 24 Oct 2017 15:17:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <87efpsiu7r.fsf@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:8XKRy1JQ3aJyi+/CSfwmIBvm6NOiq/+O70IcNVvTALntO3hReqH
 tT/MXh6zKQdAA2XgOyxs7z3QTn6ibcLNkhB/djTLnlt4FyA0Jf+kmA6CSPvvqLfZCsxm/mB
 CI6Pju1n03StUGm6FUwZ+w9JOZARlZkJjyV1TYu80gsXdRhcIammaENGj8DbZO0nsIfjCIr
 Ev5nuuClDvJwP1049QHDQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:uKteULBI/RE=:Fm9ZM7s6BR+LhQpsS7BeWZ
 t8hZoMvptqOqH6lK3a2B2brlyBAOBgiiTN+1QiNEQT48/VBpi5MOxgqTpuNFYE345jo0S+gXk
 +1BxuEhiwDqX3xo3XKi4EOcQY+twq3nAdqrkTe3BZn/SyZJsRxam0HzZPE2d8cdfVnh5g1tDO
 h2wMCQKSYdLP3qq1uuaibXE/03JN5mMdFojRCdg9RSerJUmFF1I7bi9FY1FW4Dj2XBKb6eCsv
 0sxEnbFriZZyrw2CatKV2Co1Uo623nFpgAYorPx0fDvyHNCe0vIHWrcbhFlB9UlGNUghBJetA
 pYMz5F/vZCg3nVvkzGH6bWrHDE3B7XBDgd7flBTG1+D3By8XQ0hJlcIuFjl2L0IzrlcXty+ss
 mugzYK/qeh477lvBG3brqUP3usN0nQYswt+7y0zzgw3wX6U7C7qBNlFet4IAfMfJ9odOBXaaH
 SqlrszG/Ja02WFITEIRR3MnkIWCfMN/oMraZo5lChNAlUQqHIn4RnsDFkqZGHNHbeVOazAqFf
 7nGZhwl5Mt8vsp7NpbwqGKwjccppxRh8bhGybs6wZAAIhU0ycvScICPgNOLRvdmzte1dLPQYi
 MhFKFUFuDDF1yMD9Y4OmZU4YzZfYmJ5Kt+26W0DataPsmP3es/svZ7YG+iew0xn5ZQSZOgDFi
 fJXmVuTzbUrx1BMrDzRgC0RxN9M2xhBXwVEeaBkXBy/NqB2R1iHEv0qWEJmmwZflSVeTA+QWQ
 QAi+r13jDph3nsHCJTC0psqItbHxVC2J38KnanHeregRh7AGO7Czq1VM+tmFlXGQMw7MsT8EM
 Z/L2LLzzHzVszUrLLdYM7Ek96P86jDimzO/AGWsINOMAVBMNeQ=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Add a jump target so that a call of the function "gvt_vgpu_err" is stored
>> only once at the end of this function implementation.
>> Replace two calls by goto statements.
>>
>> This issue was detected by using the Coccinelle software.
> 
> I don't think this is an issue or an improvement.

Do you care for the detail how often an error message is stored in the code?

Regards,
Markus