From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E82EC433E1 for ; Sat, 1 Aug 2020 17:02:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04A1320725 for ; Sat, 1 Aug 2020 17:02:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="xoGV0gXl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727893AbgHARC0 (ORCPT ); Sat, 1 Aug 2020 13:02:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727074AbgHARC0 (ORCPT ); Sat, 1 Aug 2020 13:02:26 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80220C061756 for ; Sat, 1 Aug 2020 10:02:26 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id g19so6201523plq.0 for ; Sat, 01 Aug 2020 10:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=gVjl1fxVk2phmm6E3dsUk+Vd8Kon2yS4EGOlu+DC8qA=; b=xoGV0gXlv0W7TosbAf87l0OGfBJMV7uZa+lmmZpczEuAWDna/mwq+dGD1Luj2HWsJ/ r/incAFP942ignqie8l3t+1D25tkhIb5d8rFNgEN6UNwCqrmCPk2BWTkRgJemUPcgXEH nrblQmguOw6tZ+0cylPpmFuh86sYQs665GcdjWO8/ZFXRC12pBkfvgvr505huIp73Qfb LUMQBKgXDJPzOxETWdHmlpBqvlcxtWWZhGNNzt2O088uGtZvrCDOdxKqJUQSrLVV6lcC /Od5XWQ+3r6czO9wjniVOXkVvjokqhpdjgCIxEHme4ozSQqQ/DHQrQL9NoyYHPFRV5dz 8JPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gVjl1fxVk2phmm6E3dsUk+Vd8Kon2yS4EGOlu+DC8qA=; b=ph14/kkGmqoqGKHKcwLJnPSr8h/DR8NiybKEfs6t/pcWEcl24djU0bFF4ce5UVyuaP nTokq6u1mZeuij6eHXR7Jnq3FVmXDm86ZKz0H3hkMbBgF4IG1B+ryPay9PBWLCXuWJFl YPOCGy1VM7V6ssT5OY9rie43t8mY2IkjCz6SfRJKpbbj5zZlVEntlIbN3lLTumqUpMQY 9sMFePFM54V0N8ccqp0FsHcxioRsBBi1xVQqBs4LIFpZX0coyrrMU9Hnkjz0zP5Y1JUx Wb42OUXMLqldmHG7xnN8DglnrXwYXq7QBSdWgubz9FYStl8GsjFwXw4dUiYl9YMNdVWm o1CA== X-Gm-Message-State: AOAM531zdQb2Wd/5KJ5MQxafpDNOYOZuZng2SoX7iuLDec60keoxPong Ej+UvtEkthsBh8Bwhkl58bnyObMv4+c= X-Google-Smtp-Source: ABdhPJxHlTc2y+Bx7N7BqErBz0zEsNyD0GOHmEURfyOD725Rvk/bWYX4uIqsf9dLKUMjXxcQHdC2FA== X-Received: by 2002:a17:902:b706:: with SMTP id d6mr8251008pls.244.1596301345796; Sat, 01 Aug 2020 10:02:25 -0700 (PDT) Received: from [192.168.1.182] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id oc4sm9226846pjb.51.2020.08.01.10.02.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Aug 2020 10:02:25 -0700 (PDT) Subject: Re: [PATCH] fs: optimise kiocb_set_rw_flags() To: Pavel Begunkov , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <636faf6f-4c85-0582-2482-b99002888d0d@kernel.dk> Date: Sat, 1 Aug 2020 11:02:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/1/20 4:36 AM, Pavel Begunkov wrote: > Use a local var to collect flags in kiocb_set_rw_flags(). That spares > some memory writes and allows to replace most of the jumps with MOVEcc. I've picked this one up. -- Jens Axboe