From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: kolAflash <kolAflash@kolahilft.de>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>
Subject: Re: [PATCH] PM: hibernate: Allow hybrid sleep to work with s2idle
Date: Mon, 24 Oct 2022 19:12:36 -0500 [thread overview]
Message-ID: <63718e7b-bc37-af47-011d-9fd0207a6d2c@amd.com> (raw)
In-Reply-To: <20221013035017.5098-1-mario.limonciello@amd.com>
On 10/12/2022 22:50, Mario Limonciello wrote:
> Hybrid sleep is currently hardcoded to only operate with S3 even
> on systems that might not support it.
>
> Instead of assuming this mode is what the user wants to use, for
> hybrid sleep follow the setting of `mem_sleep_current` which
> will respect mem_sleep_default kernel command line and policy
> decisions made by the presence of the FADT low power idle bit.
>
> Reported-and-tested-by: kolAflash <kolAflash@kolahilft.de>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216574
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> kernel/power/hibernate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hi Rafael,
This got sent near the merge window a few weeks ago. It's a trivial fix
so I just want to make sure it didn't get misplaced.
Thanks!
>
> diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
> index 89c71fce225dd..537dd3beafc16 100644
> --- a/kernel/power/hibernate.c
> +++ b/kernel/power/hibernate.c
> @@ -641,7 +641,7 @@ static void power_down(void)
> int error;
>
> if (hibernation_mode == HIBERNATION_SUSPEND) {
> - error = suspend_devices_and_enter(PM_SUSPEND_MEM);
> + error = suspend_devices_and_enter(mem_sleep_current);
> if (error) {
> hibernation_mode = hibernation_ops ?
> HIBERNATION_PLATFORM :
next prev parent reply other threads:[~2022-10-25 1:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 3:50 Mario Limonciello
2022-10-25 0:12 ` Limonciello, Mario [this message]
2022-10-25 12:55 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63718e7b-bc37-af47-011d-9fd0207a6d2c@amd.com \
--to=mario.limonciello@amd.com \
--cc=kolAflash@kolahilft.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®