mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: "Reinette Chatre" <reinette.chatre@intel.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Shuah Khan <shuah@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Valentin Obst <kernel@valentinobst.de>,
	<linux-kselftest@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>
Subject: Re: [PATCH] selftests/resctrl: fix clang build warnings related to abs(), labs() calls
Date: Fri, 3 May 2024 15:00:20 -0700	[thread overview]
Message-ID: <63750681-92b1-4c21-8d58-6a22709822fb@nvidia.com> (raw)
In-Reply-To: <46a6019c-b029-4764-8c66-ad61f4191716@intel.com>

On 5/3/24 1:46 PM, Reinette Chatre wrote:
> Hi John,
> On 5/3/2024 12:12 PM, John Hubbard wrote:
>> On 5/3/24 11:37 AM, Reinette Chatre wrote:
>>> On 5/3/2024 9:52 AM, John Hubbard wrote:
>>>> On 5/3/24 1:00 AM, Ilpo Järvinen wrote:
>>>>> On Thu, 2 May 2024, John Hubbard wrote:
>>>> ...
...
>> I assumed that this code did not expect to handle negative numbers,
>> because it is using unsigned math throughout.
>>
>> If you do expect it to handle cases where, for example, this happens:
>>
>>     avg_bw_imc > avg_bw_resc
> 
> The existing code seems to handle this ok. A sample program with this
> scenario comparing existing computation with your first proposal is
> below:
> 
> #include <stdio.h>
> #include <stdlib.h>
> 
> void main(void) {
> 	unsigned long avg_bw_resc = 20000;
> 	unsigned long avg_bw_imc = 40000;
> 	float avg_diff;
> 
> 	/* Existing code */
> 	avg_diff = (float)labs(avg_bw_resc - avg_bw_imc) / avg_bw_imc;
> 	printf("Existing code: avg_diff = %f\n", avg_diff);
> 
> 	/* Original proposed fix */
> 	avg_diff = (float)(avg_bw_resc - avg_bw_imc) / avg_bw_imc;
> 	printf("Original proposed fix: avg_diff = %f\n", avg_diff);
> }
> 
> output:
> Existing code: avg_diff = 0.500000
> Original proposed fix: avg_diff = 461168590192640.000000

That seems "a little bit" wrong. haha :)

> 
>>
>> ...then a proper solution is easy, and looks like this:
>>
>> diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c
>> index c873793d016d..b87f91a41494 100644
>> --- a/tools/testing/selftests/resctrl/mbm_test.c
>> +++ b/tools/testing/selftests/resctrl/mbm_test.c
>> @@ -17,8 +17,8 @@
>>   static int
>>   show_bw_info(unsigned long *bw_imc, unsigned long *bw_resc, size_t span)
>>   {
>> -       unsigned long avg_bw_imc = 0, avg_bw_resc = 0;
>> -       unsigned long sum_bw_imc = 0, sum_bw_resc = 0;
>> +       long avg_bw_imc = 0, avg_bw_resc = 0;
>> +       long sum_bw_imc = 0, sum_bw_resc = 0;
>>          int runs, ret, avg_diff_per;
>>          float avg_diff = 0;
>>
>> Should I resend the patch with that approach?
> 
> ok. That indeed makes the computations easier to understand. I assume
> you intend to fix the snippet in mba_test.c also?
> 

Yes, will do that. Thanks for spotting the bug in the original "fix"!

thanks,
-- 
John Hubbard
NVIDIA


  reply	other threads:[~2024-05-03 22:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03  2:32 John Hubbard
2024-05-03  8:00 ` Ilpo Järvinen
2024-05-03 16:52   ` John Hubbard
2024-05-03 18:37     ` Reinette Chatre
2024-05-03 19:12       ` John Hubbard
2024-05-03 20:46         ` Reinette Chatre
2024-05-03 22:00           ` John Hubbard [this message]
2024-05-06  9:07         ` Ilpo Järvinen
2024-05-06 17:21           ` John Hubbard
2024-05-08 19:02 John Hubbard
2024-05-08 19:39 ` John Hubbard
2024-05-10  9:06 ` Ilpo Järvinen
2024-05-10 18:01   ` John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63750681-92b1-4c21-8d58-6a22709822fb@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=fenghua.yu@intel.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=justinstitt@google.com \
    --cc=kernel@valentinobst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=reinette.chatre@intel.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®