From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 287CF1B4223 for ; Mon, 25 May 2026 13:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779715005; cv=none; b=sh1tty3MVjkumC4q+AtN6xjvW1xiD9S2gDizkFIrIwBHmua0O4HBr5KogUcjEyqhvZvDQdWVZPFZmgyl0vS1XKjfGukV9Pnlki9gx5F4eCEVdMruyYDlCFRi9CR8Hy5zcWRkp9q4BwTNuhUmc9cKAcVR3AIgTAL22C+qHM3pe0E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779715005; c=relaxed/simple; bh=S852ehqBfb0/5Ul5U+y7lcBRcWUwtf9wkT0ZuTEZgNI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TjMOEabGin/OXdoL8qFiWOOQP9U8BJzzgsWsO4sfD20ckwDgL6NLF2qjg57i7uREyvXkYXvQEIQe5TgkgBunzdSF8X2V4rCJy6xWhGXc3Xjw2NT1QuOOPr+dJL5WvNyE6XVev5YYVPM96UrVnpQgPm9UMjJWvtXpaX7wo9J3PqU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pGUebKqh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q49zbmVj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pGUebKqh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q49zbmVj" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64P9M1Dx3580685 for ; Mon, 25 May 2026 13:16:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= u97YqLbcmLlh10lDQSuWmKtQsqDRCwVMztT7iDYcshA=; b=pGUebKqhpMtm76GN PkCzhsWW3B2/l2VJDFTjuneFWyarLhRaSyY8PP8GOiFzGcR8v7mn4M6SbCBDo6sX vvFrQ425kV/00V/BOLOLaZbqeObzbbm/xImzFRc+mECF1ygDNcvMh6Tpta2KLxsi BpWTVMQDHTJpDpmUSLvCJ3+InbnTMy9kWHP7ByoU3lkFFo0oWpik7kPmneIkIZnh xQrcpO+eysQcryLvMjnvKw46BEQ2MHiJcVy11s17VksXFOUKONQC/adETAtVKhpW p2opz1ulAE5ley0WGUObrVekuyuEYJA42q6doNi0TfAENVzwxAGLSNM3L35WZjq2 oOY+mg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eb3txpsr9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 25 May 2026 13:16:43 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-914b56f450aso82482085a.2 for ; Mon, 25 May 2026 06:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779715002; x=1780319802; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u97YqLbcmLlh10lDQSuWmKtQsqDRCwVMztT7iDYcshA=; b=Q49zbmVjjxplv6t6Yfm55bJgRLAeAzsCJqqb/MFQ8YJD0JFA5RzpdQDX169r4L0DUi lMTjAeWznlCyYZFqQicN4gPb2jUHPkDgAsw4j41Sqp7ll6GyXmPyAb3wqh0INWPnHvp3 By5Dm8RjjTPhNb/5TUTWkk+FTHaA4r1aFTd/I7WmnSVWPm/Dqgy89+u+TPM4NL+z4kTV 3k5vMO/+NkEahHpnt8ZxKyIbFncgyYSggXc5q4olr/iaZvWrB6SZt09qEF01a2cWd7XB hG5YOfFT0MQGdxJnlrJuXbQ6fJZE/zIJ+VjzzISrhZMuPfwFaCGW5iF2STxnFqw6MGe8 5d2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779715002; x=1780319802; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u97YqLbcmLlh10lDQSuWmKtQsqDRCwVMztT7iDYcshA=; b=AOQD39Wmm2wn3W7OkMrlmcsRf6qRkf3nez3oRc3rqeAOkaPnF3bhm7bjjUZSGtWpAm bAMOfyNB2vPxodPN+vr5q0hGJwxLUE6kBiqk+lvLpBG+HQhId85QB5T+po4BGD/9ZqGk 4Y3NlJdEXz44uKRzRiteDORhg3TRgVDbCrKOArWpk8TosuVm+jv6klexBTBsurv9Qws8 1Al3QE+zTd0/ZwsBxoJUi2OAE3J9q87d/7VFlHr/i/hCHE1Q3+SmSeLffNIOZ52LuuJd lUuifgYY6QDy1f5LWsGhyJ8PHuzeX57uBB/N1GV4Fzea5hBULqTg4q/h7XMV90Jv92Si g2KA== X-Forwarded-Encrypted: i=1; AFNElJ+98SLrdoJZq5ZJOc19cla/PRskL6qTtwgNfOZggSJIvxCAzJn9kdldox8NHd/Tk5i1LhBekgmz3LMFqWA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxos2WKmSMJYR8qpClOffd3r9zYK1a32EyF0WxTj3er5TVmwlIN 7a72Y542Q4r9wadL+QdvhEcy/zWol5YLxrjzbKJf4c2i79LU4WOCKcHiAAmAcWJx1esECk9h3JT cYtWnGoX19w3nPr4Hmr2RUKgj5vKXsn/gcfYPOebE0+RMoNtHqfMtZPp9deoZjhg2tXE= X-Gm-Gg: Acq92OGI/lnYgxondjUP3RN6Oi1ejbubG2uI7ODrG6ASXdXByIc8aSEffT0GwemWEHl PrFRgYrR3l3YPXbsjgEwV5JEWvz4Mty8AsWmVuze7V0ZGTpVYHQylE3LzWKCeBwhHHT3cmrnwHT zEmeCqYWx+WuAOU60vdRvd2nX3+mBHP94eXAguobDs8aloc2snHIz84ODrsXEGvsrAP+2wjIQLc 4qRmWbwk29ToveJXWVA28WBgORpCdRUfIKSyrFwW4DNWC57zdIActKSMoFYlC1H03vn9SgKYJwr U9tDVYTGYweuTflcrD+OWuHnp4M2UIzWZAnJj/FGSjRmZc6+WPfVEcT0tl6sf01qLzfAKHulQw7 1kwbSFNH6FL01sUu6RXyqAPSuHlCnnodx+u3yKQYd1vuBNw== X-Received: by 2002:a05:620a:2813:b0:908:a758:baae with SMTP id af79cd13be357-914b49fdfc3mr1377840185a.6.1779715002366; Mon, 25 May 2026 06:16:42 -0700 (PDT) X-Received: by 2002:a05:620a:2813:b0:908:a758:baae with SMTP id af79cd13be357-914b49fdfc3mr1377837285a.6.1779715001935; Mon, 25 May 2026 06:16:41 -0700 (PDT) Received: from [192.168.119.254] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-688b72cbbf3sm3903115a12.0.2026.05.25.06.16.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 06:16:40 -0700 (PDT) Message-ID: <63752557-6468-4aef-a847-06aa39ce108d@oss.qualcomm.com> Date: Mon, 25 May 2026 15:16:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/5] arm64: dts: qcom: Add Shikra CQ2390M SoM platform To: Komal Bajaj , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Neil Armstrong , Wesley Cheng , Ulf Hansson Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-mmc@vger.kernel.org, monish.chunara@oss.qualcomm.com, Rakesh Kota References: <20260522-shikra-dt-v3-0-80ffde8a3dc4@oss.qualcomm.com> <20260522-shikra-dt-v3-3-80ffde8a3dc4@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260522-shikra-dt-v3-3-80ffde8a3dc4@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI1MDEzNyBTYWx0ZWRfX3do2d6Rme4Bn gtQ0xd9z7tc6hX37RDW8e/vat/84wh58oKnrLmSUlBIlbRmj04tPu3+acomylsCh7wfx7B63WIj KUFRvl1OloOzvIu6jxZXhUGQDuZBxQN4ku4LAcS0RnzoI3syS9440wdiNxdjp4+FXVlfA38dFrc ND0eAqAw72rYGHnm+nCwl1yLW+4eSXcJBiGr5MDPOAl+eWfz2tdnHG/SLvinhjWZzg3cM+VGS/9 UvY4UXxYv+56BIo+WIBvoCvRKyoS2Q7cDHotmYUfesDcHR6yZpBlbvH2Wy9O+biiDfpvmKn6kaa xctuiI3tGVpb/y/TnR/oKoAeL25+rDHzhXnKW6abaCpTfDVA0llP3twpzKeyCpGsLmosv+ursqQ hTNmlORYQUJG+Eyx6Y7ASkNqxnm8z8ESBmMi80KnivitMn7QtfT3mGOULRYBp0ZXLkufULSQvb8 rX9MpV9RhCdDNkdUOfQ== X-Proofpoint-GUID: 7I5Li6uRZ8RCnLSqLg_M2j1buOBK1O1E X-Proofpoint-ORIG-GUID: 7I5Li6uRZ8RCnLSqLg_M2j1buOBK1O1E X-Authority-Analysis: v=2.4 cv=MetcfZ/f c=1 sm=1 tr=0 ts=6a144bbb cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=I9A3L-BP1q0m1wO2EfQA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-25_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605250137 On 5/22/26 8:02 PM, Komal Bajaj wrote: > Add device tree include for the CQ2390M variant of the Shikra > System-on-Module, a compact compute module integrating the Shikra SoC > and PMIC for IoT applications, designed to mount on carrier boards. > > - shikra-cqm-som.dtsi: Retail SoM with modem (PM4125 and PM8005 PMIC) > > The DTSI includes the common shikra.dtsi, adds PM4125 and PM8005 PMIC > regulator definitions specific to this variant. > > Co-developed-by: Rakesh Kota > Signed-off-by: Rakesh Kota > Signed-off-by: Komal Bajaj > --- [...] > +/ { > + gpio-key { This is usually 'gpio-keys', reglardless of the amount > + compatible = "gpio-keys"; > + label = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&vol_up_n>; property-n property-names in this order, please [...] > +&pm4125_resin { > + linux,code = ; > + status = "okay"; A \n before 'status' is customary > +}; > + > +&pm8005_regulators { > + status = "disabled"; > +}; ? (also double \n below) Konrad