From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752585AbdLFSSI (ORCPT ); Wed, 6 Dec 2017 13:18:08 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:34354 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752529AbdLFSSE (ORCPT ); Wed, 6 Dec 2017 13:18:04 -0500 Reply-To: shuah@kernel.org Subject: Re: [PATCH] tools/usbip: fixes build with musl libc toolchain To: julien.boibessot@free.fr, Valentina Manea , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Cc: Julien BOIBESSOT , Shuah Khan References: <1512496094-8940-1-git-send-email-julien.boibessot@free.fr> From: Shuah Khan Message-ID: <6378931e-57f5-0960-9a88-53bcfbf8dc69@kernel.org> Date: Wed, 6 Dec 2017 11:17:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1512496094-8940-1-git-send-email-julien.boibessot@free.fr> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/2017 10:48 AM, julien.boibessot@free.fr wrote: > From: Julien BOIBESSOT > > Indeed musl doesn't define old SIGCLD signal name but only new one SIGCHLD. > SIGCHLD is the new POSIX name for that signal so it doesn't change > anything on other libcs. > > This fixes this kind of build error: > > usbipd.c: In function ‘set_signal’: > usbipd.c:459:12: error: 'SIGCLD' undeclared (first use in this function) > sigaction(SIGCLD, &act, NULL); > ^~~~~~ > usbipd.c:459:12: note: each undeclared identifier is reported only once > for each function it appears in > Makefile:407: recipe for target 'usbipd.o' failed > make[3]: *** [usbipd.o] Error 1 > > Signed-off-by: Julien BOIBESSOT > --- Thanks for the patch. Greg, Please pick this up. Acked-by: Shuah Khan thanks, -- Shuah