mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel.daenzer@mailbox.org>
To: "Julian Orth" <ju.orth@gmail.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Christian König" <christian.koenig@amd.com>,
	"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
	"Rob Clark" <robin.clark@oss.qualcomm.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/syncobj: Fix handle <-> fd ioctls with dirty stack
Date: Tue, 3 Mar 2026 12:17:37 +0100	[thread overview]
Message-ID: <637a138f-ee6f-4940-843f-0ec873997de3@mailbox.org> (raw)
In-Reply-To: <20260301-point-v1-1-21fc5fd98614@gmail.com>

On 3/1/26 13:34, Julian Orth wrote:
> Consider the following application:
> 
>     #include <fcntl.h>
>     #include <string.h>
>     #include <drm/drm.h>
>     #include <sys/ioctl.h>
> 
>     int main(void) {
>         int fd = open("/dev/dri/renderD128", O_RDWR);
>         struct drm_syncobj_create arg1;
>         ioctl(fd, DRM_IOCTL_SYNCOBJ_CREATE, &arg1);
>         struct drm_syncobj_handle arg2;
>         memset(&arg2, 1, sizeof(arg2)); // simulate dirty stack
>         arg2.handle = arg1.handle;
>         arg2.flags = 0;
>         arg2.fd = 0;
>         arg2.pad = 0;
>         // arg2.point = 0; // userspace is required to set point to 0
>         ioctl(fd, DRM_IOCTL_SYNCOBJ_HANDLE_TO_FD, &arg2);
>     }
> 
> The last ioctl returns EINVAL because args->point is not 0. However,
> userspace developed against older kernel versions is not aware of the
> new point field and might therefore not initialize it.
> 
> The correct check would be
> 
>     if (args->flags & DRM_SYNCOBJ_FD_TO_HANDLE_FLAGS_TIMELINE)
>         return -EINVAL;
> 
> However, there might already be userspace that relies on this not
> returning an error as long as point == 0. Therefore use the more lenient
> check.
> 
> Fixes: c2d3a7300695 ("drm/syncobj: Extend EXPORT_SYNC_FILE for timeline syncobjs")
> Signed-off-by: Julian Orth <ju.orth@gmail.com>
> ---
> This patch fixes a regression that would cause conversions between
> syncobj handles and fds to fail if userspace did not initialize a
> recently-added field to 0.

While I don't object to this change, I'd argue that this is really a workaround for broken user space, not a fix for a kernel regression.

User space must initialize the full struct to 0, except for the fields it wants to have other values. This kind of kernel-side workaround for neglecting that won't be possible in all cases.


-- 
Earthling Michel Dänzer       \        GNOME / Xwayland / Mesa developer
https://redhat.com             \               Libre software enthusiast

  parent reply	other threads:[~2026-03-03 11:23 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-01 12:34 Julian Orth
2026-03-02 11:27 ` Christian König
2026-03-02 11:54   ` Dmitry Osipenko
2026-03-03 11:17 ` Michel Dänzer [this message]
2026-03-03 11:23   ` Julian Orth
2026-03-03 11:38     ` Michel Dänzer
2026-03-03 11:41       ` Julian Orth
2026-03-03 14:53 ` Maarten Lankhorst
2026-03-03 14:59   ` Christian König
2026-03-03 15:15     ` Maarten Lankhorst
2026-03-03 15:21       ` Julian Orth
2026-03-03 17:02         ` Michel Dänzer
2026-03-03 15:29     ` Michel Dänzer
2026-03-03 15:36       ` Julian Orth
2026-03-03 16:40         ` Maarten Lankhorst
2026-03-03 16:54           ` Julian Orth
2026-03-03 17:04             ` Michel Dänzer
2026-03-03 17:11               ` Julian Orth
2026-03-03 17:18                 ` Michel Dänzer
2026-03-03 17:30                   ` Julian Orth
2026-03-03 17:44                     ` Maarten Lankhorst
2026-03-03 18:53                       ` Michel Dänzer
2026-03-03 19:12                         ` Julian Orth
2026-03-04  9:57                           ` Maarten Lankhorst
2026-03-04 11:15                           ` Michel Dänzer
2026-03-04 11:25                             ` Julian Orth
2026-03-04 11:47                               ` Michel Dänzer
2026-03-04 12:32                                 ` Julian Orth
2026-03-04 14:29                                   ` Michel Dänzer
2026-03-04 14:35                                     ` Julian Orth
2026-03-05  9:47                               ` Maarten Lankhorst
2026-03-03 17:40                   ` Maarten Lankhorst
2026-03-03 17:44                     ` Julian Orth
2026-03-03 19:58                       ` David Laight
2026-03-04 10:35                         ` Maarten Lankhorst
2026-03-03 17:05             ` Maarten Lankhorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=637a138f-ee6f-4940-843f-0ec873997de3@mailbox.org \
    --to=michel.daenzer@mailbox.org \
    --cc=airlied@gmail.com \
    --cc=christian.koenig@amd.com \
    --cc=dmitry.osipenko@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ju.orth@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®