From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2770C433E4 for ; Fri, 17 Jul 2020 08:29:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5F1E20775 for ; Fri, 17 Jul 2020 08:29:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726333AbgGQI3G (ORCPT ); Fri, 17 Jul 2020 04:29:06 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:8315 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725864AbgGQI3F (ORCPT ); Fri, 17 Jul 2020 04:29:05 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 29A5AA7FFEC80B765914; Fri, 17 Jul 2020 16:29:03 +0800 (CST) Received: from [127.0.0.1] (10.174.178.16) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Fri, 17 Jul 2020 16:28:54 +0800 Subject: Re: [PATCH] [SCSI] libsas: add missing newline when printing 'enable' by sysfs To: John Garry , , CC: , , References: <1594971374-40210-1-git-send-email-wangxiongfeng2@huawei.com> <648c18d0-cc0a-f444-e774-e0938f697e90@huawei.com> From: Xiongfeng Wang Message-ID: <6381e401-53d3-3693-03ea-f709e95a3ec8@huawei.com> Date: Fri, 17 Jul 2020 16:28:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <648c18d0-cc0a-f444-e774-e0938f697e90@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.16] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, On 2020/7/17 15:54, John Garry wrote: > On 17/07/2020 08:36, Xiongfeng Wang wrote: > > Hi, > > I think "scsi: scsi_transport_sas: " would be a better subject prefix, as this > is not libsas code. > >> When I cat sysfs file 'enable' below 'sas_phy', it displays as follows. >> It's better to add a newline for easy reading. >> >> [root@localhost ~]# cat >> /sys/devices/pci0000:00/0000:00:0d.0/0000:0f:00.0/host3/phy-3:2/sas_phy/phy-3:2/enable >> >> 1[root@localhost ~]# >> >> Signed-off-by: Xiongfeng Wang > > Apart from above, > Reviewed-by: John Garry Thanks for your review. I will send another version. Thanks, Xiongfeng > >> --- >>   drivers/scsi/scsi_transport_sas.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/scsi/scsi_transport_sas.c >> b/drivers/scsi/scsi_transport_sas.c >> index 182fd25..e443dee 100644 >> --- a/drivers/scsi/scsi_transport_sas.c >> +++ b/drivers/scsi/scsi_transport_sas.c >> @@ -563,7 +563,7 @@ static ssize_t do_sas_phy_enable(struct device *dev, >>   { >>       struct sas_phy *phy = transport_class_to_phy(dev); >>   -    return snprintf(buf, 20, "%d", phy->enabled); >> +    return snprintf(buf, 20, "%d\n", phy->enabled); >>   } >>     static DEVICE_ATTR(enable, S_IRUGO | S_IWUSR, show_sas_phy_enable, >> > > > .