From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966306AbbLPTLD (ORCPT ); Wed, 16 Dec 2015 14:11:03 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:58462 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965697AbbLPTLA (ORCPT ); Wed, 16 Dec 2015 14:11:00 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Gregory CLEMENT , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Nicolas Ferre , Thomas Petazzoni , devicetree@vger.kernel.org, Sascha Hauer , Russell King Subject: Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO Date: Wed, 16 Dec 2015 20:10:14 +0100 Message-ID: <6382531.CWmTLTEYMq@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1450290690-32369-1-git-send-email-gregory.clement@free-electrons.com> References: <1450290690-32369-1-git-send-email-gregory.clement@free-electrons.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:UA7rcqYM/o3320Rw8LBrIYxTZmzwZC7UmGsf3q0vgdZGIsKV7/M M9jdPeX2E1EJsA7TkWK3wphYa4INn6cFTZ8+SWDKuTr9BUOPF2Pn1Q/zaOQgz+Ns4zrnlwo gt51+1rLm4skMDvzFOtkZDUTM3aX+PQEXv1BQLLyDtGoKE7dPDMZlcHAnWsXMZCzf2k/ejb +ENffpbXyq4DBT96Gg3EQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:K4ERkA6MdOI=:u1ryakLjLhkPtYsAFuTqEP QEgAWbym9TyiDx0GZtQY/U1KGNse9a1q2tLcbIR4CmgqJdY6+0I1U3TAZB1VFrIH179YkEKM0 GascS/+a4IRm5gE1NDPGsMYTYrZr+j84rYuDpjPssHyfolZMkM+b/BwUaS/9MJR8r8BCJRt7r Do84ZjOPj2ADwRpMEQMOI/5gJFy2DR9/7CxOU9d78UxX7khdgbMrBAx7KuZHtgJfiyVJlA1xO +TxY0If4mDc/HDoctZCfcNGqHgQTvcjaTOy10/4J/InT85WIBzwiyz+Q4F/+geof5LIm4R8T7 zkdrsL950R79pBbi4Usl5Nd5x3x5H1TWjPP5DyftwMMV3XmrPsnC13N7zZV4kjG7CrP7AHZez EmobaFCZxYhWxyYD2yJpuLXbqDAM0IuMPJEMumTLOELWkTdiZzobH2x58QMlOYGTwJNV7/I0H dC4cVCr7o8OAUg8P5Azq0YI5l/+Co1AdUhtAvLl9ePpObXndKVV0a2sKGWjeP4HpfhUeQeOTG 1ia0XK0XE5gg4oMnZ7LbU3l4O7uTl+1c90sA99OTVOm7oZDHzKjJg4sgEtY6zW2ZKI9Q3+51Q 17WUEmx1FmMB7euklHQbyh42nwCKMFa+jueNZJmaYjAryLrQeTp5EVkR2Yyk3ZlDDnbNGmoeU 2oQWeokKslTjCsp9U9Hr83uOtrMe6VaU6oiLouXgjSSEAQAXsrai08jw/M3KQctvH4tGfiPSq JCLghw1MNI9MiRnL Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 16 December 2015 19:31:30 Gregory CLEMENT wrote: > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 88c1e1a..35661aa 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include > #include > #include Is this the patch that is already in linux-next? I needed an additional #include to avoid this build error on randconfig builds without GPIOLIB: drivers/net/ethernet/cadence/macb.c: In function 'macb_probe': drivers/net/ethernet/cadence/macb.c:2908:19: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration] bp->reset_gpio = devm_gpiod_get_optional(&bp->pdev->dev, "phy-reset", ^ drivers/net/ethernet/cadence/macb.c:2909:8: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function) GPIOD_OUT_HIGH); ^ drivers/net/ethernet/cadence/macb.c:2909:8: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/cadence/macb.c: In function 'macb_remove': drivers/net/ethernet/cadence/macb.c:2979:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] Arnd