From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3ECA36F8E6 for ; Wed, 22 Jul 2026 14:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784731765; cv=none; b=pozVp5ioosj0KbUWUQA7FCjbLus2G1HUgztIPqzXmNUF93SLnHGJTw1J0VjsYnuCdTeUXJDR45CJy0q9J+dE/wOtY8p2oqG9d0HoAT18dVCLEq345dkvBvqgMr1x4kmuJLAZUW1ni6WFyqrGReQKpBzlKv08DvAwc9J6uUMuh4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784731765; c=relaxed/simple; bh=5n/1lHgYumypq0tDRKtD2mnMhu28osAZ8FForf8ddW4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ArhQvszyXREM5+A0Zo6rSpKw2W+0pMTzBgXsw1KepH0k6TjwFcuWrIB3SrQ4DnxEH0jO+EYPLsVdn3gZ+JsOXpKHH0jky1dPCmsx/LFUbZMgxsMVNlwluKj6rDad1j+JLTqbB0v3T/ymcptSJwRJz80fmkGU1vuBfDiHG3ZHW8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=permerror header.from=sipsolutions.net; spf=none smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=D0lRvZUK; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=permerror header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="D0lRvZUK" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=5n/1lHgYumypq0tDRKtD2mnMhu28osAZ8FForf8ddW4=; t=1784731763; x=1785941363; b=D0lRvZUKJyvmuUjQZpqSaQEyaRe1gFs9Wb70i3MOhWawDYg tM29CrwR7KKCB0qaer26MZa2bbbOQAn1y0L6Cqgg5oEkA/odOW53blgyk6QOvSuLhk56EsOm59xfz LX5EDjCnq3QrP2aR0OCxAS10ydg3Xj6iviwlmtpkXtQeFja58GDV+YWrEKL4BMRcwY2KVYjszF9Bo UDHwVPPrg60x5DMKbRaSYJPG5t28EvQmvwXi4RaII+wKvjCeRzKpmMSiRcjG4KcI9GvkBZd2iQNNG pajU7HPMyLdexiv9qYHXO6nWP1/513gmhI2m/rY/qbjYHKZWcVVOCCGXYo8x7a0w==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__ECDSA_SECP256R1_SHA256__AES_256_GCM:256) (Exim 4.98.2) (envelope-from ) id 1wmYG1-00000004pEu-0Y1M; Wed, 22 Jul 2026 16:49:13 +0200 Message-ID: <6385309c68d6d8a928a01f421b54e1cdf8001c97.camel@sipsolutions.net> Subject: Re: [PATCH 1/2] um: add uml_kmalloc_array() helper to avoid potential From: Johannes Berg To: iamhswang@gmail.com, richard@nod.at, anton.ivanov@cambridgegreys.com, akpm@linux-foundation.org, dave.hansen@linux.intel.com, tiwei.btw@antgroup.com, rppt@kernel.org, kevin.brodsky@arm.com, snovitoll@gmail.com, linux@weissschuh.net Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 22 Jul 2026 16:49:12 +0200 In-Reply-To: <20260120112938.463596-1-iamhswang@gmail.com> (sfid-20260120_123032_467740_95AB1171) References: <20260120112938.463596-1-iamhswang@gmail.com> (sfid-20260120_123032_467740_95AB1171) Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Tue, 2026-01-20 at 19:28 +0800, iamhswang@gmail.com wrote: > From: Haisu Wang >=20 > Add uml_kmalloc_array to avoid potential dynamic multiplication > overflow. Since in Documentation/process/deprecated.rst, > the preferred way is avoid the open-coded arithmetic. Personally, I think it's kind of pointless because the only two users have small static arguments ... but if you want to continue with this then >=20 > +extern void *uml_kmalloc_array(int count, int size, int flags); the prototype should probably match better and use size_t, size_t, unsigned int? johannes