From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 336BEC4332F for ; Tue, 15 Nov 2022 09:36:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232719AbiKOJgp (ORCPT ); Tue, 15 Nov 2022 04:36:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232359AbiKOJgm (ORCPT ); Tue, 15 Nov 2022 04:36:42 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A673813D1E; Tue, 15 Nov 2022 01:36:41 -0800 (PST) Received: from kwepemi100025.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NBLfC0LRlzmVw7; Tue, 15 Nov 2022 17:36:19 +0800 (CST) Received: from [10.174.148.223] (10.174.148.223) by kwepemi100025.china.huawei.com (7.221.188.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 15 Nov 2022 17:36:39 +0800 Message-ID: <638b2550-7da8-1b48-4038-52f71947ff05@huawei.com> Date: Tue, 15 Nov 2022 17:36:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC 0/4] pci/sriov: support VFs dynamic addition To: Leon Romanovsky , Oliver O'Halloran CC: , , , , , , , , References: <20221111142722.1172-1-longpeng2@huawei.com> <0b2202bf-18d3-b288-9605-279208165080@huawei.com> <3a8efc92-eda8-9c61-50c5-5ec97e2e2342@huawei.com> From: "Longpeng (Mike, Cloud Infrastructure Service Product Dept.)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.148.223] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi100025.china.huawei.com (7.221.188.158) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/11/15 16:32, Leon Romanovsky 写道: > On Tue, Nov 15, 2022 at 12:50:34PM +1100, Oliver O'Halloran wrote: >> On Tue, Nov 15, 2022 at 1:27 AM Leon Romanovsky wrote: >>> >>> *snip* >>> >>> Anyway, I'm aware of big cloud providers who are pretty happy with live >>> migration in production. >> >> I could see someone sufficiently cloudbrained deciding that rebooting >> the hypervisor is fine provided the downtime doesn't violate any >> customer uptime SLAs. Personally I'd only be brave enough to do that >> for a HV hosting internal services which I know are behind a load >> balancer, but apparently there are people at Huawei far braver than I. > > My main point in this discussion that Huawei team doesn't actually > provide any meaningful justification why it is great idea to add new > sysfs file. They use HPC as an argument, but in that world, you won't > see many VMs on one server, as it is important to provide separate MSI-X > vectors and CPUs to each VM. > > They ask from us optimization (do not add device hierarchy for existing HW) > that doesn't exist in the kernel. > > I would say that they are trying to meld SIOV architecture of subfunctions > (SFs) into PCI and SR-IOV world. > I may not agree with you on this point. The sriov_numvfs interface mixes the operation of enabling hardware VFs and the addition of VFs. I just want to split these two operations and also can selectively add some VFs earlier than others. I think there's no violation of PCI spec. > Thanks > .