From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57405C28D13 for ; Mon, 22 Aug 2022 12:09:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233467AbiHVMJC (ORCPT ); Mon, 22 Aug 2022 08:09:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232460AbiHVMI5 (ORCPT ); Mon, 22 Aug 2022 08:08:57 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8A75B175A9; Mon, 22 Aug 2022 05:08:55 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 47C0012FC; Mon, 22 Aug 2022 05:08:58 -0700 (PDT) Received: from [10.57.14.241] (unknown [10.57.14.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 11DA13F718; Mon, 22 Aug 2022 05:08:52 -0700 (PDT) Message-ID: <638e0a6e-10d2-8552-a61f-c4c001a2cbe9@arm.com> Date: Mon, 22 Aug 2022 13:08:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 2/2] cpufreq: CPPC: Change FIE default Content-Language: en-US To: Jeremy Linton Cc: rafael@kernel.org, lenb@kernel.org, viresh.kumar@linaro.org, robert.moore@intel.com, punit.agrawal@bytedance.com, ionela.voinescu@arm.com, pierre.gondois@arm.com, linux-kernel@vger.kernel.org, devel@acpica.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org References: <20220819162547.141333-1-jeremy.linton@arm.com> <20220819162547.141333-3-jeremy.linton@arm.com> From: Lukasz Luba In-Reply-To: <20220819162547.141333-3-jeremy.linton@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/19/22 17:25, Jeremy Linton wrote: > FIE is mostly implemented as PCC mailboxes on arm machines. This was > enabled by default without any data suggesting that it does anything > but hurt system performance. Lets change the default to 'n' until > hardware appears which clearly benefits. > > Signed-off-by: Jeremy Linton > --- > drivers/cpufreq/Kconfig.arm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index 954749afb5fe..ad66d8f15db0 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -22,7 +22,7 @@ config ACPI_CPPC_CPUFREQ > config ACPI_CPPC_CPUFREQ_FIE > bool "Frequency Invariance support for CPPC cpufreq driver" > depends on ACPI_CPPC_CPUFREQ && GENERIC_ARCH_TOPOLOGY > - default y > + default n > help > This extends frequency invariance support in the CPPC cpufreq driver, > by using CPPC delivered and reference performance counters. LGTM Reviewed-by: Lukasz Luba