From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE4502EA749 for ; Wed, 3 Dec 2025 11:47:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762475; cv=none; b=PkTi2/A0Hg2v6W/zxdwEhKiL731WGcWSVRNouH3FTCG8Jc9nUwYuYr/gylUU1dt0YIDg3IuM1zGgyJPSX+2q9XvQJo9fJnGPcgIySG8M1BAxv5BzOdbx3cyAulZawZEqFs8FrjigjE6KBxvVLODavpK6HbEY5HAeiECUvN+ND7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762475; c=relaxed/simple; bh=R+yabMfq2CeFVv1mWTf7SfgSUt1s0X+c+O9zex1v7z0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JqwftI/hEWWFEm3nF2k8RSzGUUFv2FYHSgYgx6k0J41LrGxus8ff0f2WmQISICnfOThn0qm609+zb9qywUyQqF9DDzriSoPdaT6+l4O1kaJ3z2JrninrK3UfrsyoUyEsqDKg9N3FbFSS4+LVNUbH87BkAkqFh3GzE0pK0UEIKnI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VXzQJSk+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h4E07yZr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VXzQJSk+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h4E07yZr" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B3BkDj52436499 for ; Wed, 3 Dec 2025 11:47:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Nd9ki3tDwaPjkpseWA7+nqpKnc4JcNumJ/bvAFF5e0M=; b=VXzQJSk+/mp+WEJa P29s137LPWlzcWOLMnsWYXIz6ZGRC1QEA+8uTB7MTKIekl0hRXtSfKOQqbd+LjK2 y0DFT3e+5rVrOKK25+9HCS+nwm48CnL7r6RFSJF6uLD8KwCurpJw/klet3Kd8mV2 X+gljmZLa4kJsJ0i9uuahvDzyCG9FwyVyYAL4KGK1PWqb6WkNq3p/WrX0lp8pyEU 3fY2FScMG8RwCyMzE7MCZQdE+liufgEBYN1C1zjc+htlKCauM2OCwCZv+wCHfdZ6 d736t9nvRyomVKuATdxyEixDQ9AXh89wJ3Z8SBxtEFWy42h+Se0PFxMwDfsXmw9R PRssKw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4atmmd804a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Dec 2025 11:47:52 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8b2fd6ec16aso107253085a.1 for ; Wed, 03 Dec 2025 03:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764762472; x=1765367272; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Nd9ki3tDwaPjkpseWA7+nqpKnc4JcNumJ/bvAFF5e0M=; b=h4E07yZrBzNlqAYt4sH3bYc7m0Jay2nOijpyY5YquyCGCE3URqkW3QMg5iP4mRnIrm AqIRldPxkKMec+2D0hLkt/kgXbGNPzHJer+rXV4Kg9RxgulNFYO5NVXACRIWwxpIBrPS tWpxIwJfoTmGRSemru6Bhfqb+IAwrnaDq1+J5yJ+B34/BP5g4OzdjLPsE9Xf6an0jTPN FnVPjniCXAkAgT6lq+6phlYDJlz81aCuO1voCXJo2EdP1XV3S45anALrl73exaWQVjem BB4VgH/YgYcQW5deS+0U2E6X8cOIoKkB7qW8hTsXnhmwku3uBnjjfqW4KnTOaTyRlX3V /4Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764762472; x=1765367272; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Nd9ki3tDwaPjkpseWA7+nqpKnc4JcNumJ/bvAFF5e0M=; b=qi81ZO+vmTWEvcGYOF6iUQ4SM6ShL/hqUHVPB5jrmQM7I+eZbl0QZlchBFcTvDHGlU fbkrrdBXPjbannmhRRJPwJkAE27C0e0WkiFaUuaLDXmIvlO9MT7UjllGx//6jOLTJ0H1 Uk15gFDixu+clgA8QA1ilGLv27E6GfMzsY4xnKPFpo2cUKDoUZb5c4RJx2wqEsltcWK3 I9z8DNYiY0tr6v5bcW+gvbITjv2kIgQthqyUZJ6XRt7yigezR2LIJUZBIKY+1r0XKOec /kwxsrutoNEC7G022rxmzRxANq/J2AaBxSxAh3jAS/so3dIpnH5oA8me18dQfNSmEhuF 4u6w== X-Forwarded-Encrypted: i=1; AJvYcCVzDt5Mh+Ikp9AD7D2Zt31UGjHouSwibjDhrBvmVIN9Z8+64kAZYcbvSOZVgfYNje/Xh/uetLPnge3lC6I=@vger.kernel.org X-Gm-Message-State: AOJu0YxRVlIayLUqXaXqkPiLzw7N2gVxTHubTktS4eZm+RbRHXHrYcEH EXcIitpWK56qSijbMs76bkW9jo61kSSzD/hf0fAxyHCZdLIoJfD+pn7pZrJWFnNaw61lEnBgvvr tpOY9RhuxZIngqd/ZlNaeIKbTyl7qLcfy/fi4aWDzMRA4UOI7LVbJvu7W9Kc9PB5OIwk= X-Gm-Gg: ASbGnctj2lQ/68+PT4YVCq8oyXKTOtvpkQAAtrrkfA8GftF9uQ2hg3At32KZl88qjvQ 1+n7Hhn1U88bHeQpAGeNPFJAV3pZMlkLFQNpSy357UWrFwvGCT/jH3v+nRcE7Z+HEYkl4EdPk5P 4+Xf1BnMfmOzMrjqFKWbjvkpISid8LJ4xa4KCs1eWr4XL3UkWuQqdb5CndPu4r0ICtnl7JVodUL PQc3wqKOGzVVbmHpJHGkOD/MbaPlcQtfiyj2yZ3rhKS+4v/PqKrYolgBStmZF0vz0qvRTpdvqJ9 HbMFH2VnkMKrrRDjE0jLUTLzE/f0aCkAvtsETvY0CWpQHewUhBU9ktiq96QDFcsRs69mVrSEOdt WEhrAav7VHmODQo/Gpnr1nPoVHn/gXnLdFwv4f9vYgezwT9DWY6+u9MHae6Wi2jBHug== X-Received: by 2002:a05:620a:4589:b0:8b2:e5c6:b4a2 with SMTP id af79cd13be357-8b5f8c42528mr87848085a.1.1764762471825; Wed, 03 Dec 2025 03:47:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBRMlDQPA1Ek9CZxMtlKfL/JpqaSfedRc8S7pSaotdOtL2dXOJnNoBhDBqB5UQ54dOvo9PwQ== X-Received: by 2002:a05:620a:4589:b0:8b2:e5c6:b4a2 with SMTP id af79cd13be357-8b5f8c42528mr87846185a.1.1764762471383; Wed, 03 Dec 2025 03:47:51 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5199852sm1755995466b.15.2025.12.03.03.47.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 03:47:50 -0800 (PST) Message-ID: <638f4184-b582-4a48-ad63-7c1fd2db492f@oss.qualcomm.com> Date: Wed, 3 Dec 2025 12:47:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: lemans-evk: Add host mode support for USB1 controller To: Krishna Kurapati , Swati Agarwal , andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251203-swati-v1-1-250efcb4e6a7@oss.qualcomm.com> <49ecd190-1aee-42d9-9e6b-c155170aa38b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <49ecd190-1aee-42d9-9e6b-c155170aa38b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: W64wlDUOfbz5rAPcFPMUgwKoQgeJgKic X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAzMDA5MyBTYWx0ZWRfX8nkrsFYl/u5k b9txS9VVPvZSLZM0zdYSfDksJbvdQhOW2WWT4VelY0PCDTsBWDkQS23VunBhazrxQ5zE4bc1B0s CBC5SI1LW+VO5g+Nz5Dzp73c4wB/AWEQnF9VpZZlHiEa9Fnx9gDph7HfhCCm9IW2e7Kt4XfAKFA JNtKnM5Qz41OLxG3NcvTxnLYc/3DBw3Koq8fPc5uBjkUu0/irv4hzWBlDPhkA2LeCVqZb//0bnY kpchHlA+khgLkMtMrc80xJPW8lufb0XY9qsVkxul9J90l+vsNK4BILeO+B/6RRDwNNYhalz0TRb BwpzbkwwrirkBGdGVeV0PMvFbcQPf2fS4sN+rKvyICDB8H696P5+ZBOu31z0M+0zHiIan5HtBcH eH3wzWPCrY15w4cFgFsmKxCBKIHr5A== X-Proofpoint-ORIG-GUID: W64wlDUOfbz5rAPcFPMUgwKoQgeJgKic X-Authority-Analysis: v=2.4 cv=Ctays34D c=1 sm=1 tr=0 ts=69302368 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=cwXdGsxWxYVqnuK_q20A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-02_01,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512030093 On 12/3/25 12:41 PM, Krishna Kurapati wrote: > > > On 12/3/2025 4:59 PM, Konrad Dybcio wrote: >> On 12/3/25 3:42 AM, Swati Agarwal wrote: >>> Enable Host mode support for USB1 controller on EVK Platform. >>> >>> For secondary USB Typec port, there is a genesys USB HUB sitting in between >>> SOC and HD3SS3220 Type-C port controller and SS lines run from the SoC >>> through the hub to the Port controller. Mark the second USB controller as >>> host only capable. >>> >>> Added HD3SS3220 Type-C port controller along with Type-c connector for >>> controlling vbus supply. >>> >>> Signed-off-by: Swati Agarwal >>> --- [...] >>> +                hd3ss3220_47_in_ep: endpoint { >> >> How about rename the other one to hd3ss3220_0 and name this one hd3ss322_1? >> _47 doesn't really tell us anything and may re-appear if there's another >> instance of this IC on another I2C bus >> > > ACK. Can we rename them as "usb-typec_1" and "usb_typec_2" ? > Krzysztof suggested to use generic names and hence we used "usb-typec" instead of hd3ss3220. The generic names rule only applies to node names (text before '@'), the labels are generally only expected to "make overall sense", I think >>> +&usb_1 { >>> +    dr_mode = "host"; >> >> The connector states it's a dual-role data and power device. Is there any >> reason to keep this in host-only mode? >> > > As mentioned in commit text, there is a onboard hub sitting between SoC and the HD3SS3220 port controller. Hence device mode can't be used. This was the reason we left the above port nodes empty since we can't connect them to port nodes of controller. It would have helped if I had paid more attention to that message then.. > Can we mark the connector as host only and remove the empty endpoints ? Would that we sufficient ? The connector should definitely be marked host-only, but the endpoints should still reflect the physical connectivity. If I understood your case properly, this is analogous to what &usb2_2_dwc3 does in arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts - see Commit c02716951e66 ("arm64: dts: qcom: sdm850-lenovo-yoga-c630: add routing for second USB connector") Konrad