From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Barnabás Czémán" <barnabas.czeman@mainlining.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Abel Vesa" <abelvesa@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] arm64: dts: qcom: msm8917-xiaomi-wingtech: add notification led
Date: Tue, 20 Oct 2026 10:08:05 +0200 [thread overview]
Message-ID: <639549d7-9e63-41d1-961d-edf38f6e5e76@oss.qualcomm.com> (raw)
In-Reply-To: <20260921-xiaomi-aw2013-v1-1-a0c3084076de@mainlining.org>
On 9/21/26 7:43 PM, Barnabás Czémán wrote:
> Add the aw2013 led-controller node for controlling the notification LED.
But it's already present!
[...]
> +&blsp1_i2c2 {
> + aw2013: led-controller@45 {
> + compatible = "awinic,aw2013";
> + reg = <0x45>;
> + vcc-supply = <&pm8937_l10>;
> + vio-supply = <&pm8937_l5>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + status = "disabled";
> + };
This feels a little sloppy. Either disabling it where necessary
(presumably a small subset) or moving the definition to the places
that use it (if *that* is a smaller subset) sounds cleaner
Konrad
next prev parent reply other threads:[~2026-10-20 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 17:43 [PATCH 0/4] Redmi 3S/4A/5A/GO status led and haptic Barnabás Czémán
2026-09-21 17:43 ` [PATCH 1/4] arm64: dts: qcom: msm8917-xiaomi-wingtech: add notification led Barnabás Czémán
2026-10-20 8:08 ` Konrad Dybcio [this message]
2026-09-21 17:43 ` [PATCH 2/4] arm64: dts: qcom: msm8917-xiaomi-rolex: enable " Barnabás Czémán
2026-09-21 17:43 ` [PATCH 3/4] arm64: dts: qcom: msm8937-xiaomi-land: group status leds Barnabás Czémán
2026-10-20 8:09 ` Konrad Dybcio
2026-09-21 17:43 ` [PATCH 4/4] arm64: dts: qcom: msm8917-xiaomi-wingtech: move GPIO haptic vibrator Barnabás Czémán
2026-10-20 8:10 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=639549d7-9e63-41d1-961d-edf38f6e5e76@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=barnabas.czeman@mainlining.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®