From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFD401F1913; Tue, 25 Mar 2025 19:59:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742932752; cv=none; b=DtO2AJTicX9u5Tv1fqQFlK2KKRzB4g1m+VUQS5jE3F3gSwjdVEvj0zIZcNh4FE3UUGlov7P4FIuMEjMnK+0rINQAOP8RUELrNefSY+Oajwjnnh84efWPD/N8qPFIEzVEPUlxu72Q5XaFG0UH0688Xw32QPfSEAXkv/cn44gX3hk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742932752; c=relaxed/simple; bh=Kmce4MR3+inOg7HfHkfr1xXue4qdR8d/2SSpd5/SfNE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JHJFGKA0qfh6+Ipybr8TE2C0wMyKOxSLsj78wTNA+55lxrjmNi2ml4pLSnMkt3dmv6F3Y+Bmq5+ZZd8oNUN+YTO0iZ9muQ7luyPqo8/J9SnxW/WIH+GsUMjS8YEtWpB98Oi2emVla5rKzrI2MWwV2icGEn/pDvGsYK+pbU1iM74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=nMe+Ry21; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="nMe+Ry21" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=zASb+pDKpANBRsEZlpC72O+O+RlCzusRinXEvy0fxqU=; b=nMe+Ry21jpk3cRkc5nVgAP1JUk q4VJXR9zH6nu56ZEW7EvGapafBds7R97l1UOS1iypLq6k546wjGV974D7x3loABlnDVqiqUcOoYhn H7asLD5Hj/awUS9uWgvbOwpHOBuJXL+Y9ePnPrkAugLjbTVzw5vPjuL9F/RT48D8Xr7o=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1txAQI-00760q-Ox; Tue, 25 Mar 2025 20:58:54 +0100 Date: Tue, 25 Mar 2025 20:58:54 +0100 From: Andrew Lunn To: Haiyang Zhang Cc: Jakub Kicinski , Erni Sri Satya Vennela , KY Srinivasan , "wei.liu@kernel.org" , Dexuan Cui , "andrew+netdev@lunn.ch" , "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , Long Li , Konstantin Taranov , "horms@kernel.org" , "brett.creeley@amd.com" , "surenb@google.com" , "schakrabarti@linux.microsoft.com" , "kent.overstreet@linux.dev" , "shradhagupta@linux.microsoft.com" , "erick.archer@outlook.com" , "rosenp@gmail.com" , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Paul Rosswurm Subject: Re: [EXTERNAL] Re: [PATCH 2/3] net: mana: Implement set_link_ksettings in ethtool for speed Message-ID: <6396c1f7-756d-476a-833e-7ea35ae41da8@lunn.ch> References: <1742473341-15262-1-git-send-email-ernis@linux.microsoft.com> <1742473341-15262-3-git-send-email-ernis@linux.microsoft.com> <20250325170955.GB23398@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20250325122135.14ffa389@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > This patch is just to support the ethtool option for the speed. > And seems there is no option on ethtool to reset NIC to the default > speed? There is no such thing as default speed. Speed is either: 1) Negotiated with the link partner, picking the highest speed link modes both partners support 2) Forced to a specific speed, based on one of the link modes the interfaces supports. Since you don't have link modes, you are abusing the API. You should choose a different API which actually fits what you are doing, configuring a leaky bucket shaper. Andrew