From: David Lechner <dlechner@baylibre.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Stefano Manni <stefano.manni@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: ad799x: add reference voltage capability to chip_info
Date: Wed, 6 Aug 2025 10:36:35 -0500 [thread overview]
Message-ID: <6397c502-26b2-4fdc-825c-2f666c43ea95@baylibre.com> (raw)
In-Reply-To: <20250806155853.00003f0b@huawei.com>
On 8/6/25 9:58 AM, Jonathan Cameron wrote:
> On Wed, 6 Aug 2025 11:01:57 +0200
> Stefano Manni <stefano.manni@gmail.com> wrote:
>
...
>> + else {
>
> } else {
>
>> + st->vref = NULL;
>> + dev_dbg(&client->dev, "Supplied reference not supported\n");
>> + }
>>
>> st->client = client;
>>
>
I would just completely drop the else. st->vref is already
NULL since st is zeroed at allocation and the message is no
longer useful. Previously, it warned that the devicetree
contained a vref-supply when the chip didn't support it.
But now no message is printed in that case and this message
would be printed on all chips that don't have vref-supply
in the devicetree when that case didn't print anything before.
next prev parent reply other threads:[~2025-08-06 15:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 9:01 [PATCH 0/2] iio: adc: ad799x: reference voltage capability Stefano Manni
2025-08-06 9:01 ` [PATCH 1/2] iio: adc: ad799x: add reference voltage capability to chip_info Stefano Manni
2025-08-06 14:58 ` Jonathan Cameron
2025-08-06 15:36 ` David Lechner [this message]
2025-08-06 20:15 ` Andy Shevchenko
2025-08-06 9:01 ` [PATCH 2/2] iio: adc: ad799x: add reference voltage to ad7994 Stefano Manni
2025-08-06 20:16 ` Andy Shevchenko
2025-08-06 15:40 ` [PATCH 0/2] iio: adc: ad799x: reference voltage capability David Lechner
2025-08-06 20:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6397c502-26b2-4fdc-825c-2f666c43ea95@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=stefano.manni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®