From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932884AbdJKA7c convert rfc822-to-8bit (ORCPT ); Tue, 10 Oct 2017 20:59:32 -0400 Received: from smtp.h3c.com ([60.191.123.56]:40985 "EHLO h3cmg01-ex.h3c.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932682AbdJKA7D (ORCPT ); Tue, 10 Oct 2017 20:59:03 -0400 X-Greylist: delayed 602 seconds by postgrey-1.27 at vger.kernel.org; Tue, 10 Oct 2017 20:59:01 EDT From: Changwei Ge To: Andrew Morton , Vitaly Mayatskih CC: "mm-commits@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-fsdevel@vger.kernel.org" , "linux-next@vger.kernel.org" , "sfr@canb.auug.org.au" , "mhocko@suse.cz" , "broonie@kernel.org" , "ocfs2-devel@oss.oracle.com" , piaojun , Joseph Qi , Jiufei Xue , Mark Fasheh , Joel Becker , Junxiao Bi Subject: Re: mmotm 2016-08-02-15-53 uploaded Thread-Topic: mmotm 2016-08-02-15-53 uploaded Thread-Index: AQHTQf9QAMgCSczV90+pB5JteUy0jA== Date: Wed, 11 Oct 2017 00:48:34 +0000 Message-ID: <63ADC13FD55D6546B7DECE290D39E373CED68187@H3CMLB14-EX.srv.huawei-3com.com> References: <57a124aa.eJmVCvd1SOHlQ1X8%akpm@linux-foundation.org> <20171010123749.2c59f3b762b3c0b33e80a67d@linux-foundation.org> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.125.136.231] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew and Vitaly, I do agree that patch ee8f7fcbe638 ("ocfs2/dlm: continue to purge recovery lockres when recovery master goes down", 2016-08-02) introduced an issue. It makes DLM recovery can't pick up a new master for an existed lock resource whose owner died seconds ago. But this patch truly solves another issue. So I think we can't just revert this patch but to give a fix to it. Thanks, Changwei On 2017/10/11 3:38, Andrew Morton wrote: > On Tue, 10 Oct 2017 14:06:41 -0400 Vitaly Mayatskih wrote: > >> * ocfs2-dlm-continue-to-purge-recovery-lockres-when-recovery >> -master-goes-down.patch >> >> This one completely broke two node cluster use case: when one node dies, >> the other one either eventually crashes (~4.14-rc4) or locks up (pre-4.14). > > Are you sure? > > Are you able to confirm that reverting this patch (ee8f7fcbe638b07e8) > and only this patch fixes up current mainline kernels? > > Are you able to supply more info on the crashes and lockups so that the > ocfs2 developers can understand the failures? > > Thanks. >