From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 854FCC433FF for ; Mon, 5 Aug 2019 16:25:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6490C2086D for ; Mon, 5 Aug 2019 16:25:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729210AbfHEQZx (ORCPT ); Mon, 5 Aug 2019 12:25:53 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:41100 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728871AbfHEQZx (ORCPT ); Mon, 5 Aug 2019 12:25:53 -0400 Received: from mail-pl1-f198.google.com ([209.85.214.198]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1hufnz-0007xm-7O for linux-kernel@vger.kernel.org; Mon, 05 Aug 2019 16:25:51 +0000 Received: by mail-pl1-f198.google.com with SMTP id d2so46579418pla.18 for ; Mon, 05 Aug 2019 09:25:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ahDv1JQ0w2AsFEFKjWvYewqWbx39Q78We1s4PnzLIHE=; b=RTDUT4Y2d47CpJ6jm+5Pl7TU3vHXKKquEuPX7bFxJUsI1HYMJdLS0mdANZiGLfIbrz sU+UmbPwNGXjscRDepZiSrAsVVJCDILVAD/7hL/eNA0gVj7fW4rsgt04ZSvBOXdLehgf yATncsRGs/eDEWWCeSVZ+tIsk3zCnYSrFZEaTeiNKQts9bJBJ9ohfbgtM+2xa4jfBv8P 6Qhz9a0McZovq4DL+xBOn7gVVOVNJogRl7xonFGMI2pttT5It9EWTq0vrp24E37TpCk5 UKkz5FQj4aqEsdSINjy54V2oQlSeDigJ0i0X/5a4u2tVExstsADdpZt55XOHEg2oIr0g MuKA== X-Gm-Message-State: APjAAAVbt0O8yY/U3VjYbbOeVCwP4s2+CnbWyMlcD0PuztXewJYEx3BK HBNhUytSQJaZ2sZREjoS2bm90O/x5cBhlugaVg0HYQrBjv8alQ15ULqqXkAWjdu2V9kiKl0wNC6 l79jyNS/9FDI7zxRxswMrA6E8gKbCoIg/BEnB7BQ/vQ== X-Received: by 2002:a63:1c22:: with SMTP id c34mr30357127pgc.56.1565022349742; Mon, 05 Aug 2019 09:25:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqyGlZdsZ6bGXay0VR9+yR4cNcswW8S4n0UbagMs6pMa5uYImce0UHWrQvcHTxX+l+t8F0knuA== X-Received: by 2002:a63:1c22:: with SMTP id c34mr30357110pgc.56.1565022349363; Mon, 05 Aug 2019 09:25:49 -0700 (PDT) Received: from 2001-b011-380f-37d3-6851-7bc4-3469-2fa7.dynamic-ip6.hinet.net (2001-b011-380f-37d3-6851-7bc4-3469-2fa7.dynamic-ip6.hinet.net. [2001:b011:380f:37d3:6851:7bc4:3469:2fa7]) by smtp.gmail.com with ESMTPSA id u134sm82343207pfc.19.2019.08.05.09.25.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Aug 2019 09:25:48 -0700 (PDT) Content-Type: text/plain; charset=utf-8; delsp=yes; format=flowed Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH v3 0/8] PM / ACPI: sleep: Additional changes related to suspend-to-idle From: Kai-Heng Feng In-Reply-To: <5997740.FPbUVk04hV@kreacher> Date: Tue, 6 Aug 2019 00:25:41 +0800 Cc: Linux ACPI , Linux PM , LKML , Zhang Rui , Rajneesh Bhardwaj , Andy Shevchenko , Mario Limonciello Content-Transfer-Encoding: 8bit Message-Id: <63E89FFF-9471-4F65-B05D-E99EC5C9EFD6@canonical.com> References: <5997740.FPbUVk04hV@kreacher> To: "Rafael J. Wysocki" X-Mailer: Apple Mail (2.3445.104.11) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org at 18:33, Rafael J. Wysocki wrote: > Hi All, > >>> On top of the "Simplify the suspend-to-idle control flow" patch series >>> posted previously: >>> >>> https://lore.kernel.org/lkml/71085220.z6FKkvYQPX@kreacher/ >>> >>> sanitize the suspend-to-idle flow even further. >>> >>> First off, decouple EC wakeup from the LPS0 _DSM processing (patch 1). >>> >>> Next, reorder the code to invoke LPS0 _DSM Functions 5 and 6 in the >>> specification-compliant order with respect to suspending and resuming >>> devices (patch 2). >>> >>> Finally, rearrange lps0_device_attach() (patch 3) and add a command line >>> switch to prevent the LPS0 _DSM from being used. >> >> The v2 is because I found a (minor) bug in patch 1, decided to use a >> module >> parameter instead of a kernel command line option in patch 4. Also, there >> are 4 new patches: >> >> Patch 5: Switch the EC over to polling during "noirq" suspend and back >> during "noirq" resume. >> >> Patch 6: Eliminate acpi_sleep_no_ec_events(). >> >> Patch 7: Consolidate some EC code depending on PM_SLEEP. >> >> Patch 8: Add EC GPE dispatching debug message. > > The v3 is just a rearranged v2 so as to move the post sensitive patch > (previous patch 2) > to the end of the series. [After applying the full series the code is > the same as before.] > > For easier testing, the series (along with some previous patches depended > on by it) > is available in the pm-s2idle-testing branch of the linux-pm.git tree at > kernel.org: > > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/log/?h=pm-s2idle-testing I’ve just tested the full series on Latitude 5300, and the additional spurious wake up is gone. Tested-by: Kai-Heng Feng > > Please refer to the changelogs for details. > > Thanks, > Rafael