From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1 1/2] memory: tegra20: Correct comment to MC_STAT registers writes
Date: Fri, 26 Mar 2021 08:38:02 +0100 [thread overview]
Message-ID: <63a3225e-7cae-8592-653e-04a76b7cf9c1@canonical.com> (raw)
In-Reply-To: <799f54f6-6023-338f-4e8f-cc0dfbac30d8@gmail.com>
On 25/03/2021 18:20, Dmitry Osipenko wrote:
> 24.03.2021 00:04, Dmitry Osipenko пишет:
>> The code was changed multiple times and the comment to MC_STAT
>> registers writes became slightly outdated. The MC_STAT programming
>> now isn't hardcoded to the "bandwidth" mode, let's clarify this in
>> the comment.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>> drivers/memory/tegra/tegra20.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/memory/tegra/tegra20.c b/drivers/memory/tegra/tegra20.c
>> index 14caf5b9324c..4659c0cea30d 100644
>> --- a/drivers/memory/tegra/tegra20.c
>> +++ b/drivers/memory/tegra/tegra20.c
>> @@ -451,9 +451,8 @@ static void tegra20_mc_stat_gather(struct tegra20_mc_stat *stat)
>> control_1 = tegra20_mc_stat_gather_control(&stat->gather1);
>>
>> /*
>> - * Reset statistic gathers state, select bandwidth mode for the
>> - * statistics collection mode and set clocks counter saturation
>> - * limit to maximum.
>> + * Reset statistic gathers state, select statistics collection mode
>> + * and set clocks counter saturation limit to maximum.
>> */
>> mc_writel(mc, 0x00000000, MC_STAT_CONTROL);
>> mc_writel(mc, control_0, MC_STAT_EMC_CONTROL_0);
>>
>
> Krzysztof, please feel free to squash these 2 minor follow up patches
> into the original patch which added the the debug support, if you prefer
> this way more. I happened to notice these small itches only after you
> already picked up the previous patch.
No problem, in general I prefer to have incremental improvements.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-03-26 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 21:04 Dmitry Osipenko
2021-03-23 21:04 ` [PATCH v1 2/2] memory: tegra20: Protect debug code with a lock Dmitry Osipenko
2021-03-25 17:20 ` [PATCH v1 1/2] memory: tegra20: Correct comment to MC_STAT registers writes Dmitry Osipenko
2021-03-26 7:38 ` Krzysztof Kozlowski [this message]
2021-03-26 13:22 ` Dmitry Osipenko
2021-03-26 7:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63a3225e-7cae-8592-653e-04a76b7cf9c1@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®