From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F4C8C433DB for ; Fri, 29 Jan 2021 23:56:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C659D64E02 for ; Fri, 29 Jan 2021 23:56:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232580AbhA2X4Y convert rfc822-to-8bit (ORCPT ); Fri, 29 Jan 2021 18:56:24 -0500 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:23014 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231138AbhA2X4V (ORCPT ); Fri, 29 Jan 2021 18:56:21 -0500 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-29-6edYh7Y8NwSD3Bzf9GiMrw-1; Fri, 29 Jan 2021 23:54:41 +0000 X-MC-Unique: 6edYh7Y8NwSD3Bzf9GiMrw-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 29 Jan 2021 23:54:41 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Fri, 29 Jan 2021 23:54:41 +0000 From: David Laight To: 'Emmanuel Arias' , "m.tretter@pengutronix.de" , "kernel@pengutronix.de" , "mchehab@kernel.org" CC: "gregkh@linuxfoundation.org" , "linux-media@vger.kernel.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] media: allegro-dvt: Use __packed sentence Thread-Topic: [PATCH] media: allegro-dvt: Use __packed sentence Thread-Index: AQHW9nn+Eu7GW6k8EESnigV6OI4+Q6o/RrGQ Date: Fri, 29 Jan 2021 23:54:41 +0000 Message-ID: <63a4ed5c2ef54c09b2df9d6234b68711@AcuMS.aculab.com> References: In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Emmanuel Arias > Sent: 29 January 2021 20:02 > > Fix coding style using __packed sentece instead of > __attribute__((__packed__)). > > Signed-off-by: Emmanuel Arias > --- > drivers/staging/media/allegro-dvt/allegro-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/allegro-dvt/allegro-core.c b/drivers/staging/media/allegro- > dvt/allegro-core.c > index 9f718f43282b..cee624dac61a 100644 > --- a/drivers/staging/media/allegro-dvt/allegro-core.c > +++ b/drivers/staging/media/allegro-dvt/allegro-core.c > @@ -670,7 +670,7 @@ static ssize_t allegro_mbox_read(struct allegro_mbox *mbox, > struct { > u16 length; > u16 type; > - } __attribute__ ((__packed__)) *header; > + } __packed *header; > struct regmap *sram = mbox->dev->sram; Does this actually need to be packed? The only reason would be if the structure could exist on a 2n+1 boundary. But that is only likely if part of some binary sequence. In which case I'd expect it to be marked __be or __le. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)