From: Dan Murphy <dmurphy@ti.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <andrew@lunn.ch>, <f.fainelli@gmail.com>, <hkallweit1@gmail.com>,
<davem@davemloft.net>, <robh@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH net-next v6 4/4] net: dp83869: Add RGMII internal delay configuration
Date: Thu, 4 Jun 2020 11:38:14 -0500 [thread overview]
Message-ID: <63a53dad-4f0a-31ca-ad1a-361b633c28bf@ti.com> (raw)
In-Reply-To: <20200604092545.40c85fce@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Jakub
On 6/4/20 11:25 AM, Jakub Kicinski wrote:
> On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote:
>> Add RGMII internal delay configuration for Rx and Tx.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> Hi Dan, please make sure W=1 C=1 build is clean:
>
> drivers/net/phy/dp83869.c:103:18: warning: ‘dp83869_internal_delay’ defined but not used [-Wunused-const-variable=]
> 103 | static const int dp83869_internal_delay[] = {250, 500, 750, 1000, 1250, 1500,
> | ^~~~~~~~~~~~~~~~~~~~~~
I built with W=1 and C=1 and did not see this warning.
What defconfig are you using?
Can you check if CONFIG_OF_MDIO is set or not? That would be the only
way that warning would come up.
> Also net-next is closed right now, you can post RFCs but normal patches
> should be deferred until after net-next reopens.
I know net-next is closed.
I pinged David M when it was open about what is meant by "new" patches
in the net-dev FAQ. So I figured I would send the patches to see what
the response was.
To me these are not new they are in process patches. My understand is
New is v1 patchesets.
But now I have the answer.
Dan
next prev parent reply other threads:[~2020-06-04 16:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 11:14 [PATCH net-next v6 0/4] RGMII Internal delay common property Dan Murphy
2020-06-04 11:14 ` [PATCH net-next v6 1/4] dt-bindings: net: Add tx and rx internal delays Dan Murphy
2020-06-15 17:33 ` Rob Herring
2020-06-04 11:14 ` [PATCH net-next v6 2/4] net: phy: Add a helper to return the index for of the internal delay Dan Murphy
2020-06-04 11:14 ` [PATCH net-next v6 3/4] dt-bindings: net: Add RGMII internal delay for DP83869 Dan Murphy
2020-06-15 17:34 ` Rob Herring
2020-06-04 11:14 ` [PATCH net-next v6 4/4] net: dp83869: Add RGMII internal delay configuration Dan Murphy
2020-06-04 16:25 ` Jakub Kicinski
2020-06-04 16:38 ` Dan Murphy [this message]
2020-06-04 16:48 ` Jakub Kicinski
2020-06-04 20:27 ` Dan Murphy
2020-06-04 21:09 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63a53dad-4f0a-31ca-ad1a-361b633c28bf@ti.com \
--to=dmurphy@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®