mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Will McVicker <willmcvicker@google.com>,
	Youngmin Nam <youngmin.nam@samsung.com>,
	Donghoon Yu <hoony.yu@samsung.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] clocksource/drivers/exynos_mct: Revert commits causing section mismatches
Date: Fri, 25 Jul 2025 11:28:16 +0200	[thread overview]
Message-ID: <63a6d253-305d-4ffd-9954-7cd665bd332d@linaro.org> (raw)
In-Reply-To: <20250725090349.87730-2-krzysztof.kozlowski@linaro.org>

On 25/07/2025 11:03, Krzysztof Kozlowski wrote:
> Commit 5d86e479193b ("clocksource/drivers/exynos_mct: Add module
> support") introduced section mismatch failures.
> Commit 7e477e9c4eb4 ("clocksource/drivers/exynos_mct: Fix section
> mismatch from the module conversion") replaced these to other section
> mismatch failures:
> 
>    WARNING: modpost: vmlinux: section mismatch in reference: mct_init_dt+0x164 (section: .text) -> register_current_timer_delay (section: .init.text)
>    WARNING: modpost: vmlinux: section mismatch in reference: mct_init_dt+0x20c (section: .text) -> register_current_timer_delay (section: .init.text)
>    ERROR: modpost: Section mismatches detected.
> 
> No progress on real fixing of these happened (intermediary fix was still
> not tested), so revert both commits till the work is prepared correctly.

Please don't claim the fix was not tested. I reproduced the section 
mismatch, tested it and figured out it was indeed fixing the issue. I 
just missed the error because it sounds very close to the first one 
reported initially and I did the confusion.

The driver is not supposed to be compiled as a module on ARM32.

The option tristate "Exynos multi core timer driver" if ARM64 is 
misleading. From this change, the defconfig on ARM can do 
CONFIG_EXYNOS_MCT=m which should not be allowed.

Before getting wild and revert everything, let's try to find a proper 
fix for that.

Thanks


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply	other threads:[~2025-07-25  9:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-25  9:03 Krzysztof Kozlowski
2025-07-25  9:28 ` Daniel Lezcano [this message]
2025-07-25  9:35   ` Krzysztof Kozlowski
2025-07-25  9:47     ` Krzysztof Kozlowski
2025-07-25 10:15       ` Daniel Lezcano
2025-07-29 17:11     ` William McVicker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63a6d253-305d-4ffd-9954-7cd665bd332d@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=hoony.yu@samsung.com \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=willmcvicker@google.com \
    --cc=youngmin.nam@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®