From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Akhila Kavi <akavi@axiado.com>,
Sammai Chakravarthy <schakravarthy@axiado.com>,
Prasad Bolisetty <pbolisetty@axiado.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Tzu-Hao Wei <twei@axiado.com>,
Karthikeyan Mitran <kmitran@axiado.com>,
Matt Johnston <matt@codeconstruct.com.au>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org,
Adam Young <admiyo@amperemail.onmicrosoft.com>
Subject: Re: [PATCH net-next 0/2] net: mctp: Add MCTP transport for the Axiado AX3005 IRoT
Date: Mon, 16 Nov 2026 22:08:16 +0800 [thread overview]
Message-ID: <63b0ab24f2ec4f83ac87add03f2aa9517f7f73dd.camel@codeconstruct.com.au> (raw)
In-Reply-To: <f752d203-8239-4203-aa04-884b4d7e5d80@axiado.com>
Hi Akhila,
> Thanks for the review. To give some context first: this link is
> entirely internal to the AX3005, and not for host communication. The
> IRoT's MCTP endpoint is only reachable from the application subsystem
> on the same die, through the mailbox and the shared-memory carve-out.
Yep, understood.
> Both ends are fixed on the same die, and no third-party MCTP device
> can ever be on the other end of this link, so carrying it as MMBI
> would add nothing.
It would mean that the driver doesn't need to be entirely custom.
I'm mainly curious as to why you went with a brand-new interface rather
than implement MMBI.
> The IRoT can't bridge anything to this link. As above, nothing outside
> the chip has a hardware path to the IRoT's MCTP endpoint, so the
> application processor is its only MCTP peer.
OK, makes sense. Be aware that you may have the other direction too, in
which case the iRoT may need to fragment (and reassemble) packets that
are bridged through this host, to other peers via links with a smaller
MTU.
I assume that's not in your current designs, but will crop up if those
change.
> If you would prefer, v2 can default mtu to the 68-byte baseline and
> leave max_mtu at the negotiated limit, so the platform config raises
> it explicitly. I'm fine with either option.
Your call really. It's generally safer to start at the BTU and then
increase, but if your platform design means that the max MTU will always
be safe, then may as well set that.
> Please send the implementation comments when you're ready; I'll fold
> them into v2.
OK, shall do.
Cheers,
Jeremy
next prev parent reply other threads:[~2026-11-16 14:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 14:00 Akhila Kavi
2026-11-01 14:00 ` [PATCH net-next 1/2] dt-bindings: net: Add Axiado AX3005 IRoT MCTP transport Akhila Kavi
2026-11-02 11:40 ` Krzysztof Kozlowski
2026-11-01 14:00 ` [PATCH net-next 2/2] net: mctp: Add Axiado AX3005 IRoT MCTP transport driver Akhila Kavi
2026-11-05 13:56 ` Uwe Kleine-König
2026-11-02 2:55 ` [PATCH net-next 0/2] net: mctp: Add MCTP transport for the Axiado AX3005 IRoT Jeremy Kerr
2026-11-16 6:22 ` Akhila Kavi
2026-11-16 14:08 ` Jeremy Kerr [this message]
2026-11-05 23:40 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63b0ab24f2ec4f83ac87add03f2aa9517f7f73dd.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=admiyo@amperemail.onmicrosoft.com \
--cc=akavi@axiado.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=kmitran@axiado.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pabeni@redhat.com \
--cc=pbolisetty@axiado.com \
--cc=robh@kernel.org \
--cc=schakravarthy@axiado.com \
--cc=twei@axiado.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®