From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D57641CB20 for ; Thu, 30 Jul 2026 11:35:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785411308; cv=none; b=qRCduDed6UYzDOiyDaudDWF0m4RjXdcACXfboWlpYDD8nyhkllXV0DrM3Tnz8wZF3PFoEdRhPaNh1tvu9m+80mGihYFy5p63VsZDD8PcR7W0j6Dj9FRvAebI/RHhdqygndMmacx9ZtuBaiSkBBQQx7b8+DSL6F8GDHCJQMaGNUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785411308; c=relaxed/simple; bh=5q46ffEKe/AL/tCJ5clvNOasJqMy2l3vKZtTmAh4GQA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=meL9k1eD6Zcx7o5cw2QY5vFJCRLmCB4tlagbKXUAJ2MJRdHTshRLQh1DefqQ7z+92O5FVzwoKTvZk8MwOUaRzvyqRNKa6nPVo4Dird82cPWE7rohVC1LUBfYifZyWsdMxdtP226PVH4cMtqRaounW/hsCko2sXgcMEK2eS9CjHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F6fclxRi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AQUtsX11; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F6fclxRi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AQUtsX11" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66UA2TYl1664044 for ; Thu, 30 Jul 2026 11:35:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 07/dZmQGLQpEoux0gZ8DuLcNzeKHmPfKLFyU53AM5uA=; b=F6fclxRi6NecK1lX D5bR/vLg6WzqjEO3ftynbg9l0r7oLrKFTxjVNcZV70JMymLnGcIBKhrwHG90drQz oKlA7jF+g+N3pFNJKQUCBSjUJKyZIwTy2HAd9BRkb5XoK2PBorZtw/qsI3CuKZcW 1mbNpj1/0enrYEe5+jrqpC8nCHgzPGV/8s3cJLPFFnk8CLxhqk6TFp6AZLTVCWPc zAH8jlI7Id6mBTdJ3nqwK2a4ddivX+rGFHuqPHtxf8WtJrW+JrMp1F0Oz9/6tjR5 yAOUWWojumWOv8j8NUgg8LiAk5dX7g+IlKJBQUJX6HoHmND/jQ8BiFsHvitESRj8 pe+OOA== Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr3h1rpwa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 11:35:06 +0000 (GMT) Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-81e8653ad27so48480027b3.2 for ; Thu, 30 Jul 2026 04:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785411305; x=1786016105; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=07/dZmQGLQpEoux0gZ8DuLcNzeKHmPfKLFyU53AM5uA=; b=AQUtsX11GIJci9w9zsYdSekoJ8kJzfnFa5kEwvb9WlmH4HJPM4dg6iEbmIDat9G3BY 4beE9BrXWy9bOVISl/NlONekO+PvUTqjowsmKp3KFwPMvrltkXMTG+Xr/jJJCXRhzcxX WnnJG3x772WcvwZ8snDHGYOffnaXZVcxMGipqCtKEhic41GJ+VGHeQHPXDpyIa0v+Jqz me9QZngF/ZXi7zM5MRqA/4m3tqlVY+jT0A1LHECGDyem/8KkK1gCOjh3jqK7g3shtejN 3tf7s5KB7hSrC/kZBhFNHiyvkzO7pO1jdBXf2EQ8yIZvvSkAG7H1PFnXQ0Dvv07Om5IX 4XaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785411305; x=1786016105; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=07/dZmQGLQpEoux0gZ8DuLcNzeKHmPfKLFyU53AM5uA=; b=mMVWuO2Zf+kZDzSIBRnRFLZ//+r2HdnXXLOPM/p0bGSNz1QBZDma7X91AN1eUKM0tL 37Wd1CIfNznGX3HUDf7oZROdrpVZyN/MA56dzwBYVeB0xPR20ND1gRWSnupoxlrj/iF8 a8yajJQJKjoQaJw89AG4QG+kx+dr7PPbxtY3QnOt4g5nEcTMHyQHb0XrYMj0zChPNkTx TfCt69a1+s6gdakaOe9QRN/BB/LB8qX2tStLo0Ac0fbsvc9A6cmcoSpqkN8NKJ1YmdXj UU1Y/Y4b0qthXQFJ3RyrCnPPBL72Bh733jDpMHOTojHG3xblMK/xCTiHgVeK6ClcLSGV q1tg== X-Forwarded-Encrypted: i=1; AHgh+RoJQO52GQ62f2r0y0TG04HE/VEU1k2+a47R9lE9f3dN5aR+BGW3PYJ3+MJ9IgmZdTUdVwi3elaf2TWzCl8=@vger.kernel.org X-Gm-Message-State: AOJu0Yym7+rm1VQZcmYaxCIMLSiWBlGVJzH6tCAfdfzI3ILeqmL92A6T GpE8gESb7GgZgRGZ4CqE+O8D0E6trWbvpPLL9W6R0vA3F82hrDzVGJn7YYsf3+Uw/afhW2+O3rx M7nkFh2Py3nUPvNT/1X086tn028kUPF5/T7zsakh/yg0tKWZypakwwiH5w5/BvoYYuSU= X-Gm-Gg: AR+sD10/eMGrQyChj0fWAPU+5ImWDvWgTesGh3nkyfcPT0G2SQrbsIuZSr4xdluiP2W w5hDKBTB8vYi1KjQJ5P+s6yN9zNuUaBPQxvBnhT6w8+gHcSlQ1rHrGeeYN8Y358VvGgME8DjuM+ vC8iNnqElbM2obNMfdVFF+Cz3a8lBBGxZoZFq3r9jCyE3/Py7BF6wZ0sOHAELg/0yWM/klQK6CV upH71ZYkGzirZgwjHqmns84KIoNLU/2yjyjvecLTaijizSOMuxkrM7Tqj49ZIAtm25Drr49z+6Q sR9rRRDLUKZa765/8NTCPJ/KmRqHnWdV1TiW+QBMH0QOr8VwGfGBX0f390RGGj4qeKWeBPqgh7W 5+XUAHku9Cc4Z3gHNrUxQ0HBBoih6knL99vVa+7WCGuD7c2F2afV8Y287kq/j/07w X-Received: by 2002:a05:690c:c02:b0:81e:4e5d:4848 with SMTP id 00721157ae682-81fb89076a2mr13890037b3.17.1785411305466; Thu, 30 Jul 2026 04:35:05 -0700 (PDT) X-Received: by 2002:a05:690c:c02:b0:81e:4e5d:4848 with SMTP id 00721157ae682-81fb89076a2mr13889687b3.17.1785411304937; Thu, 30 Jul 2026 04:35:04 -0700 (PDT) Received: from ?IPV6:2a01:cde0:108:24ed:2206:62e9:bbc4:c360? ([2a01:cde0:108:24ed:2206:62e9:bbc4:c360]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81fb8926becsm8201587b3.20.2026.07.30.04.35.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 04:35:04 -0700 (PDT) Message-ID: <63b4c911-d1a4-42b0-a66f-b0c84308d5dc@oss.qualcomm.com> Date: Thu, 30 Jul 2026 13:35:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/10] dt-bindings: hwmon: Describe Qualcomm BCL hardware To: Krzysztof Kozlowski , Manaf Meethalavalappu Pallikunhi Cc: Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Stephen Boyd , Bjorn Andersson , Konrad Dybcio , linux-hwmon@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mfd@lists.linux.dev, Gaurav Kohli References: <20260722-qcom-bcl-hwmon-v2-0-febe2805e17b@oss.qualcomm.com> <20260722-qcom-bcl-hwmon-v2-1-febe2805e17b@oss.qualcomm.com> <20260723-radiant-scorpion-of-hurricane-cbed57@quoll> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <20260723-radiant-scorpion-of-hurricane-cbed57@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 04DPE90zkf1vOjHCczjCP389tgUDy2HS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDA4NiBTYWx0ZWRfXzgoSpIg+tB0G ZCmwMmn/egxg0StEYse1cUpQhFqDRmAa6WvyJ4EdlGOztmCSm8zfB+OHoXh6dwYfepzL2izPQPp iPadKfzc1A1lqLM4S1Ex8Ni5IblWtQLXYsNYgkDt0jf09qeRJcMjWNu8NNVx0pnOoyA3eDTJxJ3 xx3XmAFi129uisGz5Gv5ryEsIiMq1/y+/dThpS/phEa/deWG9JLe1DP29xSDpXr2ELDJD1oT0uL mufvNeYJ/tcrfxh/OEcRBdxhi7xGE8xeZQmPqmpMgdIU2a0/ZReSgnm0Z5kiVPZWJhExT9mkD9j fPVEQ7YohHavMe6nCoczULuQxr9E8seyXWvSVqoCyTkeOsG1zIG3LqmJN2OoH+HdMH+qQhRzEro XlCAE0BIW65ZCT/vqaXq7q16ikfR4Jy1G6JpyUo2MGMGQhXemhan6TAQ93T+EYqEpoNRv4nRNdq Ci+aciq6rTGo8dbLq3A== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDA4NiBTYWx0ZWRfXxTB0TNHRer0N bXyDZeSsrLkxFicGMJwyJNMiuSB2D1z8LQEQ3Yg3YUkXEXOe7Gy5Rv0fGnQ4/wlK/HTINenvKFC f9Vslr67pA8NdsMTncBjxrnVhvuZJXs= X-Proofpoint-GUID: 04DPE90zkf1vOjHCczjCP389tgUDy2HS X-Authority-Analysis: v=2.4 cv=K/QS2SWI c=1 sm=1 tr=0 ts=6a6b36ea cx=c_pps a=72HoHk1woDtn7btP4rdmlg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=NFBEJmUEwPxnxbdnG5UA:9 a=QEXdDO2ut3YA:10 a=kA6IBgd4cpdPkAWqgNAz:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_03,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 impostorscore=0 phishscore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300086 Hi Krzystof, On 7/23/26 10:11, Krzysztof Kozlowski wrote: > On Wed, Jul 22, 2026 at 12:00:06AM +0530, Manaf Meethalavalappu Pallikunhi wrote: >> +properties: >> + compatible: >> + enum: >> + - qcom,pm7250b-bcl >> + - qcom,pm8350c-bcl >> + - qcom,pm8550-bcl >> + - qcom,pmh0101-bcl >> + - qcom,pmih0108-bcl >> + - qcom,smb2360-bcl >> + - qcom,smb2370-bcl >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 2 >> + >> + interrupt-names: >> + items: >> + - const: max-min >> + - const: critical >> + > > Binding looks in general ok, but feels incomplete. If this is battery > limiting hardware, does it actually need any battery data through > monitored-battery property? I'm not sure it is relevant here. The BCL is not a power supply neither a charger. It monitors a power supply output which can be a battery or another source of power AFAIU. The monitored-battery property is used by chargers or fuel gauges if I refer to the documentation. The BCL monitors the output of the power supply while the chargers monitors the input for the battery. Manaf, does it sound correct ?