From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BF5E3BE659 for ; Tue, 24 Mar 2026 10:48:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774349296; cv=none; b=gX9dkHbSfhAUCoxwwRiZWM55UelyFdWyAV+NbAikZsiLGciMPyBM3lshq6ScndCMcVjUcf0Vd3w2/mndCUcBa2zMSHCHZZWL+1gMQ3yn94arWGjoLdljMg0Xusw1v0ONJkEFc7cmOtEKPXVcHG2y7X/IsraJTlR0vzdzUBlX7fA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774349296; c=relaxed/simple; bh=9jANrywhGynZWMyKf2n6PWYNg/VaHuMRL315X+Xlo3E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YQNbBzmdil2kRwwF1hnqJig39jD8tMiFroRvznBkitpmmkGvi62BttDCYvY4SAEzgKcuCp8pE9dvGGnqlh+3F5c1m8IszuPBtZQOJf7gLxpFBkW86I1Hmvv4xsYV7lYXvO2nbgZ6lSjAFQ/EOArqt51De+bXgiU5ytraI7pEULs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ORsAYmbI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eTRBdWHw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ORsAYmbI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eTRBdWHw" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62O9rnkr3634275 for ; Tue, 24 Mar 2026 10:48:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= c9FRDksXZJcHie1G3wv2p+BeUJQkrbEedFfbFCXtXWM=; b=ORsAYmbI2YD1uoKq sva6GsEUA0I1BErH8DvCmRJhaBkGlZBWR7ctc/cx+OVmFmun+i+D2G74Lvwf8c0k APJG8qjHIipGdXj7jHuuKuVW7rLeWPS0T+UiVbAPBwU5MH8oYLxeidh469PEh1QQ btMTy6GRPg8W5kB3yIcO7RM5MhyubkiWUVBlohVSXdiwro8Li0f4QZ23pj7fHJOD BbnERRAwTExypJsxNTjsFTrqFuEEkBwd2OkgpSbwFyq/Cg6sH94L/vt9V2Vc8GCI a/9WSRWHUSCRYl4epM2Qy5pe2i+/Z60rnE6dlBYucww2AydB7DmfuyZGJ6VxDJe5 OKR6Bg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d34k4mnaj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 10:48:14 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2adef9d486bso40835275ad.2 for ; Tue, 24 Mar 2026 03:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774349294; x=1774954094; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c9FRDksXZJcHie1G3wv2p+BeUJQkrbEedFfbFCXtXWM=; b=eTRBdWHwoB23asfu6+AJoIAXAd72CK8XnMHuFeN6G0V2QssreW3JmOAn6Hr83KqXZU uYlaswOb+0lIYdT6OJ3Frva8uJGDcVXtUpFdQQ6j9tvDMNxqlhN+UVyXPWWNPyDhMpNC kLOntOBTUtI6fYzKb9T1O5eFOWSIVyWsO2bRPD1Dpv6afFhrqv6rA5ZR2J9oGYEyLcQI mLuMS42FusJIpj9hHdVuqjmZo+WL8rUFankgqzmocw085fri7lMozHHzAX557m3QbjHA MOrDV1qS2vSf3xBTDOhdXRZ7vvQcWfl1Od6a+HIXXfvinKuek/4326/qJUGJzYjZv3id 9stA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774349294; x=1774954094; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c9FRDksXZJcHie1G3wv2p+BeUJQkrbEedFfbFCXtXWM=; b=WQnPCG/rckZjVvl2HmF/ILpDMGsgNgETXHcJ4nNYRBPWin+ahpEVE94rLhqjj0zrvw i+jlivM47dBHbMnC+E5jVFiI1519WKpnrotwrhI56NsivRHGW4d3SDRO1wxVu/uh+ErF 6E2s95kk3K5YOpqc+PU+rY8ueNUjrM7UWwpNG7pWlP2pYwpMMIJTTaM/Lqio412XjJe9 5JEczmDiB0KcsT5FeqDwNs3ue9JUX05BGHJ3JFFcPKPh7xI+zHEIgrfCCq8RxM62qdso +PNySB2DltTbwimGaJ/38OeFTgj5saIQwQ6M7kze6FewCmoilFBK2JItqM5W82K5DfpV pasw== X-Forwarded-Encrypted: i=1; AJvYcCVZRD7Df+v+j4N/qLIiV68NaQWe1BtqdLoqBaS9EskWNK1o+clnX+A14gvjWSltdUlIVduX5xJ8hVFduXM=@vger.kernel.org X-Gm-Message-State: AOJu0YyajhWJ6D3giyC0VurmH2BhT574ouNsL+ucLVwvGb9FqG+TzPiD C0Ffp++hlMMO2HOCdf3C0YA43lUstTNXltAw6vFiIbqA+0s97Ho5vm2F9FWNGcDvPCzC8vtp0Vo u0zCx0CPk3/IaAMCbC1xY3Y78I6nHRMDSaMFQndAPSkz4ijWEuRvAiouFYDIdGw/P/bc= X-Gm-Gg: ATEYQzxP+RzezhtzyBk/UvpHxYyi5gdzIkri692Dosm59VFPL60zmyktubsIpOCoxiI IIR5YMYMnN9bLDC3eJmLeHH+N+YbYtGhsm0IhxAaXhRZPkHWRPRB6pN+xDhQ8gZW1pB+nkiyRHq SF4FIX+k17/qVlGajJVCkD6+YmTq1Nm1SpN3bCCf3s974ysx7tdmfikZ8nnXkE0eI7a4McBh9lq A/54SIkt2Yc2vfuKAFO7Sq+AuRlpVLA+jk3X1hW7pedHuOvpmiOIIkf+akpx1IKkxS8WB6qsI91 K7xyNWk11p+Tef1Nm6s5AeWK51V8AaaOJdbmmNycqteLzF/6rwjhbf1gtcYCjHkZ+TQun2edjX9 dI0Nj92AN9mpZ9DGKHFgflZhv+1pq2qJfONGAlnIeCZaW7zPrXLCo X-Received: by 2002:a17:903:22c6:b0:2ae:5a55:3ded with SMTP id d9443c01a7336-2b0827f767cmr149400865ad.45.1774349293692; Tue, 24 Mar 2026 03:48:13 -0700 (PDT) X-Received: by 2002:a17:903:22c6:b0:2ae:5a55:3ded with SMTP id d9443c01a7336-2b0827f767cmr149400415ad.45.1774349293190; Tue, 24 Mar 2026 03:48:13 -0700 (PDT) Received: from [10.218.44.178] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083679867sm166698485ad.65.2026.03.24.03.48.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 03:48:12 -0700 (PDT) Message-ID: <63b6b7c0-92ff-45d3-9559-3ec3b3a30a1d@oss.qualcomm.com> Date: Tue, 24 Mar 2026 16:18:02 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 05/11] arm64: dts: qcom: monaco: Add power-domain and iface clk for ice node To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Krzysztof Kozlowski References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> <20260323-qcom_ice_power_and_clk_vote-v4-5-e36044bbdfe9@oss.qualcomm.com> Content-Language: en-US From: Kuldeep Singh In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-5-e36044bbdfe9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: l03VLpEqWRGJQxsol9mj53LWOHZYR_13 X-Proofpoint-ORIG-GUID: l03VLpEqWRGJQxsol9mj53LWOHZYR_13 X-Authority-Analysis: v=2.4 cv=c+imgB9l c=1 sm=1 tr=0 ts=69c26bee cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=RcdfdvLsBkETvr5PKcUA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDA4NiBTYWx0ZWRfXzIgwlBsnJtN8 42ttbL4YLMlyPgo4Nua7UuZ8dw4e4NIhbZJ9Kwe4y0cM/NeEE0RMuiEw0lwAJS675gFOQZzaQtj oofAEMoWjY7L3/Rf6ZdEfk92rRXq+foFXKYA8HRtipXU2aoI84kR10hvyQ/QbwJi7Us+uD+FulA z2JSnoySBgCJ58yhoOrXNx5Dq0h7DlDgfhUgjACvSYbxSajqwaBv+nO92DQ0KCTYQX0eNoNrnDN 9m2mml7QdAw4Ktp2fVV7DiG8L3ORCPsgpcOnv5HngO7dpM8Sx3VmqV/OecuCzMLKWtiRdBbWTBn GQQBU3UnVNNGl1mQuZa3IeKBHQD13Kz2Ig1mVN2433w6s+BgN7hqF3+LrXl/pEI4mimAaWtjxLm 5X0aVcZ0TFW9O6lsTxTDV4ZyZa0vivJ8cvK2ERnQdj2edvEuiVICfGsTKqZo11ojUBfNhg24+P+ RAsRs2a2RuwJodK0GSg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_02,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240086 On 3/23/2026 2:47 PM, Harshal Dev wrote: > Qualcomm in-line crypto engine (ICE) platform driver specifies and votes > for its own resources. Before accessing ICE hardware during probe, to > avoid potential unclocked register access issues (when clk_ignore_unused > is not passed on the kernel command line), in addition to the 'core' clock > the 'iface' clock should also be turned on by the driver. This can only be > done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the > GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for > monaco. > > Fixes: cc9d29aad876d ("arm64: dts: qcom: qcs8300: enable the inline crypto engine") > Reviewed-by: Konrad Dybcio > Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh -- Regards Kuldeep