mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Marcus Folkesson <marcus.folkesson@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Wim Van Sebroeck <wim@iguana.be>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: coh901327: make license text and module licence match
Date: Sat, 10 Feb 2018 07:32:33 -0800	[thread overview]
Message-ID: <63b79477-3506-0cb7-3d5d-a2c34d2de82c@roeck-us.net> (raw)
In-Reply-To: <20180210092702.4393-1-marcus.folkesson@gmail.com>

On 02/10/2018 01:27 AM, Marcus Folkesson wrote:
> Licence text is specifying "GPLv2" but the MODULE_LICENSE is set to "GPLv2
> or later".
> 
> See include/linux/module.h:
> "GPL"				[GNU Public License v2 or later]
> "GPL v2"			[GNU Public License v2]
> 
> When on it, add SPDX identifier tag.
> 
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/coh901327_wdt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c
> index 5d8eb9a30879..7b71e0a3e6cc 100644
> --- a/drivers/watchdog/coh901327_wdt.c
> +++ b/drivers/watchdog/coh901327_wdt.c
> @@ -1,8 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
>   /*
>    * coh901327_wdt.c
>    *
>    * Copyright (C) 2008-2009 ST-Ericsson AB
> - * License terms: GNU General Public License (GPL) version 2
>    * Watchdog driver for the ST-Ericsson AB COH 901 327 IP core
>    * Author: Linus Walleij <linus.walleij@stericsson.com>
>    */
> @@ -420,5 +420,5 @@ MODULE_DESCRIPTION("COH 901 327 Watchdog");
>   module_param(margin, uint, 0);
>   MODULE_PARM_DESC(margin, "Watchdog margin in seconds (default 60s)");
>   
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
>   MODULE_ALIAS("platform:coh901327-watchdog");
> 

  reply	other threads:[~2018-02-10 15:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-10  9:27 Marcus Folkesson
2018-02-10 15:32 ` Guenter Roeck [this message]
2018-02-22 13:59 ` Linus Walleij
2018-02-10 14:53 Philippe Ombredanne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63b79477-3506-0cb7-3d5d-a2c34d2de82c@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=marcus.folkesson@gmail.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®