From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F7C4C433EF for ; Sun, 26 Jun 2022 20:02:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232149AbiFZUCa (ORCPT ); Sun, 26 Jun 2022 16:02:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232135AbiFZUC3 (ORCPT ); Sun, 26 Jun 2022 16:02:29 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3704555BE for ; Sun, 26 Jun 2022 13:02:28 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id e40so10387735eda.2 for ; Sun, 26 Jun 2022 13:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=L5luTbophPMtkkcPCTZKh24/A/2KpC32wThCfYNcqBw=; b=Ft2aRODYm0ooP4HVNITmIfrnQxEc1UVQXmL45t2je8p42F4zyOb1RtKjS4YngXvoeL N8ABZ6cSPXVSZ5JsNLY9Kqdd98xeFvOTS3xELRf9iN7+MsRnqNIqQCwzH13wgnZoS6IS xIzufEXQRLsizhjwafl1zU//kC1cdTkiU7hZw5HMtUI5TkauwJRQeOFgcOPZK84MVvmz NeCud2UCvQKFVFhifUXhW/yn5Ey9CGEghzzvjg6dBbhvGT0PUhzZcsEdm9hfg3mpKsAO aZNZ7M8xDKghh6dOR63Z4i00T+xo1WNkuCBz9ArPTKR6tE/TA953SEo+AGeW0fLoU0j4 SrJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=L5luTbophPMtkkcPCTZKh24/A/2KpC32wThCfYNcqBw=; b=u78l+SIaLk2Z+rAW2m3DEs9xQxZS+s0YJGFJA+Ih7iFMo2X5bEdk/pucYyybhTlYOO uMkNS8vUlIhV9UpswE0IZkzoqGQpnSPMzbC2IfIKw2dCUH58KABPmFYpZiqw2k15T1+S JxEcufynRf2YqoWmHRVRprMY/N7pBGfmTTcv+Qg30Kp19S5ZM3ojLU+BzMCz0kh+e4FJ XALRZ0SrqCHgnrbaAmaHonNNdcy0M3U9bH5+GYPM0xySjmSCAIMtayPxxVb7rNYNEdKe l9b39vl6ol9cQDqhOs3vJa4vHGO702lZ3xEE574o2R+kFQaA2KVEVA6eWY/lK4Nx5yiG Mlqg== X-Gm-Message-State: AJIora+JLehnitCkar30wGHlmXvdvemnisI+4MvGpfRJmo6LLWnCHSvg 1oAm4YIOVb93qbXu3lGNjA9IYQ== X-Google-Smtp-Source: AGRyM1uAX7GHluPWOZ+mm6n4aoUDMhbCqd/31547KKJrSeyePKgiWbv0/VTiEo5zhKBxoWInDD10Mw== X-Received: by 2002:a50:ff0e:0:b0:433:5d15:eada with SMTP id a14-20020a50ff0e000000b004335d15eadamr12551827edu.102.1656273746784; Sun, 26 Jun 2022 13:02:26 -0700 (PDT) Received: from [192.168.0.245] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id y1-20020aa7c241000000b004355dc75066sm6321979edo.86.2022.06.26.13.02.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jun 2022 13:02:26 -0700 (PDT) Message-ID: <63b7e653-d2d2-c1fc-e43f-1c70ecbe9d04@linaro.org> Date: Sun, 26 Jun 2022 22:02:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 2/2] NFC: nxp-nci: Don't issue a zero length i2c_master_read() Content-Language: en-US To: Michael Walle Cc: Charles Gorand , =?UTF-8?Q?Cl=c3=a9ment_Perrochaud?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220626194243.4059870-1-michael@walle.cc> <20220626194243.4059870-2-michael@walle.cc> <3c28bc43-4994-8e12-25f4-32b723e6e7ac@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/06/2022 21:56, Michael Walle wrote: > Am 2022-06-26 21:51, schrieb Krzysztof Kozlowski: >> On 26/06/2022 21:42, Michael Walle wrote: >>> There are packets which doesn't have a payload. In that case, the >>> second >>> i2c_master_read() will have a zero length. But because the NFC >>> controller doesn't have any data left, it will NACK the I2C read and >>> -ENXIO will be returned. In case there is no payload, just skip the >>> second i2c master read. >>> >>> Fixes: 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI >>> driver") >>> Signed-off-by: Michael Walle >> >> Reviewed-by: Krzysztof Kozlowski > > Thanks, I'll reorder the patches in the next version otherwise > there will likely be a conflict. Yes. > That should work with any patch > tools (i.e. b4), shouldn't it? You mean - re-ordering should work? Yes, no problem with that. Best regards, Krzysztof