From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] objtool: Print top level commands on incorrect usage
Date: Sat, 14 Oct 2017 20:08:21 +0530 [thread overview]
Message-ID: <63bd68eb-38d9-16b8-099f-bbc53aec40cb@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171013163821.2dnqljq2lxyvkfqu@treble>
On Friday 13 October 2017 10:08 PM, Josh Poimboeuf wrote:
[...]
>> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
>> ---
>> tools/objtool/objtool.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/tools/objtool/objtool.c b/tools/objtool/objtool.c
>> index 31e0f91..07f3299 100644
>> --- a/tools/objtool/objtool.c
>> +++ b/tools/objtool/objtool.c
>> @@ -70,7 +70,7 @@ static void cmd_usage(void)
>>
>> printf("\n");
>>
>> - exit(1);
>> + exit(129);
>
> For consistency with the rest of the code, this should be -1 instead of
> 129 (though the end result is the same).
>
Thanks for the review. exit(129) is returned by command line parser
when the usage is incorrect, except for cmd_usage(), where the exit
code 1. I will re-send the patch with the better commit message.
--
cheers,
Kamalesh.
prev parent reply other threads:[~2017-10-14 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 8:21 Kamalesh Babulal
2017-10-13 16:38 ` Josh Poimboeuf
2017-10-14 14:38 ` Kamalesh Babulal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63bd68eb-38d9-16b8-099f-bbc53aec40cb@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®