From: Ivan Vecera <ivecera@redhat.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
oe-kbuild@lists.linux.dev, intel-wired-lan@lists.osuosl.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org,
Jacob Keller <jacob.e.keller@intel.com>,
Wojciech Drewek <wojciech.drewek@intel.com>,
Simon Horman <horms@kernel.org>,
mschmidt@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH v5 4/5] i40e: Fix broken support for floating VEBs
Date: Wed, 29 Nov 2023 09:38:40 +0100 [thread overview]
Message-ID: <63bd858a-fe07-4eda-9835-d999e2905860@redhat.com> (raw)
In-Reply-To: <25111205-a895-46a2-b53f-49e29ba41b16@suswa.mountain>
On 27. 11. 23 9:43, Dan Carpenter wrote:
> 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14720
> 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14721 pf = veb->pf;
> 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14722
> 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14723 /* find the
> remaining VSI and check for extras */
> 0aab77d67d37d09 Ivan Vecera 2023-11-24 14724
> i40e_pf_for_each_vsi(pf, i, vsi_it)
> 0aab77d67d37d09 Ivan Vecera 2023-11-24 14725 if
> (vsi_it->uplink_seid == veb->seid) {
> 93a1bc91a1ccc5a Ivan Vecera 2023-11-24 14726 if
> (vsi_it->flags & I40E_VSI_FLAG_VEB_OWNER)
> 0aab77d67d37d09 Ivan Vecera 2023-11-24 14727 vsi = vsi_it;
>
> Do we always find a vsi? Presumably, yes, but it's not obvious just
> from reading this function.
Yes, if the VEB has uplink (veb->uplink_seid != 0) then it has to have a
downlink VSI that owns it (vsi->flags has I40E_VSI_FLAG_VEB_OWNER set)
Ivan
> 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14728 n++;
> 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14729 }
> 0aab77d67d37d09 Ivan Vecera 2023-11-24 14730
> 93a1bc91a1ccc5a Ivan Vecera 2023-11-24 14731 /* Floating VEB has
> to be empty and regular one must have
> 93a1bc91a1ccc5a Ivan Vecera 2023-11-24 14732 * single owner
> VSI.
> 93a1bc91a1ccc5a Ivan Vecera 2023-11-24 14733 */
> 93a1bc91a1ccc5a Ivan Vecera 2023-11-24 14734 if
> ((veb->uplink_seid && n != 1) || (!veb->uplink_seid
> && n != 0)) {
> 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14735
> dev_info(&pf->pdev->dev,
> 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14736 "can't remove
> VEB %d with %d VSIs left\n",
> 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14737 veb->seid,
> n);
> 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14738 return;
> 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14739 }
> 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14740
> 93a1bc91a1ccc5a Ivan Vecera 2023-11-24 14741 /* For regular VEB
> move the owner VSI to uplink VEB */
> 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14742 if
> (veb->uplink_seid) {
> 93a1bc91a1ccc5a Ivan Vecera 2023-11-24 @14743 vsi->flags
> &= ~I40E_VSI_FLAG_VEB_OWNER;
next prev parent reply other threads:[~2023-11-29 8:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 15:03 [PATCH iwl-next v5 0/5] i40e: Simplify VSI and VEB handling Ivan Vecera
2023-11-24 15:03 ` [PATCH v5 1/5] i40e: Use existing helper to find flow director VSI Ivan Vecera
2023-11-30 5:23 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-03 11:41 ` Simon Horman
2023-11-24 15:03 ` [PATCH v5 2/5] i40e: Introduce and use macros for iterating VSIs and VEBs Ivan Vecera
2023-11-30 5:23 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-03 11:41 ` Simon Horman
2023-11-24 15:03 ` [PATCH v5 3/5] i40e: Add helpers to find VSI and VEB by SEID and use them Ivan Vecera
2023-11-30 5:23 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-03 11:41 ` Simon Horman
2023-11-24 15:03 ` [PATCH v5 4/5] i40e: Fix broken support for floating VEBs Ivan Vecera
2023-11-27 8:43 ` Dan Carpenter
2023-11-29 8:38 ` Ivan Vecera [this message]
2023-11-30 5:23 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-03 16:22 ` Simon Horman
2023-11-24 15:03 ` [PATCH v5 5/5] i40e: Remove VEB recursion Ivan Vecera
2023-11-30 5:23 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-12-03 16:22 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63bd858a-fe07-4eda-9835-d999e2905860@redhat.com \
--to=ivecera@redhat.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®