From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E7EC2D0CE for ; Tue, 21 Jan 2020 09:19:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F6CB20882 for ; Tue, 21 Jan 2020 09:19:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729180AbgAUJTB (ORCPT ); Tue, 21 Jan 2020 04:19:01 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:9227 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729017AbgAUJTB (ORCPT ); Tue, 21 Jan 2020 04:19:01 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id C4CAB24DD88B7E0210E3; Tue, 21 Jan 2020 17:18:57 +0800 (CST) Received: from [127.0.0.1] (10.177.131.64) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Tue, 21 Jan 2020 17:18:51 +0800 Subject: Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0 To: Sergei Shtylyov , , , References: <20200121013553.15252-1-chenzhou10@huawei.com> <40eb3815-f677-c2fd-3e67-4b39bb332f48@cogentembedded.com> <86f4d4a0-627d-84aa-c785-4dac426b7cc6@huawei.com> CC: , From: Chen Zhou Message-ID: <63bef062-6a5a-c919-c805-798f19be5632@huawei.com> Date: Tue, 21 Jan 2020 17:18:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.131.64] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/1/21 17:01, Sergei Shtylyov wrote: > On 21.01.2020 11:54, Chen Zhou wrote: > >>>> Fixes coccicheck warning: >>>> >>>> ./drivers/net/ethernet/amd/declance.c:611:14-15: >>>> WARNING comparing pointer to 0 >>>> >>>> Compare pointer-typed values to NULL rather than 0. >>> >>> I don't see NULL in the patch -- you used ! instead. >> >> Yeah, i used ! here. > > Make the patch description match the diff, please. ok, i will fix this in next version. Thanks, Chen Zhou > >> Thanks, >> Chen Zhou > > MBR, Sergei > >