From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Hongfu Li <lihongfu@kylinos.cn>, Lorenzo Stoakes <ljs@kernel.org>
Cc: jgg@ziepe.ca, leon@kernel.org, akpm@linux-foundation.org,
liam@infradead.org, vbabka@kernel.org, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, shuah@kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, hongfu.li@linux.dev
Subject: Re: [PATCH] selftests/mm: Fix memleak in migration benchmark
Date: Mon, 13 Jul 2026 11:38:00 +0200 [thread overview]
Message-ID: <63c1b697-5c18-482b-8128-0ad172f9ecf6@kernel.org> (raw)
In-Reply-To: <1c0644c0-36e4-454b-adf0-47845036b39d@kylinos.cn>
On 7/13/26 10:07, Hongfu Li wrote:
> Hi, Lorenzo
>
> On 7/11/26 3:31 PM, Lorenzo Stoakes wrote:
>> On Wed, Jul 08, 2026 at 06:37:05PM +0800, Hongfu Li wrote:
>>> Several early return paths in run_migration_benchmark() skip
>>> hmm_buffer_free(), leaking the buffer. Replace with a single cleanup
>>> label.
>>>
>>> Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
>> LGTM. With the Fixes tag added as requested by David, feel free to add:
>>
>> Reviewed-by: Lorenzo Stoakes <ljs@kernel.org>
>
>
> Thank you for your review.
>
> As suggested by David, I have added the Fixes tag in v2. The patch
> has now been applied to the mm-new branch.
>
> Since the patch has already been merged into the public branch, I am
> unable to modify the commit message to add your Reviewed-by tag
> after merging. However, I truly appreciate your review.
If it's not in mm-stable / mm-hotfixes-stable or upstream, Andrew can always
modify the commit (which I assume he will do) or you can resend.
So far this patch seems to only be in mm-new ... which is far, far away from
upstream.
--
Cheers,
David
prev parent reply other threads:[~2026-07-13 9:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 10:37 Hongfu Li
2026-07-08 13:15 ` David Hildenbrand (Arm)
2026-07-09 1:54 ` Hongfu Li
2026-07-09 1:09 ` SJ Park
2026-07-09 2:02 ` Hongfu Li
2026-07-09 2:37 ` Andrew Morton
2026-07-09 3:03 ` Hongfu Li
2026-07-11 7:31 ` Lorenzo Stoakes
[not found] ` <1c0644c0-36e4-454b-adf0-47845036b39d@kylinos.cn>
2026-07-13 9:38 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63c1b697-5c18-482b-8128-0ad172f9ecf6@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hongfu.li@linux.dev \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=liam@infradead.org \
--cc=lihongfu@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome