From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751562AbdB0DGm (ORCPT ); Sun, 26 Feb 2017 22:06:42 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:37474 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751486AbdB0DGk (ORCPT ); Sun, 26 Feb 2017 22:06:40 -0500 X-AuditID: b6c32a2e-f79d66d0000012ad-6c-58b397b1a75e Subject: Re: [PATCH 1/2] media: s5p-mfc: convert drivers to use the new vb2_queue dev field To: Javier Martinez Canillas , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kyungmin.park@samsung.com, jtp.park@samsung.com, mchehab@kernel.org, mchehab@osg.samsung.com, hans.verkuil@cisco.com, krzk@kernel.org, kgene@kernel.org, Smitha T Murthy From: "pankaj.dubey" Message-id: <63c351de-6b2f-3d32-ccbd-898e4443a4bf@samsung.com> Date: Mon, 27 Feb 2017 08:39:16 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPKsWRmVeSWpSXmKPExsWy7bCmpu7G6ZsjDL78Y7FY8nMXk8Wbt2uY LI6svcpk0f/4NbPF+fMb2C3ONr1ht9j0+BqrxeVdc9gsejZsZbWYcX4fk8WyTX+YLFY/q7C4 u2cbowOvx5TfG1k9Nq3qZPPYvKTeY0v/XXaPvi2rGD0+b5ILYIvisklJzcksSy3St0vgyli/ YAJLQYtUxezzh5gbGM+LdjFyckgImEis6X/JBGGLSVy4t56ti5GDQ0hgKaPEX+MuRi4g8xOj xO2D+1ngnMc3/7DDNP/buZIVIrGTUeLm7aPscFU7Z89gBKkSFoiVOHNxKhtIQkRgL6PEtncn mEESzALHGSXWbnIDsdkE9CWmP97GBmLzCthJ/Dl3DmwFi4CqxLr9S8BsUYEIiaP/P7BA1AhK nJz5hAXkVk4BZ4kjv4ogRhpIHFk0hxXClpfY/nYOM8heCYFudolDa/awg9RLCLhIrF2ZAvGB sMSr41ugvpGSeNnfxg5R38wo0bB1CguEM4NRYsHOydBAspc4cGUOC4RtK3Hp4Q8WiKF8Ejfe CkIs5pPo/f0EqlxN4vvzM8wQJbwSHW1CEGEPiU+TTjNNYFSaheSbWUhemIXkhQWMzKsYxVIL inPTU4tNC4z1ihNzi0vz0vWS83M3MYKTlZbeDsZ/C7wPMQpwMCrx8Hb4bo4QYk0sK67MPcQo wcGsJMLrChLiTUmsrEotyo8vKs1JLT7EKM3BoiTOG2UwMUJIID2xJDU7NbUgtQgmy8TBKdXA 2GbvsqnscsaeRM+A/jWTC2ZeZN6lJvQjc6PQCvVTypuDvnHMqTwx6Y5BePcXgwLtlRkWtf+s g0U8l5wPZ1ygajV9usMBXxe5a6eX/hHsiJqutGnyScmVMtvmvSk7+biuxd/F7t20tKB1Mxf+ lqu6vuPtE7vkmPjDgQemZMW1hfDEK+zwrTSrVmIpzkg01GIuKk4EAODnPqlSAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKIsWRmVeSWpSXmKPExsWy7bCSvG7x9M0RBk8WmFgs+bmLyeLN2zVM FkfWXmWy6H/8mtni/PkN7BZnm96wW2x6fI3V4vKuOWwWPRu2slrMOL+PyWLZpj9MFqufVVjc 3bON0YHXY8rvjawem1Z1snlsXlLvsaX/LrtH35ZVjB6fN8kFsEVx2aSk5mSWpRbp2yVwZaxf MIGloEWqYvb5Q8wNjOdFuxg5OSQETCT+7VzJCmGLSVy4t56ti5GLQ0hgO6PEnXe7mSESGhIb 7yxngrCFJVb+e84OUfSBUeJP831GkISwQKzEmYtT2UBsEYG9jBJrZ9pCFE1hkji0aworiMMs cJxRYu+ju2AdbAL6EtMfbwPr4BWwk/hz7hw7iM0ioCqxbv8SIJuDQ1QgQuJbHztEiaDEyZlP WEDCnALOEkd+FYGEmQX0JHZc/8UKYctLbH87h3kCo9AsJB2zkJTNQlK2gJF5FaNoakFxbnpu cYGRXnFibnFpXrpecn7uJkZwZGkl7WDcNCP8EKMAB6MSD69F0OYIIdbEsuLK3EOMEhzMSiK8 rr5AId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rzbqzdECAmkJ5akZqemFqQWwWSZODilGhjXls2Z 9GPOOvZHEQf+rF4xqUv2/ZENBaFnLOddefzUWW/Pt03XnAyE+Vd2FllKPKv/U5DALOMQ7Dz3 mPvm1WULDtnutLeUFfkg869aQrb/90r1Y9c4Zta+5Zt5oGntrZrADV4Jnq8PsSiJ9p7/9kTO fHPfyWvpjtuuTHMofKZ+KXqlnz6vsO5fJZbijERDLeai4kQAc5PpTagCAAA= X-CMS-MailID: 20170227030624epcas5p36c9ddfb80c6ff1b96e90802818099a33 X-Msg-Generator: CA X-Sender-IP: 182.195.40.13 X-Local-Sender: =?UTF-8?B?7YyQ7Lm07KaIG1NTSVItVHVybiBLZXkgU29sdXRpb25zGw==?= =?UTF-8?B?7IK87ISx7KCE7J6QGy4vQ2hpZWYgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?UEFOS0FKIEtVTUFSIERVQkVZG1NTSVItVHVybiBLZXkgU29s?= =?UTF-8?B?dXRpb25zG1NhbXN1bmcgRWxlY3Ryb25pY3MbLi9DaGllZiBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElEMDdJRDAxMDk5Nw==?= X-MTR: 20170227030624epcas5p36c9ddfb80c6ff1b96e90802818099a33 X-EPHeader: CA CMS-TYPE: 105P X-Auth-Email: pankaj.dubey@samsung.com X-HopCount: 7 X-CMS-RootMailID: 20170224192311epcas1p34370fb737bd0d30e592431809d0dc540 X-RootMTR: 20170224192311epcas1p34370fb737bd0d30e592431809d0dc540 References: <1481888915-19624-1-git-send-email-pankaj.dubey@samsung.com> <1481888915-19624-2-git-send-email-pankaj.dubey@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Javier, On Saturday 25 February 2017 12:52 AM, Javier Martinez Canillas wrote: > Hello Pankaj, > > On 12/16/2016 08:48 AM, Pankaj Dubey wrote: >> From: Smitha T Murthy >> >> commit 2548fee63d9e ("[media] media/platform: convert drivers to use the new >> vb2_queue dev field") has missed to set dev pointer of vb2_queue which will be >> used in reqbufs of mfc driver. Without this change following error is observed: >> >> --------------------------------------------------------------- >> V4L2 Codec decoding example application >> Kamil Debski >> Copyright 2012 Samsung Electronics Co., Ltd. >> >> Opening MFC. >> (mfc.c:mfc_open:58): MFC Info (/dev/video0): driver="s5p-mfc" \ >> bus_info="platform:12c30000.mfc0" card="s5p-mfc-dec" fd=0x4[ >> 42.339165] Remapping memory failed, error: -6 >> >> MFC Open Success. >> (main.c:main:711): Successfully opened all necessary files and devices >> (mfc.c:mfc_dec_setup_output:103): Setup MFC decoding OUTPUT buffer \ >> size=4194304 (requested=4194304) >> (mfc.c:mfc_dec_setup_output:120): Number of MFC OUTPUT buffers is 2 \ >> (requested 2) >> >> [App] Out buf phy : 0x00000000, virt : 0xffffffff >> Output Length is = 0x300000 >> Error (mfc.c:mfc_dec_setup_output:145): Failed to MMAP MFC OUTPUT buffer >> ------------------------------------------------------- >> > > On which kernel version did you face this issue? > We observed this issue, on Linux 4.9 kernel while doing some experiment for using reserved-memory for MFC on Exynos7880 based development board. Anyways FYI, This patch is series is superseded by patch [1] after review comments and suggestion from Marek. Patch [1] has been accepted and merged and working well for us. [1]: https://patchwork.kernel.org/patch/9482499/ Thanks, Pankaj Dubey >> Signed-off-by: Smitha T Murthy >> [pankaj.dubey: debugging issue and formatting commit message] >> Signed-off-by: Pankaj Dubey >> --- >> drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c >> index 0a5b8f5..6ea8246 100644 >> --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c >> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c >> @@ -838,6 +838,7 @@ static int s5p_mfc_open(struct file *file) >> q->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE; >> q->drv_priv = &ctx->fh; >> q->lock = &dev->mfc_mutex; >> + q->dev = &dev->plat_dev->dev; >> if (vdev == dev->vfd_dec) { >> q->io_modes = VB2_MMAP; >> q->ops = get_dec_queue_ops(); >> @@ -861,6 +862,7 @@ static int s5p_mfc_open(struct file *file) >> q->io_modes = VB2_MMAP; >> q->drv_priv = &ctx->fh; >> q->lock = &dev->mfc_mutex; >> + q->dev = &dev->plat_dev->dev; >> if (vdev == dev->vfd_dec) { >> q->io_modes = VB2_MMAP; >> q->ops = get_dec_queue_ops(); >> > > Please correct me if I'm wrong, but AFAIU this shouldn't be needed in > the s5p-mfc driver since the videobuf2 core either uses the vb2_queue > .dev field or the vb2_queue .alloc_devs. And the latter is set in the > s5p_mfc_queue_setup() function, so the .dev field shouldn't be used. > > Best regards, >