mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Darshana Padmadas <darshanapadmadas@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, josh@joshtriplett.org,
	Darshana Padmadas <darshanapadmadas@gmail.com>
Subject: [PATCH 05/16] arch: x86: kernel: Make internal functions static in cpu/intel_cacheinfo.c
Date: Wed,  4 Mar 2015 19:02:07 +0530	[thread overview]
Message-ID: <63cb1aefe4d19b7526fe1ae2fb8066152eba1c8b.1425473428.git.darshanapadmadas@gmail.com> (raw)
In-Reply-To: <cover.1425473428.git.darshanapadmadas@gmail.com>
In-Reply-To: <cover.1425473428.git.darshanapadmadas@gmail.com>

cpu/intel_cacheinfo.c defines two functions amd_get_l3_disable_slot
and amd_set_l3_disable_slot. No other file uses these functions.
So make these static.

This eliminates the following warnings:

arch/x86/kernel/cpu/intel_cacheinfo.c:349:5: warning: no previous prototype for ‘amd_get_l3_disable_slot’ [-Wmissing-prototypes]
arch/x86/kernel/cpu/intel_cacheinfo.c:427:5: warning: no previous prototype for ‘amd_set_l3_disable_slot’ [-Wmissing-prototypes]

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
---
 arch/x86/kernel/cpu/intel_cacheinfo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
index 6596433..c5ab252 100644
--- a/arch/x86/kernel/cpu/intel_cacheinfo.c
+++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
@@ -346,7 +346,7 @@ static void amd_init_l3_cache(struct _cpuid4_info_regs *this_leaf, int index)
  *
  * @returns: the disabled index if used or negative value if slot free.
  */
-int amd_get_l3_disable_slot(struct amd_northbridge *nb, unsigned slot)
+static int amd_get_l3_disable_slot(struct amd_northbridge *nb, unsigned slot)
 {
 	unsigned int reg = 0;
 
@@ -424,7 +424,7 @@ static void amd_l3_disable_index(struct amd_northbridge *nb, int cpu,
  *
  * @return: 0 on success, error status on failure
  */
-int amd_set_l3_disable_slot(struct amd_northbridge *nb, int cpu, unsigned slot,
+static int amd_set_l3_disable_slot(struct amd_northbridge *nb, int cpu, unsigned slot,
 			    unsigned long index)
 {
 	int ret = 0;
-- 
1.9.1


  parent reply	other threads:[~2015-03-04 13:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 13:32 [PATCH 00/16] Eliminate GCC -Wmissing-prototype warnings Darshana Padmadas
2015-03-04 13:32 ` [PATCH 01/16] arch: x86: boot: Make function static and add function prototype Darshana Padmadas
2015-03-04 18:50   ` Ingo Molnar
2015-03-04 13:32 ` [PATCH 02/16] arch: x86: boot: Add prototype for decompress_kernel Darshana Padmadas
2015-03-04 13:32 ` [PATCH 03/16] arch: x86: boot: Include header string.h for function prototypes Darshana Padmadas
2015-03-04 13:32 ` [PATCH 04/16] arch: x86: ia32: Add prototype for compat_ni_syscall Darshana Padmadas
2015-03-04 13:32 ` Darshana Padmadas [this message]
2015-03-04 18:46   ` [PATCH 05/16] arch: x86: kernel: Make internal functions static in cpu/intel_cacheinfo.c Borislav Petkov
2015-03-04 18:54     ` Ingo Molnar
2015-03-04 13:32 ` [PATCH 06/16] arch: x86: kernel: cpu: Mark function mce_chrdev_write static Darshana Padmadas
2015-03-04 13:32 ` [PATCH 07/16] arch: x86: kernel: Mark internal function EVT_TO_HPET_DEV static Darshana Padmadas
2015-03-04 13:32 ` [PATCH 08/16] arch: x86: kernel: Mark internal functions static in kvm.c Darshana Padmadas
2015-03-04 13:32 ` [PATCH 09/16] arch: x86: kernel: Include <asm/switch_to.h> for function prototype Darshana Padmadas
2015-03-04 13:32 ` [PATCH 10/16] arch: x86: kernel: Add prototype for function sys32_x32_rt_sigreturn Darshana Padmadas
2015-03-04 13:32 ` [PATCH 11/16] arch: x86: kernel: Add prototype for smp_reboot_interrupt Darshana Padmadas
2015-03-04 13:32 ` [PATCH 12/16] arch: x86: kernel: Add prototype for fixup_bad_iret in traps.c Darshana Padmadas
2015-03-04 13:32 ` [PATCH 13/16] arch: x86: xen: Add prototype for xen_start_kernel in enlighten.c Darshana Padmadas
2015-03-04 13:32 ` [PATCH 14/16] arch: x86: xen: Mark internal function xen_flush_tlb_all static Darshana Padmadas
2015-03-04 13:32 ` [PATCH 15/16] arch: x86: xen: Add prototypes for functions defined in mmu.c Darshana Padmadas
2015-03-04 13:32 ` [PATCH 16/16] arch: x86: xen: Mark internal functions static in setup.c Darshana Padmadas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63cb1aefe4d19b7526fe1ae2fb8066152eba1c8b.1425473428.git.darshanapadmadas@gmail.com \
    --to=darshanapadmadas@gmail.com \
    --cc=hpa@zytor.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®