From: John Garry <john.garry@huawei.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
<jinpu.wang@cloud.ionos.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>
Cc: <Viswas.G@microchip.com>, <Ajish.Koshy@microchip.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: pm8001: Fix phys_to_virt() usage on dma_addr_t
Date: Mon, 13 Dec 2021 09:16:02 +0000 [thread overview]
Message-ID: <63cc50a5-b7ce-5930-68f1-039a71178b48@huawei.com> (raw)
In-Reply-To: <5d1b0c7c-90c6-8aba-3153-29df6eac865d@opensource.wdc.com>
On 11/12/2021 00:26, Damien Le Moal wrote:
>> ss
>> @@ -4320,20 +4324,20 @@ static int pm80xx_chip_smp_req(struct pm8001_hba_info *pm8001_ha,
>> pm8001_dbg(pm8001_ha, IO, "SMP REQUEST DIRECT MODE\n");
>> for (i = 0; i < length; i++)
>> if (i < 16) {
>> - smp_cmd.smp_req16[i] = *(preq_dma_addr+i);
>> + smp_cmd.smp_req16[i] = *(payload+i);
> Maybe add spacs around the "+" as you did above ?
Yeah, right. I noticed now that only strict mode of checkpatch picks up
on this.
>
>> pm8001_dbg(pm8001_ha, IO,
>> "Byte[%d]:%x (DMA data:%x)\n",
>> i, smp_cmd.smp_req16[i],
...
>> }
>> -
>> + kunmap_atomic(to);
>> build_smp_cmd(pm8001_dev->device_id, smp_cmd.tag,
>> &smp_cmd, pm8001_ha->smp_exp_mode, length);
>> rc = pm8001_mpi_build_cmd(pm8001_ha, circularQ, opc, &smp_cmd,
> Otherwise, looks OK to me.
cheers
prev parent reply other threads:[~2021-12-13 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 17:51 John Garry
2021-12-11 0:26 ` Damien Le Moal
2021-12-13 9:16 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63cc50a5-b7ce-5930-68f1-039a71178b48@huawei.com \
--to=john.garry@huawei.com \
--cc=Ajish.Koshy@microchip.com \
--cc=Viswas.G@microchip.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®