From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89FE533C192 for ; Tue, 4 Aug 2026 04:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785817806; cv=none; b=Dg0yT/b3iYdjvrwEv6Au4BjyN0F/2Hp2I922eK7WHAnI4qWqOIOhB+BFDhZB0AMVdWmm81afK8MItcIHdrU0SeqFL0e6PU5GtwbXq05lhf0k8VdDQpOdy/Hnd0mXedCeUbafTl2OHWFHJ2nY9/OmXKRSUy91cveHXBMsivGUC7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785817806; c=relaxed/simple; bh=qMoQOUd6RllASsHgB+CvzuymSNu1GngPZDEh2pZ29GM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JLZTntEss9zU2EtUF99D+u/I8Jd2BgN6WZj4enZHmTM8vV+HFixM/CsPMn02cdMNHug1vCGksgsonsOhub9QOGUFDhcfz8AcR/erTEMmPqbCiC6Gg73fcPWasfny8CG6jIjGGLQutxfr1gEc+h+REwdpkDYm1HqOGaO5K8incWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bq+BQwCQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SStd2LTD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bq+BQwCQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SStd2LTD" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67418W932591684 for ; Tue, 4 Aug 2026 04:30:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VfrYsc6RU2I/c+tuyid9lRUJCjOygwXHS3YpnCC4TT0=; b=bq+BQwCQtb3wiLtn eLEDQ7LnWkbMAswB/LGIszI2TBaxxKPCNsnc82yVRu6Bvjgget5SNIOIbTZKTo33 aA+rhSfLX5lEbjXs+31Cki33NjmODHkG7Uy45bE73KTxSMCG0RLchBor2kRla9Ap Y0lIOHeBsAIk2Ql6LHjZ6xg6tG4Utf8/QuJpleSXFtvEe25awOKAzyJfpC8NjYWW unKWKfzUSAKxPRrGjqpGkoZ8LW9JGgy6GIsM3GuEcHU4z3ei9oxKzS5ryuMJwYvq 5bDztdB0OFHcvdQNkaDNAG31VQs+mjlzKxUSYJm+uTQIY6tSjcRQqmH6w9OBphzd lILolQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fu3vs136j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Aug 2026 04:30:02 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-84e01a62d99so6003420b3a.0 for ; Mon, 03 Aug 2026 21:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785817801; x=1786422601; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VfrYsc6RU2I/c+tuyid9lRUJCjOygwXHS3YpnCC4TT0=; b=SStd2LTDxBKl7JKJ+FBNdn4L/hQucgm1pWwoKAuicr74MKscsF328UxEpkZgqvZl6c uOQRmBriwFmmkIkOhfWns8FSNglcQXnLmLlKequMqMvTdGqFCq92vpO92MlxdMm5v456 zvENKExU8kEGssdtoSs9oHTwdL2wT9QOEbQkHcXTXWkfGmGM2R680dXuqItitHHnXDbT VFrqEZbY93NLhkVvjaekI/CIaehhipnXtaCcwn+J3aGScBTnIXOSgxcYtOfCSedRrMeX /rv0JF1IYw08R+iOSF/MubdSLbKpKzmtHkfy/9K7eWisYp5pcTQUChNa1zoOgitTshbF /c0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785817801; x=1786422601; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VfrYsc6RU2I/c+tuyid9lRUJCjOygwXHS3YpnCC4TT0=; b=mu+flyN7uVr04PZ5XfussSLdO5bYWOwW6YKVHjA5DDSA5hdVPIlgwH6Ul3tLYvhdkL YwGfm/baNUBAjnuVe6pQvEkKOO1XDJEGgg1CWl0F2Oerc1eMxCh+XR9V9wEAtRrcGBbG 6YJQ5IOsuiUezU/v2Sb8CqzmFzzXogH/bn4yLHKtgw+peKHmpcmCT39PCI2J7Rp2Eyc/ GfED0Wvn346TDNWS+/z1TH5AKTWVF/VaXZwSvvDMWnL0s6XpBUwRWXCTaLbBkGGq1wYC WSLMM0wF2c5i7EmJkxRc9vvxcTSl38elFeWSfToh0wP27uWmqVpFsOSA3hoEZ02e1dYs OTNA== X-Forwarded-Encrypted: i=1; AHgh+Rr3xg+CZjuXRGkFdk/84ECi+pKfvtfLukofFH5LMadUCJq+/zFdLXKpUmD8jNAz8TAQgVNKmtbzn3NhxVI=@vger.kernel.org X-Gm-Message-State: AOJu0Yya6yX+cc5SJ7UuG9oAsHs4RX+Mf1BauFE1PaG/dHwa1hmgClVc +KvZ/Ca0Ot/vB1AecVgUc9xKOa1rmXmTHTPJhv38SiyzE7a6P+zm5rvUornlL6w2qDW06qIrqok cvnoJ/jKYkfLH+Iqm2Xd1dKWfYlFS5UfdQO5R3GBYXWPDyWqxOYXvwTHNsIsxcLtaeg== X-Gm-Gg: AR+sD13ZbTTQdHb79/LIqMiAJ5FWzOu1XbuH0YSm9rcwSomAEhT9CWJmwIWPk2tEX1D KBP02DSMaomU1UpgXw+tGHWXygFoCPfIB5PmIaC3M+ivLbljeiUAJElYg0sCBD07gn0Ttv9kIG6 dRDWk3WdDlK4UK5lP9Nv2yP0Xi+DySTtYS7W2MN08Sz4/ae5CrQVK+r7T2XzSBsxRhcGHyuCu+G wScW+GB2UY0+balvKMXZYSVYSMgelAY5ZMCqQRKKeyVp/qzWnJ2F8lqQTQFfdKV0B+pw2zeVPrj NMVs8M14CjMBs+wMUqr+sjqt1tLILQkb2l8a8wHVPmqmbM/G/+Q49ECs3uH4lb3Z7RwXLMhrcvP 6j4Ij1mu9sTnA78hsN0QBheT92QTlYaocBw== X-Received: by 2002:a05:6a00:1906:b0:84e:5e0:9db6 with SMTP id d2e1a72fcca58-84ee48a4cf7mr10990819b3a.40.1785817800884; Mon, 03 Aug 2026 21:30:00 -0700 (PDT) X-Received: by 2002:a05:6a00:1906:b0:84e:5e0:9db6 with SMTP id d2e1a72fcca58-84ee48a4cf7mr10990797b3a.40.1785817800371; Mon, 03 Aug 2026 21:30:00 -0700 (PDT) Received: from [192.168.1.86] ([206.83.118.41]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84edbd3159bsm4569664b3a.7.2026.08.03.21.29.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 21:29:59 -0700 (PDT) Message-ID: <63cfff1e-359b-4db9-97a8-43d97abb0369@oss.qualcomm.com> Date: Tue, 4 Aug 2026 14:29:52 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] tee: remove TZMEM_MODE_GENERIC To: Julian Braha , jenswi@kernel.org Cc: sumit.garg@kernel.org, arnd@arndb.de, geert+renesas@glider.be, amirreza.zarrabi@oss.qualcomm.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, quic_eberman@quicinc.com, andersson@kernel.org, brgl@kernel.org, harshal.dev@oss.qualcomm.com References: <20260729203845.387239-1-julianbraha@gmail.com> Content-Language: en-US From: Amirreza Zarrabi In-Reply-To: <20260729203845.387239-1-julianbraha@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDAzMiBTYWx0ZWRfX4haVjSWExT9O iZ10S2jgZeAIO8GK85blw+S/6j7suD3+I6r9N2iunFd6mOV+UlZ3i9VhCM8aU8tY6BYcYIgqoKe 8kT0QWfxtwq+aYGjc330HFZoZHgSXxOAQQjbGxu2fEi0jaAnnr2uJsQxY2PaFgkZgM/E17RG4rn wWQXTNsL/zPmElkRddZ3jM4pny39Acd3mdwd9dry7nidyh9hm4SdXbQMwHpWsLxcDgqxkshM/6L Dx4aECq4ex9DPNbQp9z0Q5hUsBPG4toghI9lG0+QcRohUj2zTnuzo2+rmxLf32/Ms+NErZZF19z e4NHpZEKLLxDq/G4nEtnMqtTEJoG7x2/lSztIlOsnti8cN9/4JHpFdIrSTCuX23oP1s7wgc7FmZ Z7x+hA5fBFqsUJGTKakZfKSvvGjJiIjmZw6q8/t3GGscpWn9zPSGBRVaNq+dNBMODtBFWY5Zj0i CRK9yMDdVSmP3bnLULQ== X-Proofpoint-ORIG-GUID: PzeTgYKWml7OxpuKPFMJvYmyhBQ3D3b7 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDAzMiBTYWx0ZWRfX5ua7cMHk2sJX d85X3Gzl3Q7+oWD1koBqCgyc/MitzAgRIvza4/uMLc8chk5h49FKQi8FmjKYOsKXskKuVfERn84 Q2gG5xbiN2ZXRgweBC6MK3n01Yif/y8= X-Authority-Analysis: v=2.4 cv=EK82FVZC c=1 sm=1 tr=0 ts=6a716aca cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=P7rZ2Udeej982rJtnmwBRA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EZfUo5YVX42GmVgghzkA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: PzeTgYKWml7OxpuKPFMJvYmyhBQ3D3b7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-04_01,2026-08-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 adultscore=0 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608040032 Hi Julian, With this change, is QCOM_TZMEM_MODE_SHMBRIDGE still needed? I think QCOM_TZMEM_MODE_SHMBRIDGE can therefore be removed entirely, along with the conditional declarations and stubs in qcom_tzmem.h and the corresponding select in the qcomtee Kconfig. Regards, Amir On 7/30/2026 6:38 AM, Julian Braha wrote: > 'select' does not work on config options in a 'choice', so currently it is > possible to enable QCOMTEE without QCOM_TZMEM_MODE_SHMBRIDGE, even though > this is needed at runtime. > > There are no users of the generic allocator option, > QCOM_TZMEM_MODE_GENERIC, so let's remove it. Then, we can remove the > containing choice..endchoice, which allows the 'select' to work as > intended. > > Suggested-by: Arnd Bergmann > Signed-off-by: Julian Braha > --- > Changes since v1: > - remove TZMEM_MODE_GENERIC instead of removing the dead select > > Link: > https://lore.kernel.org/all/20260715092539.18384-1-julianbraha@gmail.com/ > --- > drivers/firmware/qcom/Kconfig | 26 +++++--------------------- > drivers/firmware/qcom/qcom_tzmem.c | 21 --------------------- > 2 files changed, 5 insertions(+), 42 deletions(-) > > diff --git a/drivers/firmware/qcom/Kconfig b/drivers/firmware/qcom/Kconfig > index c7f8413ab996..d99e09c5fa18 100644 > --- a/drivers/firmware/qcom/Kconfig > +++ b/drivers/firmware/qcom/Kconfig > @@ -34,33 +34,17 @@ config QCOM_TZMEM > tristate > select GENERIC_ALLOCATOR > > -choice > - prompt "TrustZone interface memory allocator mode" > - depends on QCOM_TZMEM > - default QCOM_TZMEM_MODE_GENERIC > - help > - Selects the mode of the memory allocator providing memory buffers of > - suitable format for sharing with the TrustZone. If in doubt, select > - 'Generic'. > - > -config QCOM_TZMEM_MODE_GENERIC > - bool "Generic" > - help > - Use the generic allocator mode. The memory is page-aligned, non-cachable > - and physically contiguous. > - > config QCOM_TZMEM_MODE_SHMBRIDGE > - bool "SHM Bridge" > + bool "TrustZone interface memory allocator: SHM Bridge" > + depends on QCOM_TZMEM > help > - Use Qualcomm Shared Memory Bridge. The memory has the same alignment as > - in the 'Generic' allocator but is also explicitly marked as an SHM Bridge > - buffer. > + Use Qualcomm Shared Memory Bridge as memory allocator. The memory has the > + same alignment as in the 'Generic' allocator but is also explicitly marked > + as an SHM Bridge buffer. > > With this selected, all buffers passed to the TrustZone must be allocated > using the TZMem allocator or else the TrustZone will refuse to use them. > > -endchoice > - > config QCOM_QSEECOM > bool "Qualcomm QSEECOM interface driver" > depends on QCOM_SCM=y > diff --git a/drivers/firmware/qcom/qcom_tzmem.c b/drivers/firmware/qcom/qcom_tzmem.c > index 0635cbeacfc8..5b3e5a3ad1ae 100644 > --- a/drivers/firmware/qcom/qcom_tzmem.c > +++ b/drivers/firmware/qcom/qcom_tzmem.c > @@ -49,25 +49,6 @@ static struct device *qcom_tzmem_dev; > static RADIX_TREE(qcom_tzmem_chunks, GFP_ATOMIC); > static DEFINE_SPINLOCK(qcom_tzmem_chunks_lock); > > -#if IS_ENABLED(CONFIG_QCOM_TZMEM_MODE_GENERIC) > - > -static int qcom_tzmem_init(void) > -{ > - return 0; > -} > - > -static int qcom_tzmem_init_area(struct qcom_tzmem_area *area) > -{ > - return 0; > -} > - > -static void qcom_tzmem_cleanup_area(struct qcom_tzmem_area *area) > -{ > - > -} > - > -#elif IS_ENABLED(CONFIG_QCOM_TZMEM_MODE_SHMBRIDGE) > - > #include > #include > > @@ -189,8 +170,6 @@ static void qcom_tzmem_cleanup_area(struct qcom_tzmem_area *area) > kfree(handle); > } > > -#endif /* CONFIG_QCOM_TZMEM_MODE_SHMBRIDGE */ > - > static int qcom_tzmem_pool_add_memory(struct qcom_tzmem_pool *pool, > size_t size, gfp_t gfp) > {